-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate extensions from schema URLs #664
Merged
jisantuc
merged 11 commits into
master
from
feature/js/validate-extensions-from-schemas
Apr 14, 2021
Merged
Validate extensions from schema URLs #664
jisantuc
merged 11 commits into
master
from
feature/js/validate-extensions-from-schemas
Apr 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
suggested changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works locally! I left a couple of question in comments though.
application/src/main/scala/com/azavea/franklin/api/Server.scala
Outdated
Show resolved
Hide resolved
application/src/main/scala/com/azavea/franklin/api/services/CollectionItemsService.scala
Outdated
Show resolved
Hide resolved
application/src/main/scala/com/azavea/franklin/api/services/CollectionsService.scala
Show resolved
Hide resolved
application/src/main/scala/com/azavea/franklin/extensions/validation/package.scala
Show resolved
Hide resolved
application/src/main/scala/com/azavea/franklin/extensions/validation/package.scala
Show resolved
Hide resolved
jisantuc
force-pushed
the
feature/js/validate-extensions-from-schemas
branch
from
April 14, 2021 15:53
e5c95e8
to
1bc9ced
Compare
pomadchin
approved these changes
Apr 14, 2021
This was referenced Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces mechanisms to read extension validators from JSON schemata. This flow involves handling a few distinct kinds of error:
after all of this, we should eventually get a function using that Schema from Item => Item or Collection => Collection that we can use for validation on read.
This costly process is wrapped in a
Ref
(we're not on 3.x yet but the basics are the same) so that we don't have to try the same sequence of resolutions every time we see the special string.Checklist
Notes
I've asked in STAC gitter about what others are doing about the json schema links. This might end up being a roll-our-own situation if we don't have good library support for resolving with links. I think we can do that on top of circe-json-schema without too much hassle though.
Testing Instructions