feat(conditions): add rankmask flag selector #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok dont work... |
src/app/features/conditions/edit-conditions/conditions.component.ts
Outdated
Show resolved
Hide resolved
|
build fails because of minor codestyle issues: |
|
I thought the errors was at the bottom, that was why I didn't see them xD |
Helias
approved these changes
May 24, 2020
|
|
| default: | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
@Kitzunu I've updated this part to enable it also for CONDITION_REPUTATION_RANK since it's the same flag
There was a problem hiding this comment.
Yea I thought of doing that too :D
FrancescoBorzi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea if this will work because I cant figure out npm
Hope this is correct 🤷