Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deDE] Missing deDE localisations and wrong texts #3 with sources #14618

Open
IntelligentQuantum opened this issue Jan 11, 2023 · 0 comments
Open

[deDE] Missing deDE localisations and wrong texts #3 with sources #14618

IntelligentQuantum opened this issue Jan 11, 2023 · 0 comments
Labels
ChromieCraft Generic No specific levelrange Confirmed locale-deDE
Projects
ChromieCraft generic bugs

Comments

@IntelligentQuantum
Copy link
Member

chromiecraft/chromiecraft#4745

What client do you play on?

deDE

Faction

Both

Content Phase:

Generic

Current Behaviour

Check Extra Notes for additional information.

As of 03.01.2023:

deDE Quest texts in general:

deDE Quest progress, objectives and turn in texts:

  • 311 Return to Marleth/Rückkehr zu Marleth deDE progress text missing: "Habt Ihr den Austausch vollzogen?"
  • 417 A Pilot's Revenge/Pilotenrache missing deDE objectives and progress text: Objectives: "Tötet Marterklaue. Bringt Pilot Hammerfuß die räudige Klaue des Bären und Hangflugs Tagebuch." Progress text: "Hallo, < Name >. Wisst Ihr etwas über den Verbleib meines Freundes Hangflug?"
  • 5401/5405/5503 turn in text missing: "Alle, die für die Argentumdämmerung das Böse bekämpfen, müssen unsere Anstecknadel tragen. Wenn Ihr eine solche tragt, erhaltet Ihr das Recht, Belohnungen in Anspruch zu nehmen, die unsere Rüstmeister anzubieten haben.
    Während Ihr die Nadel tragt, könnt Ihr Euch Geißelsteine von erschlagenen Mitgliedern der Geißel holen; das sind Insignien, die sie manchmal besitzen. Beschafft Euch diese Insignien und bringt sie mir. Für alle, die Ihr abgebt, erhaltet Ihr unsere Marke des Heldentums - die Ehrenmarke der Argentumdämmerung.
    Erfüllt Euer Schicksal, < Klasse > ... stürzt Euch noch heute in den Kampf!"
  • 11451 Alicia's Poem/Alicias Gedicht progress and turn in text missing. Progress: "Oh, ein Gedicht?" Turn in: "Was für ein anrührendes Gedicht. Habt vielen Dank!".

Single words in deDE localisation that weren't translated: (most of the following texts are properly translated apart from one or two words, these are mostly location or NPC names that were translated during the vanilla phase to make the German translation more immersive. Is there a way to fix wrongly translated names in multiple instances?)

  • 82 Noxious Lair Investigation/Erkundung des Giftigen Unterschlupfes progress and turn in text read "Fizzledowser", should read "Rutenwünschels".
  • 417 A Pilot's Revenge/Pilotenrache turn in text reads "Hildelve", should read "Hangflug".
  • 1000/1004/1015/1018/1019/1047/6761 The New Frontier/Die neue Grenze turn in texts reads "Moonglade", should read "der Mondlichtung".
  • 2865 Scarab Shells/Skarabäuspanzerschalen progress text reads "Booty Bay", should read "Beutebucht".
  • 5241 Uncle Carlin/Onkel Carlin turn in text reads "Darrowshire", should read "Darroheim".
  • 6028 The Everlook Report (A)/Der Bericht der Ewigen Warte (A) progress text reads "Chillwind-Lager", should read "Zugwindlager". Turn in text reads "Steamwheedle-Kartell", should read "Dampfdruckkartell".
  • 6029 The Everlook Report (H)/Der Bericht der Ewigen Warte (H) turn in text reads "Steamwheedle-Kartell", should read "Dampfdruckkartell".

deDE Objects/Items:

deDE NPC gossip missing:

  • 234 Gryan Stoutmantle/Gryan Starkmantel missing deDE gossip: "In Westfall hat sich üble Verderbnis eingeschlichen. Während ich auf dem Schlachtfeld von Lordaeron meine Pflicht tat, wurden diese anständig geführten Höfe überfallen und zu Schlupfwinkeln für Schläger und Mörder umfunktioniert. Die Volksmiliz ist auf Eure Hilfe angewiesen."
  • 1646 Baros Alexston missing deDE gossip: "Seid gegrüßt, ich bin Baros Alexston, Stadtarchitekt von Sturmwind." (Already reported in first issue: [deDE] A few missing deDE localisations and wrong texts chromiecraft/chromiecraft#4536 but here now with source)
  • 7407 Chefingenieur Bilgenritzel: "Mein Name ist Bilgenritzel und ich bin der Chefingenieur der Gadgetzan Water Company. Wobei kann ich Euch helfen?"
  • 10926 Pamela Redpath/Pamela Rotpfad: after finishing quest 5142 and quest 5149 the NPC 10926 should have deDE gossip: "Mir wird nie mehr warm..."
  • 11039 Duke Nicholas Zverenhoff/Fürst Nicholas Zverenhoff missing deDE gossip: "Seid gegrüßt, < Name >. Ich bin Fürst Nicholas Zverenhoff von der Argentumdämmerung."
  • 19035 Wazat/Wazdaz gossip order is wrong, before taking first quest deDE gossip should read: "Es macht mich verrückt. Ich kann diese verdammten Eier nicht erreichen." After finishing first quest, deDE gossip should read: "Gut, Euch wiederzusehen, < Name >. Nur ein paar Feineinstellungen mehr, und die Richtung des Sprungs sollte perfekt sein!"

deDE NPC's gossip options:

  • 19409 Wing Commander Dabir'ee/Schwadronskommandant Dabir'ee missing deDE gossip option: "Schickt mich zum Trümmerposten."

deDE NPC say/yell/whisper:

  • 15263 Prophet Skeram/Der Prophet Skeram /yell deDE missing: 1."Der Prophet Skeram schreit: Ihr zögert das Unvermeidliche nur hinaus!" ("The Prophet Skeram yells: You only delay the inevitable!") 2."Der Prophet Skeram schreit: Seid Ihr so begierig darauf zu sterben? Ich werde Euch mit Freuden dabei behilflich sein..." ("The Prophet Skeram yells: Are you so eager to die? I will be happy to accommodate you...") 3."Der Prophet Skeram schreit: Euer Tod soll als Beispiel dienen!" ("The Prophet Skeram yells: Let your death serve as an example!")
  • 16976 Ghostly Denizen/Geisterhafter Bewohner and 16978 Lieutenant Commander Thalvos/Feldkommandant Thalvos 54, 83 /say and custom /e emotes don't have deDE localisation: 1."Feldkommandant Thalvos sagt: Alle beruhigen sich! Wir tun unser Bestes, um die Situation unter Kontrolle zu bekommen. Diese verdammten Orcs sind unerbittlich!" ("Lieutenant Commander Thalvos says: Everybody settle down! We're doing our best to get the situation under control. Them bleedin' orcs are unrelenting!"). 2."Geisterhafter Bewohner sagt: Der Friedhof auf dem Hügel füllt sich an manchen Tagen schneller, als wir Gräber graben können."("Ghostly Denizen says: The graveyard on the hill is filling up faster than we can dig the holes on some days.") 3. "Geisterhafter Bewohner sagt: Wir wollen Antworten, Kommandant! Wir haben das Recht, die Wahrheit zu erfahren!" ("Ghostly Denizen says: We want answers, Lieutenant! We're entitled to know the truth!") 4. "Geisterhafter Bewohner sagt: Werden wir jemals nach Hause zurückkehren können?" ("Ghostly Denizen says: Will we ever be able to go back home?") 5.(Emote) "Geisterhafter Bewohner ballt vor Wut die Fäuste." (Ghostly Denizen clenches his fists in anger). 6."Geisterhafter Bewohner sagt: Ich habe heute meinen Sohn beerdigt, Thalvos... Und letzte Woche meine Gemahlin." 7.(Emote)"Geisterhafter Bewohner schluchzt." ("Ghostly Denizen sobs."). 8."Geisterhafter Bewohner sagt: Es wird erzählt, dass es einen weiteren Angriff geben wird... Niemand soll am Leben gelassen werden."("Ghostly Denizen says: They say that there's gonna be another attack... None are to be left alive...") 9."Geisterhafter Bewohner sagt: Nerzhul wird niemals aufgeben. Wo sind unsere Helden?" (Ghostly Denizen says: Nerzhul will never give up. Where are our heroes?"). 10."Geisterhafter Bewohner sagt: Trollbann kann die vereinte Macht der orkischen Horde nicht allein zurückschlagen. Wir sind erledigt..." ("Ghostly Denizen says: Trollbane alone cannot fight back the combined might of the orcish Horde. We are done for...")

Expected Blizzlike Behaviour

Please check the respective IDs on wowhead (sometimes even wowhead's texts seem to have minor errors such as NPC/location names wrongly translated). If you have questions don't hesitate to ask me.

Source

Please check the respective IDs on wowhead (sometimes even wowhead's texts seem to have minor errors such as NPC/location names wrongly translated). If you have questions don't hesitate to ask me.

Steps to reproduce the problem

All of the quests/texts/gossip can easily be checked with a respective character and talking/interacting with the given NPC/quest ID.

Extra Notes

This is a collection of notes I made for myself to fix a few wrong deDE quest texts. Sadly I couldn't find the time yet to browse and edit the localised files myself as I am still learning to work with respective programs/files; so I decided to post it here if anybody is willing to fix them.

I started late with doing notes a lot of wrong texts that I noticed are not in here as there are way more deDE texts missing translation, have Catacylsm texts or have wrongly translated names in them. This is the third collective post I made, I will post another in the future once I find the time to sort everything since I still have a lot of other things noted.

Please see issue chromiecraft/chromiecraft#4697
and chromiecraft/chromiecraft#4536.

Let me know of duplicates, errors or corrections. If you want to help me fixing these issues myself please contact me here or on Discord, you can help me getting to know the right tools.

AC rev. hash/commit

chromiecraft/azerothcore-wotlk@c05c45c...3ad652d

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft
@IntelligentQuantum IntelligentQuantum added this to To do in ChromieCraft generic bugs via automation Jan 11, 2023
@ohkasdasf ohkasdasf mentioned this issue Jan 11, 2023
Merged
1 task
Gultask added a commit that referenced this issue Jan 24, 2023
@ohkasdasf @Gultask
fix(DB/Locale): deDE fix request items texts #3 (#14619)
da884fe 
Process of translation: only original sources of deDE texts by
researching multiple sources, reverse translation by searching for
related quest items/NPCs and using these names to reconstruct a proper
translation.

This fixes the terms

Scrimshank (Kieselschliff), Banehollow (Schattenfluch), Trollbane
(Trollbann), Stonesplitter (Splitterstein), Stonemaul (Steinbrecher),
Captain (Hauptmann), Kromcrush (Krombruch), Earthbinder (Erdbinder),
Razorfen (Klingenhauer), Razorflank (Klingenflanke), Stonard (Steinard)

for quest progress/request text entries for the deDE localisation with
proper casus/declension (these are not proper translated names of
locations/NPCs that have been left over by Blizzard since their language
localisations in TBC in 2006 and onward).

Fixed a self-made translation for quest 334.

Added missing deDE text entries for 4481, 4482, 4483, 5306, 5863, 7723,
9436.

<!-- First of all, THANK YOU for your contribution. -->

## Changes Proposed:
- Fixing missing or wrong entries in the quest_request_items_locale
table.

## Issues Addressed:
<!-- If your fix has a relating issue, link it below -->
Fixes some of the tasks listed in the issues below:
- #14244
- #14618
- From CC Github:
chromiecraft/chromiecraft#4697

## SOURCE:
<!-- If you can, include a source that can strengthen your claim -->
Read the text on top.

## Tests Performed:
<!-- Does it build without errors? Did you test in-game? What did you
test? On which OS did you test? Describe any other tests performed -->
- Not tested.


## How to Test the Changes:
<!-- Describe in a detailed step-by-step order how to test the changes
-->
All of the changes are to request texts of quests, can be tested by
accepting quests or simply reviewing the changed file.

## Known Issues and TODO List:
<!-- Is there anything else left to do after this PR? -->
- [ ] I still might want to check which of the tasks in above mentioned
issues are resolved by this.

<!-- If you intend to contribute repeatedly to our project, it is a good
idea to join our discord channel. We set ranks for our contributors and
give them access to special resources or knowledge:
https://discord.com/invite/DasJqPba)
Do not remove the instructions below about testing, they will help users
to test your PR -->
## How to Test AzerothCore PRs
 
When a PR is ready to be tested, it will be marked as **[WAITING TO BE
TESTED]**.

You can help by testing PRs and writing your feedback here on the PR's
page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

**REMEMBER**: when testing a PR that changes something **generic** (i.e.
a part of code that handles more than one specific thing), the tester
should not only check that the PR does its job (e.g. fixing spell XXX)
but **especially** check that the PR does not cause any regression (i.e.
introducing new bugs).

**For example**: if a PR fixes spell X by changing a part of code that
handles spells X, Y, and Z, we should not only test X, but **we should
test Y and Z as well**.

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
Tennesseej pushed a commit to Tennesseej/azerothcore-wotlk that referenced this issue Feb 27, 2023
@ohkasdasf @Gultask
fix(DB/Locale): deDE fix request items texts azerothcore#3 (azerothco…
1a656c3 
…re#14619)

Process of translation: only original sources of deDE texts by
researching multiple sources, reverse translation by searching for
related quest items/NPCs and using these names to reconstruct a proper
translation.

This fixes the terms

Scrimshank (Kieselschliff), Banehollow (Schattenfluch), Trollbane
(Trollbann), Stonesplitter (Splitterstein), Stonemaul (Steinbrecher),
Captain (Hauptmann), Kromcrush (Krombruch), Earthbinder (Erdbinder),
Razorfen (Klingenhauer), Razorflank (Klingenflanke), Stonard (Steinard)

for quest progress/request text entries for the deDE localisation with
proper casus/declension (these are not proper translated names of
locations/NPCs that have been left over by Blizzard since their language
localisations in TBC in 2006 and onward).

Fixed a self-made translation for quest 334.

Added missing deDE text entries for 4481, 4482, 4483, 5306, 5863, 7723,
9436.

<!-- First of all, THANK YOU for your contribution. -->

## Changes Proposed:
- Fixing missing or wrong entries in the quest_request_items_locale
table.

## Issues Addressed:
<!-- If your fix has a relating issue, link it below -->
Fixes some of the tasks listed in the issues below:
- azerothcore#14244
- azerothcore#14618
- From CC Github:
chromiecraft/chromiecraft#4697

## SOURCE:
<!-- If you can, include a source that can strengthen your claim -->
Read the text on top.

## Tests Performed:
<!-- Does it build without errors? Did you test in-game? What did you
test? On which OS did you test? Describe any other tests performed -->
- Not tested.


## How to Test the Changes:
<!-- Describe in a detailed step-by-step order how to test the changes
-->
All of the changes are to request texts of quests, can be tested by
accepting quests or simply reviewing the changed file.

## Known Issues and TODO List:
<!-- Is there anything else left to do after this PR? -->
- [ ] I still might want to check which of the tasks in above mentioned
issues are resolved by this.

<!-- If you intend to contribute repeatedly to our project, it is a good
idea to join our discord channel. We set ranks for our contributors and
give them access to special resources or knowledge:
https://discord.com/invite/DasJqPba)
Do not remove the instructions below about testing, they will help users
to test your PR -->
## How to Test AzerothCore PRs
 
When a PR is ready to be tested, it will be marked as **[WAITING TO BE
TESTED]**.

You can help by testing PRs and writing your feedback here on the PR's
page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

**REMEMBER**: when testing a PR that changes something **generic** (i.e.
a part of code that handles more than one specific thing), the tester
should not only check that the PR does its job (e.g. fixing spell XXX)
but **especially** check that the PR does not cause any regression (i.e.
introducing new bugs).

**For example**: if a PR fixes spell X by changing a part of code that
handles spells X, Y, and Z, we should not only test X, but **we should
test Y and Z as well**.

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ChromieCraft Generic No specific levelrange Confirmed locale-deDE
Projects
ChromieCraft generic bugs
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IntelligentQuantum