Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Spells/SpellInfoCorrections) PVP in area 52 #18847

Closed
wants to merge 47 commits into from

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    20989d3 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. fix(Core/Misc): Correct typo when loading reference loot templates (a…

    …zerothcore#18872)
    
    - Fix typo when loading reference loot templates
    - Closes azerothcore#18870
    
    Co-authored-by: Jason Mok <jasonmok@Jasons-MacBook-Air-4.local>
    jasonmokk and Jason Mok committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d34f64a View commit details
    Browse the repository at this point in the history
  2. fix(DB/Creature): Zul'Aman prisoner loot (azerothcore#18869)

    * Init.
    
    Co-Authored-By: AnonXS <19734826+anonxs@users.noreply.github.com>
    
    * Adjust variable spacing.
    
    ---------
    
    Co-authored-by: AnonXS <19734826+anonxs@users.noreply.github.com>
    heyitsbench and AnonXS committed May 9, 2024
    4 Configuration menu
    Copy the full SHA
    51202f8 View commit details
    Browse the repository at this point in the history
  3. chore(DB): import pending files

    Referenced commit(s): d34f64a
    github-actions[bot] committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8d685ac View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. fix(AQ40/SmartGameObjectAI): remove locked status from scarab coffer …

    …upon opening (azerothcore#18877)
    
    * remove locked status from scarab coffer upon opening
    
    * add Scarab Coffer
    sogladev committed May 11, 2024
    Configuration menu
    Copy the full SHA
    9c363bd View commit details
    Browse the repository at this point in the history
  2. chore(DB): import pending files

    Referenced commit(s): 9c363bd
    github-actions[bot] committed May 11, 2024
    Configuration menu
    Copy the full SHA
    0e7b1f3 View commit details
    Browse the repository at this point in the history
  3. 2 Configuration menu
    Copy the full SHA
    cd63cc0 View commit details
    Browse the repository at this point in the history
  4. fix(DB/spell_target_position): Mara Portal tp location (azerothcore#1…

    …8876)
    
    * fixMaraPortal
    
    * convert to update statement
    sogladev committed May 11, 2024
    Configuration menu
    Copy the full SHA
    c30cafe View commit details
    Browse the repository at this point in the history
  5. chore(DB): import pending files

    Referenced commit(s): c30cafe
    github-actions[bot] committed May 11, 2024
    Configuration menu
    Copy the full SHA
    016dcfa View commit details
    Browse the repository at this point in the history
  6. fix(db/sai) Some contents of the restoration of creature (27210 and 2…

    …7951) (azerothcore#18850)
    
    * Fix some problems
    
    * Change the name of the spell
    fangshun2004 committed May 11, 2024
    Configuration menu
    Copy the full SHA
    45ad5ac View commit details
    Browse the repository at this point in the history
  7. fix(Core/Unit): SPELLMOD_RESIST_MISS_CHANCE should decrease miss chan…

    …ce (azerothcore#18849)
    
    fix: hitchance should decrease misschance
    sogladev committed May 11, 2024
    Configuration menu
    Copy the full SHA
    ac203da View commit details
    Browse the repository at this point in the history
  8. chore(DB): import pending files

    Referenced commit(s): 45ad5ac
    github-actions[bot] committed May 11, 2024
    Configuration menu
    Copy the full SHA
    9af66df View commit details
    Browse the repository at this point in the history
  9. fix(Scripts/Naxxramas): Maexxna more blizzlike web wrap (azerothcore#…

    …18843)
    
    * WIP maexxna web wrap
    
    * add custom summon web wrap
    
    * progress
    
    * save
    
    * something that works
    
    * update sql
    
    * cleanup script
    
    * clean sql
    
    * remove orientation from position
    
    * fix: cast web wrap on multiple targets
    
    * fix: web wraps should not attack
    
    * adjust vertical speed to reduce speed if close, avoid ceiling yeet
    
    * rename candIt to itr
    
    * remove unused wraps2
    
    * style
    
    * use event instead of update(diff)
    
    * update spell_dbc sql
    
    * include player header to fix error: invalid use of incomplete type
    
    * include SpellAuraEffects header
    
    * fix Effects start at 1 in DBC
    
    * fix web wraps attacking
    
    * calc distance with hypotf, define vspeed ranges, remove trig webwrap enum
    
    * fixup! calc distance with hypotf, define vspeed ranges, remove trig webwrap enum
    
    * fix: call target selection with pos 0, use IsPlayer()
    
    * add validate
    
    * fixup! fix: call target selection with pos 0, use IsPlayer()
    
    * remove not needed header
    
    * remove empty lines
    
    * use registry macro
    
    * Revert "remove not needed header"
    
    This reverts commit 254717d.
    sogladev committed May 11, 2024
    Configuration menu
    Copy the full SHA
    2c77139 View commit details
    Browse the repository at this point in the history
  10. chore(DB): import pending files

    Referenced commit(s): 9af66df
    github-actions[bot] committed May 11, 2024
    Configuration menu
    Copy the full SHA
    6edf515 View commit details
    Browse the repository at this point in the history
  11. fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaum…

    …eux (azerothcore#18807)
    
    * fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaumeux
    
    * remove blank line
    
    * remove four_horsement_consumption SpellScript
    
    * update comment
    sogladev committed May 11, 2024
    Configuration menu
    Copy the full SHA
    d44c899 View commit details
    Browse the repository at this point in the history
  12. chore(DB): import pending files

    Referenced commit(s): 2c77139
    github-actions[bot] committed May 11, 2024
    Configuration menu
    Copy the full SHA
    864ea7f View commit details
    Browse the repository at this point in the history
  13. fix(Scripts/TheEye): correct first phoenix in p5 (azerothcore#18802)

    correct first phoenix in p5
    
    should spawn 15 seconds before 2nd gravity lapse
    balleny committed May 11, 2024
    Configuration menu
    Copy the full SHA
    31096df View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. fix(DB/Creature): Correct spells order for Broken-down Shredder (issu…

    …e 18729) (azerothcore#18866)
    
    * fix(DB/Creature):  Correct spells order has been restored for Broken-down Shredder
    
    * Update fix_issue18729.sql
    
    ---------
    
    Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
    xubpwg and elthehablo committed May 12, 2024
    Configuration menu
    Copy the full SHA
    6b5ad72 View commit details
    Browse the repository at this point in the history
  2. fix(DB/asi)Added some small events to the creature "Shen'dralar Ancie…

    …nt (14364)".... (azerothcore#18880)
    
    * Increases the number of players who look at the last completed character every 15 seconds.
    
    * fix error
    
    * fix error
    
    * fix error
    
    * Update rev_1715337495584103500.sql
    
    fix error
    
    * update spawn masks
    
    ---------
    
    Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
    fangshun2004 and elthehablo committed May 12, 2024
    Configuration menu
    Copy the full SHA
    daf7842 View commit details
    Browse the repository at this point in the history
  3. chore(DB): import pending files

    Referenced commit(s): 6b5ad72
    github-actions[bot] committed May 12, 2024
    Configuration menu
    Copy the full SHA
    bf930bb View commit details
    Browse the repository at this point in the history
  4. fix(Scripts/Zones/Creature): Infra-Green Bomber (azerothcore#18752)

    * Updating Creature.
    
    * Delete data/sql/updates/pending_db_world/rev_1713104748708628400.sql
    
    * Updating Bomber
    Knindzagxg committed May 12, 2024
    Configuration menu
    Copy the full SHA
    dd3f4a5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c95594e View commit details
    Browse the repository at this point in the history
  6. fix(Core/Events) Implement Fireworks Spectacular (azerothcore#18860)

    * init sql file for fireworks spectacular - add entry in game_event
    
    * add missing delete statement
    
    * add gameobjects 180698 'Party Table, 180699 'Festive Keg, 180700 'Hay Bale 1'
    
    * update comment, add gameobject 180754 Toasting Goblet
    
    - todo: pooling (?) - the tables are quite full
    - todo: why are there tables missing? e.g. below:
    .go ga 82615
    
    * add gameobject 180905 'Festive Mug'
    
    * add gameobjects 'Firework, Show, Type%'
    
    * add vendors
    
    * add revelers and bruisers
    
    TODO: also add 15906 'Ironforge Reveler'
    
    * remove '%Firework Show%' spawns
    
    - these will be spawned temporarily via script
    
    * add firework gameobject SmartAI
    
    * WIP stormwind fireworks show
    
    steps to test the show:
    .go xyz -8984 498 96 0
    .gob add temp 180749
    
    * improve handling of fireworks show, add gameobject 180749 'Cheer Speaker' spawns
    
    how to test:
    .go ga 64640
    .event start 72
    
    * prepare fetching correct show based on map+zone
    
    * introduce typedef for FireworkShow
    
    * Add Teldrassil show
    
    .go ga 64651
    .event start 72
    
    * fix Teldrassil and Stormwind shows, add initShow() debug message, replace magic numbers for fireworkShow sizes
    
    - these were broken due to an error in my txt parsing script
    
    * add Shattrath show
    
    .go c 139914
    .event start 72
    
    * add Silvermoon show
    
    .go ga 64670
    .event start 72
    
    * add Booty Bay show
    
    .go ga 64630
    .event start 72
    
    * add Thunder Bluff show, add Exodar show, set firework gameobjects active, update comments, remove _maxCount
    
    * add Underciy show
    
    .go ga 64641
    .event start 72
    
    * fix Undercity show indexes
    
    * move code from midsummer.cpp to new file firework_show.cpp
    
    * add Orgrimmar show
    
    .go ga 64647
    .event start 72
    
    * add Ironforge show
    
    .go ga 64634
    .event start 72
    
    * update shows from sniff parses using fixed export script
    
    * update 'Party Table, 'Festive Keg' and 'Hay Bale 1' spawns with additional sniffs
    
    * update 'Toasting Goblet' spawns with additional sniffs
    
    * update 'Festive Mug' spawns with additional sniffs
    
    * update 'Fireworks Revelers' spawns with additional sniffs
    
    * remove duplicate AND from sql file
    
    * attempt moving FireworkShows to the heap
    
    * start firework show at the full hour and also handle late starts correctly
    
    - also perform a minor cleanup
    
    * do not touch gameobject with guid 16586 which is linked to harvest festival
    
    * move firework_show.cpp to subfolder firework_show
    
    * move firework_show arrays to seperate header files
    
    * update show handling, still not final
    
    * update for new struct design, Teldrassil show running correctly already
    
    * update remaining shows for new firework show structs
    
    * rename go_cheer_speaker to go_firework_show
    
    * update debug / error messages
    
    * update all firework shows for local spawnIndex handling
    
    * spawn 'Toasting Goblet's for 10min after show ende
    
    * add reveler SAI and make revelers cheer on show end
    
    * remove log_error messages
    
    * add comment for festive mugs
    
    * Update firework_show.cpp
    
    * add missing include for uint32
    
    * replace an uint32 with an int
    
    * revert unintended changes in midsummer.cpp
    
    * add #include "GameObjectScript.h"
    
    * remove ThunderBluff Reveler spawns with wandering movement
    
    - these probably should have waypoints instead or just got parsed incorrectly
    - it should be safe to remove these for now and probably investigage this further later on
    
    * update function names
    sudlud committed May 12, 2024
    Configuration menu
    Copy the full SHA
    0f82c8e View commit details
    Browse the repository at this point in the history
  7. chore(DB): import pending files

    Referenced commit(s): 0f82c8e
    github-actions[bot] committed May 12, 2024
    Configuration menu
    Copy the full SHA
    8552d4f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    85e9671 View commit details
    Browse the repository at this point in the history
  9. fix(Karazhan/Nightbane): no longer killable during flight (azerothcor…

    …e#18890)
    
    add unkillable during flight phase
    
    _flying: takeoff/landing, moving to location
    Phase 2: in the air and casting air spells
    sogladev committed May 12, 2024
    Configuration menu
    Copy the full SHA
    d709080 View commit details
    Browse the repository at this point in the history
  10. fix(DB/Hyjal): Archimonde aggro range (azerothcore#18884)

    * init
    
    * Update archimondo.sql
    elthehablo committed May 12, 2024
    Configuration menu
    Copy the full SHA
    5668e47 View commit details
    Browse the repository at this point in the history
  11. chore(DB): import pending files

    Referenced commit(s): 5668e47
    github-actions[bot] committed May 12, 2024
    Configuration menu
    Copy the full SHA
    e4b4686 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. fix(Karazhan/Nightbane): Rain of Bones cast on one random player/pet,…

    … summon Skeletons at that location (azerothcore#18892)
    
    * replace skeletonspawn scheduler with spellscript
    
    * Revert "replace skeletonspawn scheduler with spellscript"
    
    This reverts commit 974bcb8.
    
    * random target and remember position
    
    * target position instead of player
    
    * make pets valid targets for rain of bones
    
    * change 100 to 100.0f
    sogladev committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b42ca49 View commit details
    Browse the repository at this point in the history
  2. fix(DB/gameobject):Remove the Church of the Holy Light with flowers a…

    …nd small mounds (azerothcore#18879)
    
    * Delete Flower and Small Dirt Mound
    Added flower and small mounds to the event
    
    * fix error
    
    * Update data/sql/updates/pending_db_world/rev_1715349752817459800.sql
    
    Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
    
    * Update data/sql/updates/pending_db_world/rev_1715349752817459800.sql
    
    Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
    
    * Update rev_1715349752817459800.sql
    
    ---------
    
    Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
    fangshun2004 and elthehablo committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3a4d321 View commit details
    Browse the repository at this point in the history
  3. chore(DB): import pending files

    Referenced commit(s): 3a4d321
    github-actions[bot] committed May 13, 2024
    Configuration menu
    Copy the full SHA
    15e46de View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    7889a99 View commit details
    Browse the repository at this point in the history
  2. chore(DB): import pending files

    Referenced commit(s): 7889a99
    github-actions[bot] committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8ad1744 View commit details
    Browse the repository at this point in the history
  3. fix(DB/Loot): Near complete loot rework of Vanilla overworld zones (a…

    …zerothcore#18796)
    
    * Create rev_1713905765626834000.sql
    
    * unique loot
    
    * remove garbage
    
    * Update rev_1713905765626834000.sql
    Gultask committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6594255 View commit details
    Browse the repository at this point in the history
  4. chore(DB): import pending files

    Referenced commit(s): 6594255
    github-actions[bot] committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e06f2b2 View commit details
    Browse the repository at this point in the history
  5. fix(DB/Gameobject): Rebuild all Eastern Kingdoms gathering nodes usin…

    …g sniffed data (azerothcore#18898)
    
    * Create rev_1715713909070959500.sql
    
    * extra leftovers
    Gultask committed May 14, 2024
    Configuration menu
    Copy the full SHA
    fd7c8a0 View commit details
    Browse the repository at this point in the history
  6. chore(DB): import pending files

    Referenced commit(s): fd7c8a0
    github-actions[bot] committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ef6db03 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. fix(Core/BattlegroundAV): spawn generic gameobjects in Alterac Valley (

    …azerothcore#18764)
    
    * fix(Scripts/PVP): correctly spawn generic gameobjects in Alterac Valley
    
    I've been "collecting" these in the DB for a while, now it's time to move
    these spawns to the AV script and actually spawn them.
    
    * add 2 additional generic gameobjects
    sudlud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e2029c3 View commit details
    Browse the repository at this point in the history
  2. chore(DB): import pending files

    Referenced commit(s): e2029c3
    github-actions[bot] committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6874d5e View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    3b4639a View commit details
    Browse the repository at this point in the history
  2. fix(CI): revert ubuntu-22.04 to gcc12 (azerothcore#18905)

    * fix(CI/PCH): revert ubuntu-22.04 to gcc12, add ubuntu-24.04 with gcc14
    
    * also update nopch workflow
    
    * Update core-build-nopch.yml
    
    * Update core-build-pch.yml
    sudlud committed May 17, 2024
    Configuration menu
    Copy the full SHA
    dfc9abb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b23439 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Configuration menu
    Copy the full SHA
    4ae69cf View commit details
    Browse the repository at this point in the history
  2. chore(DB): import pending files

    Referenced commit(s): 4ae69cf
    github-actions[bot] committed May 18, 2024
    Configuration menu
    Copy the full SHA
    6d6c7be View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3988e95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8bfb897 View commit details
    Browse the repository at this point in the history
  5. add faction 1812 K3 Bruiser

    Co-authored-by: Jelle Meeus <sogladev@gmail.com>
    pangolp and sogladev committed May 18, 2024
    Configuration menu
    Copy the full SHA
    b1b511d View commit details
    Browse the repository at this point in the history