Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the patch #11

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Fix the patch #11

merged 2 commits into from
Feb 5, 2020

Conversation

BarbzYHOOL
Copy link
Member

I didn't compile with this yet, but git apply worked fine

Closes #8

@dd667
Copy link

dd667 commented Feb 1, 2020

Hi,
Compiled "AzerothCore rev. 4da4ad4e0d6e+ 2020-01-31 08:05:31 +0000 (master branch) (Win64, Release) (worldserver-daemon)" with patch applied. Compiles fine but the ahbot does not add any items to the auction house. The only thing I get in the logs is:

"2020-02-01 11:23:38 AHSeller: Adding 2000 Auctions
2020-02-01 11:23:38 ERROR: AHSeller: Current Auctineer GUID is 79707
2020-02-01 11:23:38 ERROR: AHSeller: 2000 items
2020-02-01 11:23:38 ERROR: AHSeller: 1 count
2020-02-01 11:23:38 ERROR: AHSeller: 2 count
2020-02-01 11:23:38 ERROR: AHSeller: 3 count..."
``` and so on.

Hope you can make sense out of it.

@BarbzYHOOL
Copy link
Member Author

I haven't tested the module yet, but I will

Also I feel like these are not errors but just warnings wrongly labelled

@BRNKR
Copy link

BRNKR commented Feb 3, 2020

i havent used your patch and created a few days earlier a new patch and i have the same problem like @dd667 that the ahbot is not selling anything

@BarbzYHOOL
Copy link
Member Author

Yeah nothing works, or i don't know how to test it but i can still merge this at least

@BarbzYHOOL BarbzYHOOL merged commit 3efff73 into master Feb 5, 2020
@BRNKR
Copy link

BRNKR commented Feb 5, 2020

it doesnt work but you merge? :D is that the way to go?

@BarbzYHOOL BarbzYHOOL mentioned this pull request Feb 5, 2020
@BarbzYHOOL
Copy link
Member Author

feel free to revert to before this PR then, it will solve all your problems and don't talk to me if it doesn't

@BarbzYHOOL BarbzYHOOL deleted the BarbzYHOOL-fix_patch branch February 5, 2020 20:50
@BRNKR
Copy link

BRNKR commented Feb 5, 2020

the patch itself works. but the rest of the mod doesnt.

@BarbzYHOOL
Copy link
Member Author

Seems like you made a mistake in your patch too TobiMiller, like me

Fixed on latest commit on master now.

@azerothcore azerothcore locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core path
3 participants