-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SummonProperties and Spell Effects/Aura Reference #886
Add SummonProperties and Spell Effects/Aura Reference #886
Conversation
Can't look right now, but there is also this reference list of spell effects and their parameters. I'd recommend taking a look and making sure nothing is missing from your list that is mentioned there. |
I'd also throw a link to the spell effect reference list in the actual spell DBC page. |
I like, will collect all of the known data. |
Might also want to place a link to it in the documentation index page. I'm personally fine with it being in the sidebar, but I also feel there should be another spot where it can be accessed. |
"Both. Both is good." |
Ping me when done. I want to go through this |
@@ -68,6 +68,7 @@ | |||
<li><a href="/wiki/remote-access">Remote Access</a></li> | |||
<li><a href="/wiki/waypoints-information">Information about waypoints</a></li> | |||
<li><a href="/wiki/how-to-obtain-free-records">How to obtain free records</a></li> | |||
<li><a href="/wiki/spell-effects-reference">Spell Effects Reference</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial but my opinion is of limiting the use of the sidebar and depending more on the documentation index page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally didn't even know the documentation page existed so I'd rather leave it in both places, can always be removed.
@@ -14,5 +14,6 @@ | |||
* [Map](map.md) | |||
* [PageTextMaterial](pagetextmaterial.md) | |||
* [SkillLine](skillline.md) | |||
* [SummonProperties](summonproperties_dbc.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong. In this case you should have 2 pages.
- for the DB Structure as DB not always have all the fields that the DBC has
- for the DBC structure and possible constant values within it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but in this case DB matches the dbc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine
Thank you very much for wrangling all this info up. ❤️ |
Source
Related Issue
Thank you for contributing to the AzerothCore wiki.
Remember that the wiki is currently available in English and Spanish.