Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SummonProperties and Spell Effects/Aura Reference #886

Merged
merged 9 commits into from
Apr 1, 2023
Merged

Add SummonProperties and Spell Effects/Aura Reference #886

merged 9 commits into from
Apr 1, 2023

Conversation

avarishd
Copy link
Contributor

@avarishd avarishd commented Mar 27, 2023

Source

Related Issue

Thank you for contributing to the AzerothCore wiki.

Remember that the wiki is currently available in English and Spanish.

@heyitsbench
Copy link
Contributor

Can't look right now, but there is also this reference list of spell effects and their parameters. I'd recommend taking a look and making sure nothing is missing from your list that is mentioned there.

@heyitsbench
Copy link
Contributor

I'd also throw a link to the spell effect reference list in the actual spell DBC page.

@avarishd
Copy link
Contributor Author

I like, will collect all of the known data.

@heyitsbench
Copy link
Contributor

Might also want to place a link to it in the documentation index page. I'm personally fine with it being in the sidebar, but I also feel there should be another spot where it can be accessed.

@avarishd
Copy link
Contributor Author

"Both. Both is good."

@avarishd avarishd marked this pull request as draft March 27, 2023 18:51
@Kitzunu
Copy link
Member

Kitzunu commented Mar 28, 2023

Ping me when done. I want to go through this

@avarishd
Copy link
Contributor Author

@Kitzunu

@avarishd avarishd marked this pull request as ready for review March 31, 2023 06:00
@avarishd avarishd changed the title Add SummonProperties and Spell Effects Reference Add SummonProperties and Spell Effects/Aura Reference Mar 31, 2023
@Helias Helias requested a review from Kitzunu March 31, 2023 08:57
@@ -68,6 +68,7 @@
<li><a href="/wiki/remote-access">Remote Access</a></li>
<li><a href="/wiki/waypoints-information">Information about waypoints</a></li>
<li><a href="/wiki/how-to-obtain-free-records">How to obtain free records</a></li>
<li><a href="/wiki/spell-effects-reference">Spell Effects Reference</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial but my opinion is of limiting the use of the sidebar and depending more on the documentation index page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally didn't even know the documentation page existed so I'd rather leave it in both places, can always be removed.

@@ -14,5 +14,6 @@
* [Map](map.md)
* [PageTextMaterial](pagetextmaterial.md)
* [SkillLine](skillline.md)
* [SummonProperties](summonproperties_dbc.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong. In this case you should have 2 pages.

  1. for the DB Structure as DB not always have all the fields that the DBC has
  2. for the DBC structure and possible constant values within it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but in this case DB matches the dbc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

docs/spell-aura-reference.md Outdated Show resolved Hide resolved
docs/spell-aura-reference.md Show resolved Hide resolved
docs/spell-effects-reference.md Outdated Show resolved Hide resolved
docs/spell-effects-reference.md Outdated Show resolved Hide resolved
docs/spell-aura-reference.md Outdated Show resolved Hide resolved
docs/summonproperties_dbc.md Outdated Show resolved Hide resolved
@avarishd avarishd requested a review from Kitzunu April 1, 2023 17:33
@Kitzunu Kitzunu merged commit 7a21507 into azerothcore:master Apr 1, 2023
@heyitsbench
Copy link
Contributor

Thank you very much for wrangling all this info up. ❤️

@avarishd avarishd deleted the Spell-Effects-Reference&SummonProperties branch April 1, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants