Skip to content

feat(coverage): add coverage for text #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 5, 2016
Merged

feat(coverage): add coverage for text #91

merged 7 commits into from
Jan 5, 2016

Conversation

azu
Copy link
Owner

@azu azu commented Jan 5, 2016

文章に対するコードカバレッジを追加

を利用してる。

厳しめ(必ずしもLintが通るわけではない)ルールを用意して、そちらでチェックした結果をコードカバレッジとして表現している。

  • coverage.textlintrc がコードカバレッジ用の設定ファイル
    • strictオプションの有効化
    • textlint-rule-preset-JTF-styleでデフォルト無効のオプションも有効化
    • ルールの値を厳しめに設定

カバレッジの読み方

100%が理想的目標

codecov.io
codecov.io

それに対する現実の値が%として表現されている。

Current coverage is 96.85%

なら問題なさそう。70%とか切るとちょっとという感じ(逆に通常のnpm run textlintが通ってるのに、カバレッジがすごく落ちてるなら厳しめのルールとの間に剥離があるかもしれない)

@codecov-io
Copy link

Current coverage is 96.87%

Merging #91 into master will increase coverage by +46.87% as of e2db561

@@            master     #91   diff @@
======================================
  Files            1       6      +5
  Stmts            4    1025   +1021
  Branches         1       0      -1
  Methods          0       0        
======================================
+ Hit              2     993    +991
+ Partial          1       0      -1
- Missed           1      32     +31

Review entire Coverage Diff as of e2db561

Powered by Codecov. Updated on successful CI builds.

@azu azu changed the title feat(coverage): add coverage using txtlint for text feat(coverage): add coverage for text Jan 5, 2016
azu added a commit that referenced this pull request Jan 5, 2016
feat(coverage): add coverage for text
@azu azu merged commit c5035e3 into master Jan 5, 2016
@azu azu deleted the coverage branch January 5, 2016 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants