Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: choose bun if both bun.lockb and yarn.lock exist #15

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

mono0x
Copy link
Contributor

@mono0x mono0x commented Nov 28, 2023

Since bun's lockfile is binary, some users set print="yarn" to output a yarn.lock file. Therefore, there are cases where both bun.lockb and yarn.lock exist. Currently, ni chooses yarn in this situation. However, in this case, I would prefer that bun be chosen.

In this PR, even if yarn.lock exists, bun will be chosen by checking for bun.lockb first.

https://bun.sh/docs/install/lockfile

@azu azu added Type: Bug Bug or Bug fixes Package: bun labels Nov 28, 2023
@azu
Copy link
Owner

azu commented Nov 28, 2023

Intestring. Thanks

@azu azu merged commit 7fabdfd into azu:main Nov 28, 2023
4 checks passed
@mono0x mono0x deleted the prioritize-bun branch November 29, 2023 03:26
@mono0x
Copy link
Contributor Author

mono0x commented Nov 29, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants