[OKTA-251323] y u do dis #4
Merged
+43
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecembke-okta
commented
Oct 1, 2019
| let mut ch = b'\\'; | ||
|
|
||
| // TODO: Use fastwrite here as well | ||
| self.buffer.extend_from_slice(self.source[start .. self.index - 1].as_bytes()); | ||
| self.buffer.extend_from_slice(&self.source.as_bytes()[start .. self.index - 1]); |
There was a problem hiding this comment.
this isn't related to the fix for this issue, but it's bad form and could cause a panic
alecembke-okta
commented
Oct 1, 2019
| @@ -554,7 +556,7 @@ impl<'a> Parser<'a> { | |||
| // issues here, we construct a new slice from raw parts, which | |||
| // then has lifetime bound to the outer function scope instead | |||
| // of the parser itself. | |||
| slice::from_raw_parts(self.buffer.as_ptr(), self.buffer.len()) | |||
| slice::from_raw_parts(self.buffer[len..].as_ptr(), self.buffer.len() - len) | |||
There was a problem hiding this comment.
fun fact, i forgot to add the - len here at the end at first and the next 3 bytes in memory on my machine were red, and it didn't segfault.
colingabrielson-okta
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.