Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add ability to configure valid git commit types #57

Open
Recidvst opened this issue Feb 22, 2021 · 2 comments
Open

[FEAT] Add ability to configure valid git commit types #57

Recidvst opened this issue Feb 22, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Recidvst
Copy link

Is your feature request related to a problem? Please describe.
Would it be possible to add an option to provide a config file to set the list of possible valid git commit types? We use a superset of the standard 'Conventional Commits' rules and our extra items throw errors when using tug commit.

Describe the solution you'd like
It would be awesome to be able to read from a config file at a repository level as per Commitlint's approach (example config file). Could commit.go potentially check for a local config file before building up the list of types, and then fall back to the hardcoded list if one isn't available?

I don't know Go at all so apologies if this more difficult than it seems :) Turbogit is awesome btw, thanks! 💯

@Recidvst Recidvst added the enhancement New feature or request label Feb 22, 2021
@Recidvst Recidvst changed the title [FEAT] [FEAT] Add ability to configure valid git commit types Feb 22, 2021
@b4nst
Copy link
Owner

b4nst commented Feb 22, 2021

Hey, thanks for creating the issue. It's not simple in the sense that a lot needs to be refactored in order to be dynamic (mostly this file).
But it's definitely useful. Keeping this in the backlog for a future release.
FYI turbogit is using the same config model (and files) as bare git. The config read is already implemented (and used for example in the new jira integration wip), we just need to make commit type dynamic.

@Recidvst
Copy link
Author

Thanks @b4nst, I'll keep an eye out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants