Date and Number Fields Should Be Text Fields #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failure to treat them uniformly: 1. Created a lot of unneeded duplication as much of the code was simply delegating. 2. Made working with the specialized variants difficult. For example, DNU `#identifier` when used in an expression like: `response onReturn setValueTo: aDate mmddyyyy thenTriggerChangeOf: self myDateField`
Mozilla recommends avoiding Date Input Types ATM due to spotty browser support (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date#Handling_browser_support)
|
@seandenigris take a look at #129 , I've changed a bit the code because in this branch you can for example instantiate a DateField with the multiline methods and that make no sense... So let me know if this covers your use case or we need to changes something elese. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure to treat them uniformly:
#identifierwhen used in an expression like:response onReturn setValueTo: aDate mmddyyyy thenTriggerChangeOf: self myDateField