This repository has been archived by the owner on May 11, 2018. It is now read-only.
Backport support for target versions as strings #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=========================================
+ Coverage 93.2% 93.7% +0.49%
=========================================
Files 4 6 +2
Lines 206 254 +48
Branches 60 69 +9
=========================================
+ Hits 192 238 +46
- Misses 9 11 +2
Partials 5 5
Continue to review full report at Codecov.
|
existentialism
force-pushed
the
backport-string-versions
branch
from
efd24fb
to
55a591a
Compare
yavorsky
reviewed
May 15, 2017
| if (plugin.chrome >= 28) { | ||
| plugin.opera = plugin.chrome - 13; | ||
| plugin.opera = (plugin.chrome - 13).toString(); |
| { | ||
| "android": 4 | ||
| } | ||
| {} |
There was a problem hiding this comment.
good catch, merge fail, fixed!
yavorsky
approved these changes
May 15, 2017
existentialism
force-pushed
the
backport-string-versions
branch
from
b51d541
to
8fb2222
Compare
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328. Fixes #322.