Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix exports of babel-core #3641
+193
−0
Conversation
and others
jamiebuilds
added some commits
Aug 5, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
loganfsmyth
Aug 5, 2016
Member
Needs more bytes, sorry. Can we add a linting rule for minimum file size?
|
Needs more bytes, sorry. Can we add a linting rule for minimum file size? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Needs some unit tests so we don't regress |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
samlecuyer
commented
Aug 5, 2016
|
I hate to be that guy, but |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
codecov-io
Aug 5, 2016
Current coverage is 88.13% (diff: 100%)
@@ master #3641 diff @@
==========================================
Files 188 188
Lines 10924 10925 +1
Methods 1162 1162
Messages 0 0
Branches 2492 2492
==========================================
+ Hits 9628 9629 +1
Misses 1296 1296
Partials 0 0 Powered by Codecov. Last update 154922c...f36d07d
codecov-io
commented
Aug 5, 2016
•
edited
Edited 1 time
-
codecov-io
edited Aug 9, 2016 (most recent)
edited
Edited 1 time
-
Aug 9, 2016 (most recent)
Current coverage is 88.13% (diff: 100%)@@ master #3641 diff @@
==========================================
Files 188 188
Lines 10924 10925 +1
Methods 1162 1162
Messages 0 0
Branches 2492 2492
==========================================
+ Hits 9628 9629 +1
Misses 1296 1296
Partials 0 0
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
mpj
Aug 6, 2016
Can you please extract this into a separate npm package? It seems like it could have general use.
mpj
commented
Aug 6, 2016
|
Can you please extract this into a separate npm package? It seems like it could have general use. |
hzoo
added
the
PR: Bug Fix 🐛
label
Aug 6, 2016
hzoo
added this to the Next Patch milestone
Aug 6, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
lol |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
d3viant0ne
Aug 6, 2016
Member
I agree with @mpj - This should really be extracted into it a plugin for Historical comedic value
This may turn out to be the greatest medium post of all time :)
I wonder if the Express/Loopback group is going to have the same sense of humor ...
|
I agree with @mpj - This should really be extracted into it a plugin for This may turn out to be the greatest medium post of all time :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Can you please use a gender neutral export name? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
raabbajam
Aug 7, 2016
Can you please use a gender neutral export name?
Umm, did you just assume it's gender? Lol, jk. Guy is his name, though. Guy Fieri.
Also, yes please fix it as array.
This one is better:
import {guy} from 'babel-core';
const [GuyFieri] = guy;
raabbajam
commented
Aug 7, 2016
Umm, did you just assume it's gender? Lol, jk. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
His name is offending my taste buds |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
andreasklinger
commented
Aug 7, 2016
|
"Hate to be that guy"… but specs are missing |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Please remove that guy :( |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Daniel15
Aug 8, 2016
Member
This patch is insufficient. Here's the proper fix:
export const guy = [
'
` `
` ` `
``.``` . `` ` `. `
``````` ` ` ` ` . . ``
```. `.```. ... ``..```` `
` ` `` .`.`` ..`.``....`.`.`....` .
` ..` `. ..``.`....``....```.....``` `
` `. ``.``.`.````.`.```...`.....``...````
` . ...`,..`..```...``.````. `.```.`` .`
.` .````....`.````````````````````.````` ``
. .` ``.`.`.``````````````````.`````````` ` `
`.`` .```..`.````````````````````````````` `````
`.` ...```.`````````````````````````````.``.`...
` ``..``````````````````````````````````````.`.``.` `
``````.`````````````````````````````````` ``..``` `.
``..``````````````` .````````````````````.`..``` . `
.` `` .`.``.```.``````````.```````````````````.``...`. `
.``` .`.```````````````````````````````````````````.`. ``
` ```` ....````````````..````` ```````````````````````.`. `
` ````..``````` ```````.`````` ````````` `````````..`..`.
. ` `. ``.```````````````````` ```.````` `````.```.``..`. .
` ``` `````` ``````````.``````````.````````.``.```.``..`.```
`` ``. ````````` ``````````````..`````````.```. `````.`..``
`````.` ` ``````````.` ` ````````````````.` `.``.`````````. `.
` `.` `````` ````.```````````````.`.```````````````````.``.`
``` `.````````` ``` ``````````````````````````````````````...``
``` `.`````` `````````.``````.````.``````````````````````.``.
`.` `.` ````````````.````````.`````````````````````` ````````.`
` ` ``` ``` ``` `.``````````.```.`..``..``.`````` `````.`..
``````. `````` `` ``````.``.``.`````..``````.````.`` ``````... `
```````..```````` ````.`.```````````..````````.```````````..``
`.````` ` ````` ` `````.``.``````....``````.`.`..````````.```..
`````.```` ``` `` ````````.````.``..`.` ````.`.``.`````````.``
` `` `.`.`` ` ` ` ```.`````````````.``.``.`.`...``....``````.` `
``..```````` ` `. ``````...`````````````.`.`.`.....,,....````..`
`.`,``````.``` `` ` .```..`````````.```````..,,...,,,,...```````
`.`.`` ``````` ``````.`````````````````..`........,,,,...`````.````
`.``.```````` ` ``.`..``.`....````````............,,,,,,..`````.
` ...`````````` `````.`.......`````````..`..`.......,,,,,,.`..`.`. `
``..`````````````.`..........`````````````........,.,,,,,........`
``````````````````.............````````````........,,,,,,.`.......
.````. ``` `` `.....``.......`.````````````........,,,,,,,.....`.`
`` `` ```` `````.............``````````````.......,,,,,,:,.......``
``.`` ``` ````................``````````.......,,,,,:,,,...`...`
` .````` ``.````................`````````........,,.,,:,::,......`
``````````` `````.................```````.........,,,,,:,,:..`..,.`
```.``````` ```....................```..........,,,,,,,,::,.`.....`
. `.``````..````.......,............``.........,,,,,,,,,,:,...,...
`. ``````.`.````.,.............................,,,,,,,:,:,....,..`
`. `````..`.````.,...,........................,,,,,,,,,,::,...,..
``.``````....```..,,.,,,,......................,,,,,,,,,:::,,.,,.`
`````````.``.```...,.,,,,,....................,,,,,,,,,,,::,,,.,,`
`.``.`.``..``.....,.,..,,,....................,,,,,,,,,,:::,.,.,,
.```.`..``.```.``.,.,,.,,,,,..................,,,,,,,,,,:::,,.,,`
` .```.........``..,,,,,,,.....................,,,,,,,,,,:::,,..,`
`` `.````,`,`.```..,,,..,,,.......................,,,,,,,,:::,..,
`````````.`..``...,,,.,,,........................,.,,,,,,:::;,.,.
.`....````,..`.`.,,,,,,,,,........................,,,,,,::::',.,.
```.... ``.`..`.`,,,,,,,,.,.......................,,,,,,::::;:,,.
```.,..` ```.. `..,,,,,,,,.,......................,,,,,,,:::;;,:;.
``...,,,..``.`.`..,,,,,,,,.......................,,,,,,,:::::;,.;`
````,,.,,..`.`...,,,,,,,,..........`..........,,,,,,,,,,::::;,.:`
`.``...`..```.`.,,,,,,,,....................,,,,,,,,,::::::;:,;.
`.``.`.,``...`.,,,,,,,,,...................,,,,,,::;;;';;::::,;,
......`````...,:,,,,,,,,,..............,,,,,,:::'''''''''::::,:,
`.....,.......,,,,,,,,,.,,......,,...,,,,,,::;;'++++++''';:::,,,
`..````.......,:,,,,,,,,..,..,...,,,,,,,,,,,:;'++##++''';;;:::,,.
..``..`..,,:,,,,,,,,,,...,,,..,,:,,,,,,,,,:;'+++'';;;;::;::::.`
`..,.`..,..,,:,,,,,,,,,,,.,,,::::::::,::,,:;'''';;;;;;;:::::::,`
`.,,..,,,...:,,,,,,,,:,::::;;''';;::::,::::;;'''+####++;::::::,`
``.,:,,,.`..,,,,,,,,,::;;;''+++''';;::,,,,:;''++#@@@####;:::::,.`
.,:;,,,,.:.:,,,,,,,:;''''++++++';;;::,,,:;'+'''@'@@#+++';::::,,
..';',,.:.,,,,,,,,:;;'''+''+';;;;;;;:,,,:;'+'###+';'';;'::,:::.
`:::;:,,...,,,,,,;;'''';;:;;;;;;;;;:,..,;+##';;:;;;::::::,,::`
,::,,::....,.,,,,;;;;;;:::'#++;;;;;:...,;++';;:::::::;:,:,::;`
,;;:,,.....,,.,,:;;;;:;;+@@@'+'';;':.`.,:''';:::::::;:,,,,::;
.;;':::....,,,,,:;;;;;+##@@#+###'';:.`..,;;;;;;;;;;;;:,,:,,:;
`;;+':,....,,..,:;;;;###@+#+'';;:;::.`..,,;:::;;;;;:.,,:,:::;`
;;'';,,....,,,,,:;;+++';::;;::;;;,:....,,,::,,,:,,...,,::::;,
:;;'',..,...,,,,:;;;,:,,:,::;;;::,,......,:,,,.......,,,::,;:
:';;':....,,,,::::;:,,,,,,:;;;:::,.....,.,,,,........,,,::,;:
.;:;;:.,,,,,,,,:,.,,:,,:::;;::,:,,......,,,,,........,,,,:,;:
:;;;;,..,,,,,,...,.,:::;;;;:,,,,...``..,..,,........,,,,:,;:
:;;::,,,,,,,,,..,.,,::;;::,.,,,,...```..,,:,,........,,,,,:;
.:::;:.:,,,,,,,,.,,............,..`.``.,,:;:,,.......,,,,,:;
,:::;:,:,,,,,,,.....``.`.........````..,;'';,......,,,,,,,:
:;,:;::,,:,,,,......````.`....,,,.```..,;;'',,,,,,.,,,,,,,'
,:.:;:::,,,,,,.....````````...,:,,````.,;,,#':,,,,,,,,,,,,.,
,,:;:;:::,,,,,....`````````.,:::,.```.,,.,:+;:,,,,,,,,,,,.,
,:,,::::,:,,,.....````````.,:,,:,..``..,..,'';:,,,,:::,,:,`
,,:,:::::,,,,......``````..::...,..``..,,,,'';;,,:,:::,::,`
,.:,,::::,,,,.............,;:......```.,,,,''';:,::::::::,,
,.,,::::,,,,............,:;:......``..,,,,''';::::::;::::'
,..,::::,,,,,..........,:;::.........,,.:#''';;:::;;;;;;;`
,.,,:::,,,,,..........,:;;::,,,,,...,,:;##';'+;:::;;;;;;:
`..,::::,,,,,,,.......::;;:::::::,,,,:;###':;+':::;;;;;;:
..,::::,,,,,,,,,....,:;';::''';:::::;'##+;';'+;::;;;;;;:
:,,:::,,:,,,,,,,,...,:;;:::;'++';;;;;##+#''+++;;;;;;;;;,
,,:::,,,:,,,,,,,,,,:;';;:;;+##++'''###++++'++';;;;;;;;.
`.:::::,:,:,::,,,,,::;';;;;;'+#+##++###++''++++;:;;;';;`
. `,:::::::::::::,,::;'';;;;'++++#+'+#+++':'+++;::;;;;;
, '::::::::::::::::;'''';;;''+++##'++'+';;++++;::;;;;'
: +:::::::::;::::::;'+';;';'+++++++++''''#+'++;:;;;;;'
. +:;::::::;:::;::;'+++''';'''+'++';;'';@#++++::;;';;:
:.+;;;:::::::;;:::;'+++''':;;;'';;;'';,;@#++++;:';;;'`
,::;;;::;:::::;:::;++++''';;;;;;''';;::@##+'++;:;';;'
':;;;;;;:;:;;;:::;+++#@;,,:,,,,.:.,::@@#+';'+:;;;;;'
#@';;;;:::::::;:::'+#+#@;,,.,.,`:,,'#@#+';;'+;;;;;',
+#:;;;;;;::::;::::;++'##@@#+#::.,'#####+';;'+'';;;'
;@,;;;;;;;::;;:::::++';+#####++######++';;;;+''';;'
#@;';;;;;;::::::,,:;+;::'+##++++#+'#+'';;;:;++';;;,
`##@+;;;;;;::::;::,,;+::::;;'++''+++'';;;;;;;++'';;#@+
.;@#:';;';;:::::::,,;+;::,:::;;;'';;::;:;;:;;++';''@@@@@@@:`
,+@@,';;;;;;::::;:,,;+;,,,,::,.,::,,:;;::::;;++';;'@@@@@@####@#;,;,`
,+#@+';;'';;;:::::::;+;:,::,::,,..,::;;::::;'++';;'@@@@@@@@@@#######@@@:`
,+###,';;'';;::::::,:+::,,::,::,,,,::;::::::;++';;'#@@@@@@##@##@@@@######@:`
.+;##:';;'';;;::::::;+',,,:::,,,,,:::;,:::::'++';''@@@@@@@@###@#############@; `
.'+#@#;;;;;;;;::::;::+':,,,,::,,,:,::,:,,:::'+#;;;'@@@@@@@@#####################@@
.':;@#,';;'';;:::;:::+'::,,,:::,,::,,...,,::'+#;;;'@@@@@@@@#######################@
`+@;+##'';;;;;:::::;;+'::.,,,,..,,,...,,,:::'+#';;'@#@@@@@#@#######################@
;#@#'#@:';;;;;;;::::'+':,,,,,,....,....,,,::'+#';;'@#@@@@@#@########################+
',+##+'@#:';;;;;:::::;++:,,,,,..,....,...,:,;'+++;;'@+#@@@@@@@########################'
`#;+#+#++#++;;;;;::::,;#'',...,...,,,..,`.,,:;++#+;;'@##@@@@###@########################'
###:#'#+;@':+;;;;;::::;++':,.............,,,,;'###;;'@##@@@@@##@#########################'
#### #'##+@@',';;;;:::::#+;:,,.......`....:,.:;+##+';'@#@@@@@@###@#########################+
:####+:+@#+###+:;;;;;::,;+++;,,.,`,....`...,:,:'+#++;;+##+@@@@@##############################+
###### ##'###@##;;;;;:::'##+':,,...`....,,.,:,;;###+';#:@##@@@@###############################+
+#######,#@###@@+#;;;;;:::+#+'::,..,,...,..,:::;'#+++';+:##+#@@@#################################
.########.#@###@@#'@;;;;;;;+##+;::,.,,.,..,,.,:;;+#+##+'+#+@'#@@@##################################
########## @#@#@@##'@;;;;'++#++';;:,,,,,,,,,:,:'+##+#+''##,@;@@@@##################################.
############,@###@@#++#;;;;'####''';:,,,,.,.,,:;'++###'';#@,#'@@@@@##################################
.###########'.#####@##+##;'+######++';;,,.,,.,.;;'+#++''';#@;+@@@@@###################################.
@##########';;`#@##@@##'@#'+#####+##+';;,,,,,,.;+++++'''';#@@;+##@@####################################;
###########+;;;;;####@#''#@##########+#+':,.,:,,;++#+''''''+@@,#+#@@####################################@.
+##########+;;;;;;#@###@+''##############;;:,.::::+#''''''''+##:#;#@@####################################@#
:###########;;;;;;;;@###@@+'@@###+#+######'',,.:,;:++';'''';++@#+;:@@@@###################################@#,
###########;;;;;;;;;;##@#@#'###@@#+++###+++'::,,,'';''''''''++#++.:#@@#######################################
+##########+;;;;;;;;;;:#@#@@++##@@@#@++####+';,,,,,;''''''''++'#;;@;@@########################################
`########+##;;;;;;;;;;;';###@#+##@@@@@;+';'+++;:,.,,;'''''''+++'##;#'@#@####################################@##
`###########+;;;;;;;;;;;;:'#@#@#+#@@@@@:#';;;;';:,,,:''''''''++''+#:####@####################################@##
.############;;;;;;;;;;;;;;,+#@###+@@@@@;#+';''';;;:,:''+''+'+++'++@@'###@#######################################,
`###########+';;;;;;;;;;;;;;;,'##@###@@@@#++'''''';,:,;'++++++++'''+#;;@##@@######################################@
##########++#;;;;;;;;'';;;;;;','#@@###@@@@'#+''''';:::++++++++++'+'+;:,@##@########################################,
+############;;;;;;;;;''';;;;;;'.:#@###@@@@:#++''''';:+'####++++++'''#+.###@@######################################++
#########@###;;;;;;;;;;''';;;;;'',,#@###@@@:#++++++++##########+++'';+':#@#########################################+'.
'##+######@@@#;;;;;;;;;;;''';;;;;';,`#####@@'##+++++###########+++''';+:;@##@########################################''
####+#######@#';;;;;;';;;;''';;;;;'':`##+#@@#+#################+++'';;#'########################################@#####'
:##############'';;;;;;;';;'''';;;;''';`:#+##@;#################++''';;+'###############################################:
###########+###;'';;;';+;::,;''';;;;''''.`@##@,@##@@@@@@#########++';;;;,@######################################@#######:
#########+#+##++;'';;';;;''';;;''';;;;'''';`.@+.@@#@@@@@@@#######++''';;',###############################################+.
`#########++####;;;'+';;'';:;';'##+';;;'''''';`.,@@@@@@@@@@######+++'';;;+;################################################.
###########+++#';;;;'';;;#':+,';+#'+';;;''''''';.`#@###@@@@######+++';;;;'#################################@###############'.
;#############'';;;;;;;;;'+++;:+;,+#'';;;;''''''''+:`:+@##########++''';;;,@################################################+.
#############;;;;;;;;;;;;:'#+++;',,:#''';;'''''''''''+':,:+#@#####++'''';;.@###############################################'+'`
#############;;;;;;;;;;;;;;;+#;+++';;;++';;;''''''''''''++++;,;@##++''''';;:@################################################''`
.##########+#;;;;;;;;;;;;;;;;;#;+'#+';'#'+';;;''''''''''''''++++'.'++''''';;'@################################################;'`,
###########++;;;;;;;;;;;;;';;;'+'++';,;'#''';;;'''''''''''''''+++++::'''';';#@##################################@####@########''`;:
;#########@##;;;;;;;;;;;;;;;';;'+#+###'::;'+';;;''''''''''''''''++'''+::'';;,@##################################@##############+''. `
#####@@###+#;;;;;;;;;;;;;;+:+++''#####++::''+';;;''''''''''''''''''''''':;;;.###################################@@##############'''.
'###@@######';;;;;;;;;;;;;;#+##+''######'+;'++'';;;;''''''''''''''''''''''':'.#@@################################@@##############'''+@.
###@@#######;;;;;;;;;;;;;;;;+##+''#######+':''+';;;;'''''''''''''''''''''''+:,##@################################@@##############+''+;,
'#@@####@@@@@;;;;;;;;;;;;;;;+++''+++###+;;#++:;''';;;;;''''''''''''''''''''''+;#@@################################@@###############''';'
#@########@@@#;;;;;;;;;;;;;;'''''#++++#++@;+++;:+';;;;;''''''''''''''''''''''+'@@#################################@@################'#+#`
,@@###########@+;;;;;;;;;;;;;;;;;++'+++;:#'#;'++;'+';;;;;;'''''''''''''''''''''##@#################################@@#################++#:
#@#############+';;;;;;;;;;;;::::;+'+++;,#+#'++';''';;;;;;;''''''''''''''''''+;##@#################################@@##################'''
@#############;;;';;;;;;;;;;;:::;+##'+';;+#@+@+#:;''';;;;''''''''';''''''''''':##@##################################@###################''
+##############;;;;';;;;;;;;;;:::,'###'+;''++@#+##;''';;;;''''''''';;''''''''''.##@##################################@#################@#+'.
@##############;;;;;';;;;;;;;;:,::;###++;':'+';++##;''';;;''''';;''';';''''''''`##@##################################@################@###';
;##############+;;;;;;;;;;;;;;;::,,;+####'',''+##+#';;'';;;;''''';''';;;''''''''`##@##################################@#############@##@####'
@#############++;;;;;;'';;;;;;;:,,,:'##+#'+''''+#+#+;;;+';;;''''';;'';;;''''''''.##@@#################################@###############@#####+,
###############';;;;;;;';;;;;;;:,:,,;++'###+:'''#;###;;'+;;;;;'''';;;;;;'''''''',#####################################@@##@##########@@######'
:##############+;;;;;;;;;';;;;;;:,,,::+#@####;'''';##+;;'+';;;'''''';;;;;'''''''''###@##################################@##@##########@########
@###############;;;;;;;;;;';;;;;;;::,,;+###'#+,'';'##+;;;'+;;;;;'''''';;;''''''';+###@##################################@##@#########@@########:
################;;;;;;;;;;;;;;;;;#;:,,:+##+@##;'+:''#;';;''';;;''''''''''''''''',####@##################################@##@########@@##########
`###############+;;;;;;;;;;;';;;;;;;':,,;+##+;##';+'',#;;;;'+;;;;''''''''''''''''.####@##################################@##@########@###########
,#############+#+;;;;;;;;;;;;';;;;'#:;,,:;##;####+'+''++:;;''';;;;;'''''''''''''' #######################################@##@#######@@###########,
###############';;;;;;;;;;;;;;';;;;'#'';;#':'#;##+++'',+;;;;'+;;;;;''''''''''''''`#######################################@##@#######@############'
@##########@;;;;;;;;;;;;;;;;;;;';;;''+':::'+#:@###++;+;'';;;''';;';'''''''''''''':#####@#################################@#@#######@############+;
##########+;;;;;;;;;;;;;;;;;;;;';;;';,:',;#+#++'###+:'';;';;###;;;;';''''''''''';'#######################################@@@####################+',
`########@'';;;;;;;;;;;;;;;;;;;;;';;:';;;:#+;';'@+@#++;+::;;;@##';;;;;''''''''''':######@#################################@#@######@##############'+
;#######@;;;;;;;;;;;;;;;;;;;;;;;;;';;:'''''##'#+,#'';+:'+':;;+##+;;;;;'''''''';''`######@#################################@@@@####################'+
@#######;'';;;;;;;;;;';';;;;;;;;;;';;',;,+,;###;+;####+'+':;'+##+';;;''''''''''''`######@#################################@@@#####################';`
#######;;'';;;;;;;;;;;'''';;;;;;;;'';',,'':'+###;@:##;;++::;+###++;;;''''''''''''.#######@################################@@@######################;:'
]
|
This patch is insufficient. Here's the proper fix: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
kaelig
commented
Aug 8, 2016
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jordanbuchman
Aug 8, 2016
Porting to TempleOS may be sufficient, as its text editor has embedded media support.
jordanbuchman
commented
Aug 8, 2016
•
edited
Edited 1 time
-
jordanbuchman
edited Aug 8, 2016 (most recent)
edited
Edited 1 time
-
Aug 8, 2016 (most recent)
|
Porting to TempleOS may be sufficient, as its text editor has embedded media support. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Daniel15
Aug 8, 2016
Member
its text editor has embedded media support.
My computer appears to have a text editor with media support. It's called "Microsoft Word". It also lets you write your code in Comic Sans, which is really useful for professional enterprise-level SaaS codebases.
My computer appears to have a text editor with media support. It's called "Microsoft Word". It also lets you write your code in Comic Sans, which is really useful for professional enterprise-level SaaS codebases. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
amasad
Aug 8, 2016
Member
Comic sans is pretty SaaSsy
On Mon, Aug 8, 2016, 11:55 AM Daniel Lo Nigro notifications@github.com
wrote:
its text editor has embedded media support.
My computer appears to have a text editor with media support. It's called
"Microsoft Word". It also lets you write your code in Comic Sans, which is
really useful for professional enterprise-level SaaS codebases.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3641 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAj2_oLe0aHkmIuKT-hy0uIhwBpOozdiks5qd3uZgaJpZM4Jd_yQ
.
|
Comic sans is pretty SaaSsy On Mon, Aug 8, 2016, 11:55 AM Daniel Lo Nigro notifications@github.com
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
valioDOTch
commented
Aug 8, 2016
|
This related issue gets way too few attention |
jamiebuilds
self-assigned this
Aug 9, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thanks for the fix.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jamiebuilds
Aug 9, 2016
Member
@hzoo @loganfsmyth can we get out an emergency bug fix? My team is blocked on this
|
@hzoo @loganfsmyth can we get out an emergency bug fix? My team is blocked on this |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
TAKE ME TO FLAVOUR TOWN. MERGED VIA 033681a. |
kittens
closed this
Aug 9, 2016
kittens
deleted the
guy-fieri
branch
Aug 9, 2016
ev1stensberg
reviewed
Aug 9, 2016
| @@ -30,6 +30,195 @@ export function Plugin(alias) { | ||
| throw new Error(`The (${alias}) Babel 5 plugin is being run with Babel 6.`); | ||
| } | ||
| // Sorry about all the MBs... | ||
| /* eslint-disable max-len */ | ||
| export const guy = [ |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ev1stensberg
Aug 9, 2016
Hi, it's Babel Bulbasaur from SanFran Recruiting office. We saw this incredible Pull Request and want to offer you a full time job as a open source trainer. The job mainly consists of playing Pokemon and telling people that this practise is a good for having a strong codebase, please don't hesitate to contact us at: dontclosethisthread@sanfranrecruit.us
ev1stensberg
Aug 9, 2016
Hi, it's Babel Bulbasaur from SanFran Recruiting office. We saw this incredible Pull Request and want to offer you a full time job as a open source trainer. The job mainly consists of playing Pokemon and telling people that this practise is a good for having a strong codebase, please don't hesitate to contact us at: dontclosethisthread@sanfranrecruit.us
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
c9s
Aug 9, 2016
...........................................................................................................
c9s
commented
Aug 9, 2016
|
........................................................................................................... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
darthrodolfo
commented
Aug 9, 2016
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
OlegLustenko
commented
Aug 9, 2016
|
Well done |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
naterkane
commented on f36d07d
Aug 9, 2016
|
OMFG this is gold |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
tracker1
replied
Aug 10, 2016
|
"I'm not your Guy, friend."
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
donkeysharp
replied
Aug 10, 2016
|
is there a reason for that ASCII Art? :P |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
masterT
replied
Aug 10, 2016
|
LOL but why? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
kag0
replied
Aug 10, 2016
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ryanflorence
replied
Aug 11, 2016
|
Thank you @thejameskyle |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
brentonstrine
Aug 11, 2016
You idiots! This is 186 lines long! If all of babel could fit on one line, this would be 186 times bigger than babel itself!! (Or 186% bigger!!)
brentonstrine
replied
Aug 11, 2016
•
edited
Edited 1 time
-
brentonstrine
edited Aug 11, 2016 (most recent)
edited
Edited 1 time
-
Aug 11, 2016 (most recent)
|
You idiots! This is 186 lines long! If all of babel could fit on one line, this would be 186 times bigger than babel itself!! (Or 186% bigger!!) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
sagivo
replied
Aug 11, 2016
|
seriously? it's funny and all but should not be in my code. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
yanzou
replied
Aug 11, 2016
|
LOL, best of today |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
michaeljs1990
Aug 13, 2016
@sagivo then fork it or write your own library. It's your job to know what you are using as a dependency.
michaeljs1990
replied
Aug 13, 2016
|
@sagivo then fork it or write your own library. It's your job to know what you are using as a dependency. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
hemanth
commented
Aug 9, 2016
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ajwhite
commented
Aug 9, 2016
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
nickzuber
commented
Aug 9, 2016
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
dncrews
commented
Aug 9, 2016
|
|
added a commit
to jdan/babel
that referenced
this pull request
Aug 9, 2016
pushed a commit
to d4rkr00t/babel
that referenced
this pull request
Aug 9, 2016
added a commit
that referenced
this pull request
Aug 15, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ultrafez
Aug 15, 2016
Jokes are great (and I'm glad this was removed in #3646), but the fact that this was merged makes me seriously question the professionalism of this project's maintainers, considering how widely-used Babel is.
ultrafez
commented
Aug 15, 2016
|
Jokes are great (and I'm glad this was removed in #3646), but the fact that this was merged makes me seriously question the professionalism of this project's maintainers, considering how widely-used Babel is. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jdan
Aug 15, 2016
Contributor
@ultrafez All jokes aside. I would give the maintainers a little credit here - they know what they're doing, and they care deeply about their users. They're not going to cause anyone any harm for a joke. They just added a bit of flair to code that's never sent to the client, and I don't see anything particularly unprofessional about that.
|
@ultrafez All jokes aside. I would give the maintainers a little credit here - they know what they're doing, and they care deeply about their users. They're not going to cause anyone any harm for a joke. They just added a bit of flair to code that's never sent to the client, and I don't see anything particularly unprofessional about that. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ajwhite
Aug 15, 2016
It has been removed from the codebase, it was a joke that was not part of any version release - end users will not be affected. I don't think it was ever the plan to incorporate this into any release.
ajwhite
commented
Aug 15, 2016
•
edited
Edited 1 time
-
ajwhite
edited Aug 15, 2016 (most recent)
edited
Edited 1 time
-
Aug 15, 2016 (most recent)
|
It has been removed from the codebase, it was a joke that was not part of any version release - end users will not be affected. I don't think it was ever the plan to incorporate this into any release. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jamiebuilds
Aug 15, 2016
Member
@ultrafez Thank you for your feedback, we take it very seriously and we'll continue to work to improve. Feel free to let us know if we're ever not meeting your standards in the future. It's our job to please you and if we ever fail to do that we want to hear about it.
Your humble servant,
James Kyle
|
@ultrafez Thank you for your feedback, we take it very seriously and we'll continue to work to improve. Feel free to let us know if we're ever not meeting your standards in the future. It's our job to please you and if we ever fail to do that we want to hear about it. Your humble servant, |
babel
locked and limited conversation to collaborators
Aug 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
jamiebuilds commentedAug 5, 2016
No description provided.