Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exports of babel-core #3641

Closed
wants to merge 4 commits into from
Closed

Fix exports of babel-core #3641

wants to merge 4 commits into from

Conversation

@jamiebuilds
Copy link
Contributor

@jamiebuilds jamiebuilds commented Aug 5, 2016

No description provided.

jamiebuilds added 2 commits Aug 5, 2016
@loganfsmyth
Copy link
Member

@loganfsmyth loganfsmyth commented Aug 5, 2016

Needs more bytes, sorry. Can we add a linting rule for minimum file size?

@hzoo
Copy link
Member

@hzoo hzoo commented Aug 5, 2016

Needs some unit tests so we don't regress

@samlecuyer
Copy link

@samlecuyer samlecuyer commented Aug 5, 2016

I hate to be that guy, but exports.guy was an Array in the article.

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 5, 2016

Current coverage is 88.13% (diff: 100%)

Merging #3641 into master will increase coverage by <.01%

@@             master      #3641   diff @@
==========================================
  Files           188        188          
  Lines         10924      10925     +1   
  Methods        1162       1162          
  Messages          0          0          
  Branches       2492       2492          
==========================================
+ Hits           9628       9629     +1   
  Misses         1296       1296          
  Partials          0          0          

Powered by Codecov. Last update 154922c...f36d07d

@mpj
Copy link

@mpj mpj commented Aug 6, 2016

Can you please extract this into a separate npm package? It seems like it could have general use.

@hzoo hzoo added this to the Next Patch milestone Aug 6, 2016
@kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Aug 6, 2016

lol 😂

@d3viant0ne
Copy link

@d3viant0ne d3viant0ne commented Aug 6, 2016

I agree with @mpj - This should really be extracted into it a plugin for Historical comedic value

This may turn out to be the greatest medium post of all time :)
I wonder if the Express/Loopback group is going to have the same sense of humor ...

@amasad
Copy link
Member

@amasad amasad commented Aug 7, 2016

Can you please use a gender neutral export name?

@raabbajam
Copy link

@raabbajam raabbajam commented Aug 7, 2016

Can you please use a gender neutral export name?

Umm, did you just assume it's gender? Lol, jk. Guy is his name, though. Guy Fieri.
Also, yes please fix it as array.
This one is better:

import {guy} from 'babel-core';
const [GuyFieri] = guy;
@amasad
Copy link
Member

@amasad amasad commented Aug 7, 2016

His name is offending my taste buds

@andreasklinger
Copy link

@andreasklinger andreasklinger commented Aug 7, 2016

"Hate to be that guy"… but specs are missing

@stevemao
Copy link
Contributor

@stevemao stevemao commented Aug 8, 2016

Please remove that guy :(

@Daniel15
Copy link
Member

@Daniel15 Daniel15 commented Aug 8, 2016

This patch is insufficient. Here's the proper fix:

export const guy = [
'                                                                                                                                                                                                       
                                                                     `                  `                                                                                                               
                                                                         `              `   `                                                                                                           
                                                                    ``.```    . ``      `  `. `                                                                                                         
                                                                    ``````` ` ` `   ` . .  ``                                                                                                           
                                                                    ```. `.```.   ... ``..```` `                                                                                                        
                                                            `  `   `` .`.`` ..`.``....`.`.`....` .                                                                                                      
                                                            ` ..`  `. ..``.`....``....```.....``` `                                                                                                     
                                                      `    `.  ``.``.`.````.`.```...`.....``...````                                                                                                     
                                                          ` .  ...`,..`..```...``.````. `.```.`` .`                                                                                                     
                                                       .`  .````....`.````````````````````.````` ``                                                                                                     
                                                      . .` ``.`.`.``````````````````.``````````  `   `                                                                                                  
                                                     `.`` .```..`.````````````````````````````` `````                                                                                                   
                                                      `.` ...```.`````````````````````````````.``.`...                                                                                                  
                                                   ` ``..``````````````````````````````````````.`.``.`   `                                                                                              
                                                    ``````.`````````````````````````````````` ``..```  `.                                                                                               
                                                     ``..``````````````` .````````````````````.`..``` . `                                                                                               
                                               .`  `` .`.``.```.``````````.```````````````````.``...`.  `                                                                                               
                                                .``` .`.```````````````````````````````````````````.`. ``                                                                                               
                                               ` ```` ....````````````..````` ```````````````````````.`.  `                                                                                             
                                               ` ````..``````` ```````.`````` ````````` `````````..`..`.                                                                                                
                                              . ` `.  ``.```````````````````` ```.````` `````.```.``..`. .                                                                                              
                                               ` ``` `````` ``````````.``````````.````````.``.```.``..`.```                                                                                             
                                              `` ``.   ````````` ``````````````..`````````.```. `````.`..``                                                                                             
                                             `````.` ` ``````````.` ` ````````````````.` `.``.`````````. `.                                                                                             
                                             `   `.`  `````` ````.```````````````.`.```````````````````.``.`                                                                                            
                                           ```   `.````````` ``` ``````````````````````````````````````...``                                                                                            
                                            ```    `.`````` `````````.``````.````.``````````````````````.``.                                                                                            
                                            `.` `.`  ````````````.````````.`````````````````````` ````````.`                                                                                            
                                             ` ` ```   ``` ```  `.``````````.```.`..``..``.``````  `````.`..                                                                                            
                                              ``````. `````` `` ``````.``.``.`````..``````.````.`` ``````... `                                                                                          
                                              ```````..```````` ````.`.```````````..````````.```````````..``                                                                                            
                                              `.````` ` ````` `  `````.``.``````....``````.`.`..````````.```..                                                                                          
                                              `````.````  ``` ``  ````````.````.``..`.` ````.`.``.`````````.``                                                                                          
                                           ` `` `.`.`` `     ` ` ```.`````````````.``.``.`.`...``....``````.` `                                                                                         
                                             ``..```````` ` `. ``````...`````````````.`.`.`.....,,....````..`                                                                                           
                                            `.`,``````.```   `` ` .```..`````````.```````..,,...,,,,...```````                                                                                          
                                            `.`.`` ```````   ``````.`````````````````..`........,,,,...`````.````                                                                                       
                                             `.``.```````` ` ``.`..``.`....````````............,,,,,,..`````.                                                                                           
                                           ` ...`````````` `````.`.......`````````..`..`.......,,,,,,.`..`.`. `                                                                                         
                                            ``..`````````````.`..........`````````````........,.,,,,,........`                                                                                          
                                            ``````````````````.............````````````........,,,,,,.`.......                                                                                          
                                            .````. ``` `` `.....``.......`.````````````........,,,,,,,.....`.`                                                                                          
                                            `` `` ```` `````.............``````````````.......,,,,,,:,.......``                                                                                         
                                             ``.``  ``` ````................``````````.......,,,,,:,,,...`...`                                                                                          
                                           ` .`````  ``.````................`````````........,,.,,:,::,......`                                                                                          
                                           ``````````` `````.................```````.........,,,,,:,,:..`..,.`                                                                                          
                                            ```.``````` ```....................```..........,,,,,,,,::,.`.....`                                                                                         
                                            . `.``````..````.......,............``.........,,,,,,,,,,:,...,...                                                                                          
                                            `.  ``````.`.````.,.............................,,,,,,,:,:,....,..`                                                                                         
                                             `. `````..`.````.,...,........................,,,,,,,,,,::,...,..                                                                                          
                                            ``.``````....```..,,.,,,,......................,,,,,,,,,:::,,.,,.`                                                                                          
                                            `````````.``.```...,.,,,,,....................,,,,,,,,,,,::,,,.,,`                                                                                          
                                             `.``.`.``..``.....,.,..,,,....................,,,,,,,,,,:::,.,.,,                                                                                          
                                             .```.`..``.```.``.,.,,.,,,,,..................,,,,,,,,,,:::,,.,,`                                                                                          
                                            ` .```.........``..,,,,,,,.....................,,,,,,,,,,:::,,..,`                                                                                          
                                            `` `.````,`,`.```..,,,..,,,.......................,,,,,,,,:::,..,                                                                                           
                                             `````````.`..``...,,,.,,,........................,.,,,,,,:::;,.,.                                                                                          
                                             .`....````,..`.`.,,,,,,,,,........................,,,,,,::::',.,.                                                                                          
                                             ```.... ``.`..`.`,,,,,,,,.,.......................,,,,,,::::;:,,.                                                                                          
                                             ```.,..` ```.. `..,,,,,,,,.,......................,,,,,,,:::;;,:;.                                                                                         
                                             ``...,,,..``.`.`..,,,,,,,,.......................,,,,,,,:::::;,.;`                                                                                         
                                              ````,,.,,..`.`...,,,,,,,,..........`..........,,,,,,,,,,::::;,.:`                                                                                         
                                               `.``...`..```.`.,,,,,,,,....................,,,,,,,,,::::::;:,;.                                                                                         
                                               `.``.`.,``...`.,,,,,,,,,...................,,,,,,::;;;';;::::,;,                                                                                         
                                               ......`````...,:,,,,,,,,,..............,,,,,,:::'''''''''::::,:,                                                                                         
                                               `.....,.......,,,,,,,,,.,,......,,...,,,,,,::;;'++++++''';:::,,,                                                                                         
                                              `..````.......,:,,,,,,,,..,..,...,,,,,,,,,,,:;'++##++''';;;:::,,.                                                                                         
                                                ..``..`..,,:,,,,,,,,,,...,,,..,,:,,,,,,,,,:;'+++'';;;;::;::::.`                                                                                         
                                               `..,.`..,..,,:,,,,,,,,,,,.,,,::::::::,::,,:;'''';;;;;;;:::::::,`                                                                                         
                                               `.,,..,,,...:,,,,,,,,:,::::;;''';;::::,::::;;'''+####++;::::::,`                                                                                         
                                               ``.,:,,,.`..,,,,,,,,,::;;;''+++''';;::,,,,:;''++#@@@####;:::::,.`                                                                                        
                                                .,:;,,,,.:.:,,,,,,,:;''''++++++';;;::,,,:;'+'''@'@@#+++';::::,,                                                                                         
                                                ..';',,.:.,,,,,,,,:;;'''+''+';;;;;;;:,,,:;'+'###+';'';;'::,:::.                                                                                         
                                                 `:::;:,,...,,,,,,;;'''';;:;;;;;;;;;:,..,;+##';;:;;;::::::,,::`                                                                                         
                                                 ,::,,::....,.,,,,;;;;;;:::'#++;;;;;:...,;++';;:::::::;:,:,::;`                                                                                         
                                                 ,;;:,,.....,,.,,:;;;;:;;+@@@'+'';;':.`.,:''';:::::::;:,,,,::;                                                                                          
                                                 .;;':::....,,,,,:;;;;;+##@@#+###'';:.`..,;;;;;;;;;;;;:,,:,,:;                                                                                          
                                                 `;;+':,....,,..,:;;;;###@+#+'';;:;::.`..,,;:::;;;;;:.,,:,:::;`                                                                                         
                                                  ;;'';,,....,,,,,:;;+++';::;;::;;;,:....,,,::,,,:,,...,,::::;,                                                                                         
                                                  :;;'',..,...,,,,:;;;,:,,:,::;;;::,,......,:,,,.......,,,::,;:                                                                                         
                                                  :';;':....,,,,::::;:,,,,,,:;;;:::,.....,.,,,,........,,,::,;:                                                                                         
                                                  .;:;;:.,,,,,,,,:,.,,:,,:::;;::,:,,......,,,,,........,,,,:,;:                                                                                         
                                                   :;;;;,..,,,,,,...,.,:::;;;;:,,,,...``..,..,,........,,,,:,;:                                                                                         
                                                   :;;::,,,,,,,,,..,.,,::;;::,.,,,,...```..,,:,,........,,,,,:;                                                                                         
                                                   .:::;:.:,,,,,,,,.,,............,..`.``.,,:;:,,.......,,,,,:;                                                                                         
                                                    ,:::;:,:,,,,,,,.....``.`.........````..,;'';,......,,,,,,,:                                                                                         
                                                    :;,:;::,,:,,,,......````.`....,,,.```..,;;'',,,,,,.,,,,,,,'                                                                                         
                                                    ,:.:;:::,,,,,,.....````````...,:,,````.,;,,#':,,,,,,,,,,,,.,                                                                                        
                                                     ,,:;:;:::,,,,,....`````````.,:::,.```.,,.,:+;:,,,,,,,,,,,.,                                                                                        
                                                     ,:,,::::,:,,,.....````````.,:,,:,..``..,..,'';:,,,,:::,,:,`                                                                                        
                                                     ,,:,:::::,,,,......``````..::...,..``..,,,,'';;,,:,:::,::,`                                                                                        
                                                     ,.:,,::::,,,,.............,;:......```.,,,,''';:,::::::::,,                                                                                        
                                                      ,.,,::::,,,,............,:;:......``..,,,,''';::::::;::::'                                                                                        
                                                      ,..,::::,,,,,..........,:;::.........,,.:#''';;:::;;;;;;;`                                                                                        
                                                      ,.,,:::,,,,,..........,:;;::,,,,,...,,:;##';'+;:::;;;;;;:                                                                                         
                                                      `..,::::,,,,,,,.......::;;:::::::,,,,:;###':;+':::;;;;;;:                                                                                         
                                                       ..,::::,,,,,,,,,....,:;';::''';:::::;'##+;';'+;::;;;;;;:                                                                                         
                                                       :,,:::,,:,,,,,,,,...,:;;:::;'++';;;;;##+#''+++;;;;;;;;;,                                                                                         
                                                        ,,:::,,,:,,,,,,,,,,:;';;:;;+##++'''###++++'++';;;;;;;;.                                                                                         
                                                       `.:::::,:,:,::,,,,,::;';;;;;'+#+##++###++''++++;:;;;';;`                                                                                         
                                                       . `,:::::::::::::,,::;'';;;;'++++#+'+#+++':'+++;::;;;;;                                                                                          
                                                       ,  '::::::::::::::::;'''';;;''+++##'++'+';;++++;::;;;;'                                                                                          
                                                       :  +:::::::::;::::::;'+';;';'+++++++++''''#+'++;:;;;;;'                                                                                          
                                                       .  +:;::::::;:::;::;'+++''';'''+'++';;'';@#++++::;;';;:                                                                                          
                                                        :.+;;;:::::::;;:::;'+++''':;;;'';;;'';,;@#++++;:';;;'`                                                                                          
                                                        ,::;;;::;:::::;:::;++++''';;;;;;''';;::@##+'++;:;';;'                                                                                           
                                                         ':;;;;;;:;:;;;:::;+++#@;,,:,,,,.:.,::@@#+';'+:;;;;;'                                                                                           
                                                         #@';;;;:::::::;:::'+#+#@;,,.,.,`:,,'#@#+';;'+;;;;;',                                                                                           
                                                         +#:;;;;;;::::;::::;++'##@@#+#::.,'#####+';;'+'';;;'                                                                                            
                                                         ;@,;;;;;;;::;;:::::++';+#####++######++';;;;+''';;'                                                                                            
                                                         #@;';;;;;;::::::,,:;+;::'+##++++#+'#+'';;;:;++';;;,                                                                                            
                                                        `##@+;;;;;;::::;::,,;+::::;;'++''+++'';;;;;;;++'';;#@+                                                                                          
                                                        .;@#:';;';;:::::::,,;+;::,:::;;;'';;::;:;;:;;++';''@@@@@@@:`                                                                                    
                                                        ,+@@,';;;;;;::::;:,,;+;,,,,::,.,::,,:;;::::;;++';;'@@@@@@####@#;,;,`                                                                            
                                                        ,+#@+';;'';;;:::::::;+;:,::,::,,..,::;;::::;'++';;'@@@@@@@@@@#######@@@:`                                                                       
                                                        ,+###,';;'';;::::::,:+::,,::,::,,,,::;::::::;++';;'#@@@@@@##@##@@@@######@:`                                                                    
                                                        .+;##:';;'';;;::::::;+',,,:::,,,,,:::;,:::::'++';''@@@@@@@@###@#############@;  `                                                               
                                                        .'+#@#;;;;;;;;::::;::+':,,,,::,,,:,::,:,,:::'+#;;;'@@@@@@@@#####################@@                                                              
                                                        .':;@#,';;'';;:::;:::+'::,,,:::,,::,,...,,::'+#;;;'@@@@@@@@#######################@                                                             
                                                        `+@;+##'';;;;;:::::;;+'::.,,,,..,,,...,,,:::'+#';;'@#@@@@@#@#######################@                                                            
                                                        ;#@#'#@:';;;;;;;::::'+':,,,,,,....,....,,,::'+#';;'@#@@@@@#@########################+                                                           
                                                       ',+##+'@#:';;;;;:::::;++:,,,,,..,....,...,:,;'+++;;'@+#@@@@@@@########################'                                                          
                                                      `#;+#+#++#++;;;;;::::,;#'',...,...,,,..,`.,,:;++#+;;'@##@@@@###@########################'                                                         
                                                      ###:#'#+;@':+;;;;;::::;++':,.............,,,,;'###;;'@##@@@@@##@#########################'                                                        
                                                     #### #'##+@@',';;;;:::::#+;:,,.......`....:,.:;+##+';'@#@@@@@@###@#########################+                                                       
                                                    :####+:+@#+###+:;;;;;::,;+++;,,.,`,....`...,:,:'+#++;;+##+@@@@@##############################+                                                      
                                                    ###### ##'###@##;;;;;:::'##+':,,...`....,,.,:,;;###+';#:@##@@@@###############################+                                                     
                                                   +#######,#@###@@+#;;;;;:::+#+'::,..,,...,..,:::;'#+++';+:##+#@@@#################################                                                    
                                                  .########.#@###@@#'@;;;;;;;+##+;::,.,,.,..,,.,:;;+#+##+'+#+@'#@@@##################################                                                   
                                                  ########## @#@#@@##'@;;;;'++#++';;:,,,,,,,,,:,:'+##+#+''##,@;@@@@##################################.                                                  
                                                 ############,@###@@#++#;;;;'####''';:,,,,.,.,,:;'++###'';#@,#'@@@@@##################################                                                  
                                                .###########'.#####@##+##;'+######++';;,,.,,.,.;;'+#++''';#@;+@@@@@###################################.                                                 
                                                @##########';;`#@##@@##'@#'+#####+##+';;,,,,,,.;+++++'''';#@@;+##@@####################################;                                                
                                               ###########+;;;;;####@#''#@##########+#+':,.,:,,;++#+''''''+@@,#+#@@####################################@.                                               
                                              +##########+;;;;;;#@###@+''##############;;:,.::::+#''''''''+##:#;#@@####################################@#                                               
                                             :###########;;;;;;;;@###@@+'@@###+#+######'',,.:,;:++';'''';++@#+;:@@@@###################################@#,                                              
                                             ###########;;;;;;;;;;##@#@#'###@@#+++###+++'::,,,'';''''''''++#++.:#@@#######################################                                              
                                            +##########+;;;;;;;;;;:#@#@@++##@@@#@++####+';,,,,,;''''''''++'#;;@;@@########################################                                              
                                           `########+##;;;;;;;;;;;';###@#+##@@@@@;+';'+++;:,.,,;'''''''+++'##;#'@#@####################################@##                                              
                                          `###########+;;;;;;;;;;;;:'#@#@#+#@@@@@:#';;;;';:,,,:''''''''++''+#:####@####################################@##                                              
                                         .############;;;;;;;;;;;;;;,+#@###+@@@@@;#+';''';;;:,:''+''+'+++'++@@'###@#######################################,                                             
                                        `###########+';;;;;;;;;;;;;;;,'##@###@@@@#++'''''';,:,;'++++++++'''+#;;@##@@######################################@                                             
                                        ##########++#;;;;;;;;'';;;;;;','#@@###@@@@'#+''''';:::++++++++++'+'+;:,@##@########################################,                                            
                                       +############;;;;;;;;;''';;;;;;'.:#@###@@@@:#++''''';:+'####++++++'''#+.###@@######################################++                                            
                                       #########@###;;;;;;;;;;''';;;;;'',,#@###@@@:#++++++++##########+++'';+':#@#########################################+'.                                           
                                      '##+######@@@#;;;;;;;;;;;''';;;;;';,`#####@@'##+++++###########+++''';+:;@##@########################################''                                           
                                      ####+#######@#';;;;;;';;;;''';;;;;'':`##+#@@#+#################+++'';;#'########################################@#####'                                           
                                     :##############'';;;;;;;';;'''';;;;''';`:#+##@;#################++''';;+'###############################################:                                          
                                     ###########+###;'';;;';+;::,;''';;;;''''.`@##@,@##@@@@@@#########++';;;;,@######################################@#######:                                          
                                    #########+#+##++;'';;';;;''';;;''';;;;'''';`.@+.@@#@@@@@@@#######++''';;',###############################################+.                                         
                                   `#########++####;;;'+';;'';:;';'##+';;;'''''';`.,@@@@@@@@@@######+++'';;;+;################################################.                                         
                                   ###########+++#';;;;'';;;#':+,';+#'+';;;''''''';.`#@###@@@@######+++';;;;'#################################@###############'.                                        
                                  ;#############'';;;;;;;;;'+++;:+;,+#'';;;;''''''''+:`:+@##########++''';;;,@################################################+.                                        
                                  #############;;;;;;;;;;;;:'#+++;',,:#''';;'''''''''''+':,:+#@#####++'''';;.@###############################################'+'`                                       
                                 #############;;;;;;;;;;;;;;;+#;+++';;;++';;;''''''''''''++++;,;@##++''''';;:@################################################''`                                       
                                .##########+#;;;;;;;;;;;;;;;;;#;+'#+';'#'+';;;''''''''''''''++++'.'++''''';;'@################################################;'`,                                      
                                ###########++;;;;;;;;;;;;;';;;'+'++';,;'#''';;;'''''''''''''''+++++::'''';';#@##################################@####@########''`;:                                     
                               ;#########@##;;;;;;;;;;;;;;;';;'+#+###'::;'+';;;''''''''''''''''++'''+::'';;,@##################################@##############+''. `                                    
                               #####@@###+#;;;;;;;;;;;;;;+:+++''#####++::''+';;;''''''''''''''''''''''':;;;.###################################@@##############'''.                                     
                              '###@@######';;;;;;;;;;;;;;#+##+''######'+;'++'';;;;''''''''''''''''''''''':'.#@@################################@@##############'''+@.                                   
                              ###@@#######;;;;;;;;;;;;;;;;+##+''#######+':''+';;;;'''''''''''''''''''''''+:,##@################################@@##############+''+;,                                   
                             '#@@####@@@@@;;;;;;;;;;;;;;;+++''+++###+;;#++:;''';;;;;''''''''''''''''''''''+;#@@################################@@###############''';'                                   
                             #@########@@@#;;;;;;;;;;;;;;'''''#++++#++@;+++;:+';;;;;''''''''''''''''''''''+'@@#################################@@################'#+#`                                  
                            ,@@###########@+;;;;;;;;;;;;;;;;;++'+++;:#'#;'++;'+';;;;;;'''''''''''''''''''''##@#################################@@#################++#:                                  
                            #@#############+';;;;;;;;;;;;::::;+'+++;,#+#'++';''';;;;;;;''''''''''''''''''+;##@#################################@@##################'''                                  
                            @#############;;;';;;;;;;;;;;:::;+##'+';;+#@+@+#:;''';;;;''''''''';''''''''''':##@##################################@###################''                                  
                           +##############;;;;';;;;;;;;;;:::,'###'+;''++@#+##;''';;;;''''''''';;''''''''''.##@##################################@#################@#+'.                                 
                           @##############;;;;;';;;;;;;;;:,::;###++;':'+';++##;''';;;''''';;''';';''''''''`##@##################################@################@###';                                 
                          ;##############+;;;;;;;;;;;;;;;::,,;+####'',''+##+#';;'';;;;''''';''';;;''''''''`##@##################################@#############@##@####'                                 
                          @#############++;;;;;;'';;;;;;;:,,,:'##+#'+''''+#+#+;;;+';;;''''';;'';;;''''''''.##@@#################################@###############@#####+,                                
                          ###############';;;;;;;';;;;;;;:,:,,;++'###+:'''#;###;;'+;;;;;'''';;;;;;'''''''',#####################################@@##@##########@@######'                                
                         :##############+;;;;;;;;;';;;;;;:,,,::+#@####;'''';##+;;'+';;;'''''';;;;;'''''''''###@##################################@##@##########@########                                
                         @###############;;;;;;;;;;';;;;;;;::,,;+###'#+,'';'##+;;;'+;;;;;'''''';;;''''''';+###@##################################@##@#########@@########:                               
                         ################;;;;;;;;;;;;;;;;;#;:,,:+##+@##;'+:''#;';;''';;;''''''''''''''''',####@##################################@##@########@@##########                               
                        `###############+;;;;;;;;;;;';;;;;;;':,,;+##+;##';+'',#;;;;'+;;;;''''''''''''''''.####@##################################@##@########@###########                               
                        ,#############+#+;;;;;;;;;;;;';;;;'#:;,,:;##;####+'+''++:;;''';;;;;'''''''''''''' #######################################@##@#######@@###########,                              
                        ###############';;;;;;;;;;;;;;';;;;'#'';;#':'#;##+++'',+;;;;'+;;;;;''''''''''''''`#######################################@##@#######@############'                              
                        @##########@;;;;;;;;;;;;;;;;;;;';;;''+':::'+#:@###++;+;'';;;''';;';'''''''''''''':#####@#################################@#@#######@############+;                              
                        ##########+;;;;;;;;;;;;;;;;;;;;';;;';,:',;#+#++'###+:'';;';;###;;;;';''''''''''';'#######################################@@@####################+',                             
                       `########@'';;;;;;;;;;;;;;;;;;;;;';;:';;;:#+;';'@+@#++;+::;;;@##';;;;;''''''''''':######@#################################@#@######@##############'+                             
                       ;#######@;;;;;;;;;;;;;;;;;;;;;;;;;';;:'''''##'#+,#'';+:'+':;;+##+;;;;;'''''''';''`######@#################################@@@@####################'+                             
                       @#######;'';;;;;;;;;;';';;;;;;;;;;';;',;,+,;###;+;####+'+':;'+##+';;;''''''''''''`######@#################################@@@#####################';`                            
                       #######;;'';;;;;;;;;;;'''';;;;;;;;'';',,'':'+###;@:##;;++::;+###++;;;''''''''''''.#######@################################@@@######################;:'
]
@kaelig
Copy link

@kaelig kaelig commented Aug 8, 2016

:shipit:

@jordanbuchman
Copy link

@jordanbuchman jordanbuchman commented Aug 8, 2016

Porting to TempleOS may be sufficient, as its text editor has embedded media support.

@Daniel15
Copy link
Member

@Daniel15 Daniel15 commented Aug 8, 2016

its text editor has embedded media support.

My computer appears to have a text editor with media support. It's called "Microsoft Word". It also lets you write your code in Comic Sans, which is really useful for professional enterprise-level SaaS codebases.

@amasad
Copy link
Member

@amasad amasad commented Aug 8, 2016

Comic sans is pretty SaaSsy

On Mon, Aug 8, 2016, 11:55 AM Daniel Lo Nigro notifications@github.com
wrote:

its text editor has embedded media support.

My computer appears to have a text editor with media support. It's called
"Microsoft Word". It also lets you write your code in Comic Sans, which is
really useful for professional enterprise-level SaaS codebases.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3641 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAj2_oLe0aHkmIuKT-hy0uIhwBpOozdiks5qd3uZgaJpZM4Jd_yQ
.

@valioDOTch
Copy link

@valioDOTch valioDOTch commented Aug 8, 2016

This related issue gets way too few attention
defunctzombie/node-yummy#7

@jamiebuilds jamiebuilds self-assigned this Aug 9, 2016
@Daniel15
Copy link
Member

@Daniel15 Daniel15 commented Aug 9, 2016

Thanks for the fix.

:shipit:

@jamiebuilds
Copy link
Contributor Author

@jamiebuilds jamiebuilds commented Aug 9, 2016

@hzoo @loganfsmyth can we get out an emergency bug fix? My team is blocked on this

@sebmck
Copy link
Contributor

@sebmck sebmck commented Aug 9, 2016

TAKE ME TO FLAVOUR TOWN. MERGED VIA 033681a.

@sebmck sebmck closed this Aug 9, 2016
@sebmck sebmck deleted the guy-fieri branch Aug 9, 2016
@@ -30,6 +30,195 @@ export function Plugin(alias) {
throw new Error(`The (${alias}) Babel 5 plugin is being run with Babel 6.`);
}

// Sorry about all the MBs...
/* eslint-disable max-len */
export const guy = [

This comment has been minimized.

@evenstensberg

evenstensberg Aug 9, 2016

Hi, it's Babel Bulbasaur from SanFran Recruiting office. We saw this incredible Pull Request and want to offer you a full time job as a open source trainer. The job mainly consists of playing Pokemon and telling people that this practise is a good for having a strong codebase, please don't hesitate to contact us at: dontclosethisthread@sanfranrecruit.us

@c9s
Copy link

@c9s c9s commented Aug 9, 2016

...........................................................................................................

@darthrodolfo
Copy link

@darthrodolfo darthrodolfo commented Aug 9, 2016

@OlegLustenko
Copy link

@OlegLustenko OlegLustenko commented Aug 9, 2016

Well done 👍

@naterkane

This comment has been minimized.

Copy link

@naterkane naterkane commented on f36d07d Aug 9, 2016

OMFG this is gold

This comment has been minimized.

Copy link

@tracker1 tracker1 replied Aug 10, 2016

"I'm not your Guy, friend."

This comment has been minimized.

Copy link

@donkeysharp donkeysharp replied Aug 10, 2016

is there a reason for that ASCII Art? :P

This comment has been minimized.

Copy link

@masterT masterT replied Aug 10, 2016

LOL but why?

This comment has been minimized.

Copy link

@kag0 kag0 replied Aug 10, 2016

👍 this is the change the world needs.

This comment has been minimized.

Copy link

@ryanflorence ryanflorence replied Aug 11, 2016

Thank you @thejameskyle

This comment has been minimized.

Copy link

@brentonstrine brentonstrine replied Aug 11, 2016

You idiots! This is 186 lines long! If all of babel could fit on one line, this would be 186 times bigger than babel itself!! (Or 186% bigger!!)

This comment has been minimized.

Copy link

@sagivo sagivo replied Aug 11, 2016

seriously? it's funny and all but should not be in my code.

This comment has been minimized.

Copy link

@yanzou yanzou replied Aug 11, 2016

LOL, best of today

This comment has been minimized.

Copy link

@michaeljs1990 michaeljs1990 replied Aug 13, 2016

@sagivo then fork it or write your own library. It's your job to know what you are using as a dependency.

@hemanth
Copy link

@hemanth hemanth commented Aug 9, 2016

@ajwhite
Copy link

@ajwhite ajwhite commented Aug 9, 2016

👎 you missed a dot, please review before submission

@nickzuber
Copy link

@nickzuber nickzuber commented Aug 9, 2016

@dncrews
Copy link

@dncrews dncrews commented Aug 9, 2016

ddd-ascii

jdan added a commit to jdan/babel that referenced this pull request Aug 9, 2016
This reverts commit 033681a, reversing
changes made to a2d66c0.

I brought you into this world, and I can take you out.
d4rkr00t pushed a commit to d4rkr00t/babel that referenced this pull request Aug 9, 2016
hzoo added a commit that referenced this pull request Aug 15, 2016
This reverts commit 033681a, reversing
changes made to a2d66c0.

I brought you into this world, and I can take you out.
@ultrafez
Copy link

@ultrafez ultrafez commented Aug 15, 2016

Jokes are great (and I'm glad this was removed in #3646), but the fact that this was merged makes me seriously question the professionalism of this project's maintainers, considering how widely-used Babel is.

@jdan
Copy link
Contributor

@jdan jdan commented Aug 15, 2016

@ultrafez All jokes aside. I would give the maintainers a little credit here - they know what they're doing, and they care deeply about their users. They're not going to cause anyone any harm for a joke. They just added a bit of flair to code that's never sent to the client, and I don't see anything particularly unprofessional about that.

@ajwhite
Copy link

@ajwhite ajwhite commented Aug 15, 2016

It has been removed from the codebase, it was a joke that was not part of any version release - end users will not be affected. I don't think it was ever the plan to incorporate this into any release.

@jamiebuilds
Copy link
Contributor Author

@jamiebuilds jamiebuilds commented Aug 15, 2016

@ultrafez Thank you for your feedback, we take it very seriously and we'll continue to work to improve. Feel free to let us know if we're ever not meeting your standards in the future. It's our job to please you and if we ever fail to do that we want to hear about it.

Your humble servant,
James Kyle

@babel babel locked and limited conversation to collaborators Aug 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.