-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Fix exports of babel-core #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Needs more bytes, sorry. Can we add a linting rule for minimum file size? |
Needs some unit tests so we don't regress |
I hate to be that guy, but |
Current coverage is 88.13% (diff: 100%)@@ master #3641 diff @@
==========================================
Files 188 188
Lines 10924 10925 +1
Methods 1162 1162
Messages 0 0
Branches 2492 2492
==========================================
+ Hits 9628 9629 +1
Misses 1296 1296
Partials 0 0
|
Can you please extract this into a separate npm package? It seems like it could have general use. |
lol 😂 |
I agree with @mpj - This should really be extracted into it a plugin for This may turn out to be the greatest medium post of all time :) |
Can you please use a gender neutral export name? |
Umm, did you just assume it's gender? Lol, jk.
|
His name is offending my taste buds |
"Hate to be that guy"… but specs are missing |
Please remove that guy :( |
This patch is insufficient. Here's the proper fix:
|
|
Porting to TempleOS may be sufficient, as its text editor has embedded media support. |
My computer appears to have a text editor with media support. It's called "Microsoft Word". It also lets you write your code in Comic Sans, which is really useful for professional enterprise-level SaaS codebases. |
Comic sans is pretty SaaSsy On Mon, Aug 8, 2016, 11:55 AM Daniel Lo Nigro notifications@github.com
|
This related issue gets way too few attention |
Thanks for the fix. |
@hzoo @loganfsmyth can we get out an emergency bug fix? My team is blocked on this |
TAKE ME TO FLAVOUR TOWN. MERGED VIA 033681a. |
@@ -30,6 +30,195 @@ export function Plugin(alias) { | |||
throw new Error(`The (${alias}) Babel 5 plugin is being run with Babel 6.`); | |||
} | |||
|
|||
// Sorry about all the MBs... | |||
/* eslint-disable max-len */ | |||
export const guy = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it's Babel Bulbasaur from SanFran Recruiting office. We saw this incredible Pull Request and want to offer you a full time job as a open source trainer. The job mainly consists of playing Pokemon and telling people that this practise is a good for having a strong codebase, please don't hesitate to contact us at: dontclosethisthread@sanfranrecruit.us
........................................................................................................... |
Well done 👍 |
👎 you missed a dot, please review before submission |
Fix exports of babel-core
Jokes are great (and I'm glad this was removed in #3646), but the fact that this was merged makes me seriously question the professionalism of this project's maintainers, considering how widely-used Babel is. |
@ultrafez All jokes aside. I would give the maintainers a little credit here - they know what they're doing, and they care deeply about their users. They're not going to cause anyone any harm for a joke. They just added a bit of flair to code that's never sent to the client, and I don't see anything particularly unprofessional about that. |
It has been removed from the codebase, it was a joke that was not part of any version release - end users will not be affected. I don't think it was ever the plan to incorporate this into any release. |
@ultrafez Thank you for your feedback, we take it very seriously and we'll continue to work to improve. Feel free to let us know if we're ever not meeting your standards in the future. It's our job to please you and if we ever fail to do that we want to hear about it. Your humble servant, |
No description provided.