Fix exports of babel-core by jamiebuilds · Pull Request #3641 · babel/babel

jamiebuilds · 2016-08-05T19:37:05Z

No description provided.

loganfsmyth · 2016-08-05T19:50:52Z

Needs more bytes, sorry. Can we add a linting rule for minimum file size?

hzoo · 2016-08-05T19:55:34Z

Needs some unit tests so we don't regress

samlecuyer · 2016-08-05T21:17:13Z

I hate to be that guy, but exports.guy was an Array in the article.

codecov-io · 2016-08-05T21:31:15Z

Current coverage is 88.13% (diff: 100%)

Merging #3641 into master will increase coverage by <.01%

@@             master      #3641   diff @@
==========================================
  Files           188        188          
  Lines         10924      10925     +1   
  Methods        1162       1162          
  Messages          0          0          
  Branches       2492       2492          
==========================================
+ Hits           9628       9629     +1   
  Misses         1296       1296          
  Partials          0          0

Powered by Codecov. Last update 154922c...f36d07d

mpj · 2016-08-06T11:59:01Z

Can you please extract this into a separate npm package? It seems like it could have general use.

kentcdodds · 2016-08-06T20:48:40Z

lol 😂

joshwiens · 2016-08-06T21:41:27Z

I agree with @mpj - This should really be extracted into it a plugin for Historical comedic value

This may turn out to be the greatest medium post of all time :)
I wonder if the Express/Loopback group is going to have the same sense of humor ...

amasad · 2016-08-07T00:20:40Z

Can you please use a gender neutral export name?

raabbajam · 2016-08-07T00:42:30Z

Can you please use a gender neutral export name?

Umm, did you just assume it's gender? Lol, jk. Guy is his name, though. Guy Fieri.
Also, yes please fix it as array.
This one is better:

import {guy} from 'babel-core';
const [GuyFieri] = guy;

amasad · 2016-08-07T01:07:49Z

His name is offending my taste buds

andreasklinger · 2016-08-07T23:27:42Z

"Hate to be that guy"… but specs are missing

stevemao · 2016-08-08T00:18:12Z

Please remove that guy :(

Daniel15 · 2016-08-08T05:44:38Z

This patch is insufficient. Here's the proper fix:

export const guy = [
'                                                                                                                                                                                                       
                                                                     `                  `                                                                                                               
                                                                         `              `   `                                                                                                           
                                                                    ``.```    . ``      `  `. `                                                                                                         
                                                                    ``````` ` ` `   ` . .  ``                                                                                                           
                                                                    ```. `.```.   ... ``..```` `                                                                                                        
                                                            `  `   `` .`.`` ..`.``....`.`.`....` .                                                                                                      
                                                            ` ..`  `. ..``.`....``....```.....``` `                                                                                                     
                                                      `    `.  ``.``.`.````.`.```...`.....``...````                                                                                                     
                                                          ` .  ...`,..`..```...``.````. `.```.`` .`                                                                                                     
                                                       .`  .````....`.````````````````````.````` ``                                                                                                     
                                                      . .` ``.`.`.``````````````````.``````````  `   `                                                                                                  
                                                     `.`` .```..`.````````````````````````````` `````                                                                                                   
                                                      `.` ...```.`````````````````````````````.``.`...                                                                                                  
                                                   ` ``..``````````````````````````````````````.`.``.`   `                                                                                              
                                                    ``````.`````````````````````````````````` ``..```  `.                                                                                               
                                                     ``..``````````````` .````````````````````.`..``` . `                                                                                               
                                               .`  `` .`.``.```.``````````.```````````````````.``...`.  `                                                                                               
                                                .``` .`.```````````````````````````````````````````.`. ``                                                                                               
                                               ` ```` ....````````````..````` ```````````````````````.`.  `                                                                                             
                                               ` ````..``````` ```````.`````` ````````` `````````..`..`.                                                                                                
                                              . ` `.  ``.```````````````````` ```.````` `````.```.``..`. .                                                                                              
                                               ` ``` `````` ``````````.``````````.````````.``.```.``..`.```                                                                                             
                                              `` ``.   ````````` ``````````````..`````````.```. `````.`..``                                                                                             
                                             `````.` ` ``````````.` ` ````````````````.` `.``.`````````. `.                                                                                             
                                             `   `.`  `````` ````.```````````````.`.```````````````````.``.`                                                                                            
                                           ```   `.````````` ``` ``````````````````````````````````````...``                                                                                            
                                            ```    `.`````` `````````.``````.````.``````````````````````.``.                                                                                            
                                            `.` `.`  ````````````.````````.`````````````````````` ````````.`                                                                                            
                                             ` ` ```   ``` ```  `.``````````.```.`..``..``.``````  `````.`..                                                                                            
                                              ``````. `````` `` ``````.``.``.`````..``````.````.`` ``````... `                                                                                          
                                              ```````..```````` ````.`.```````````..````````.```````````..``                                                                                            
                                              `.````` ` ````` `  `````.``.``````....``````.`.`..````````.```..                                                                                          
                                              `````.````  ``` ``  ````````.````.``..`.` ````.`.``.`````````.``                                                                                          
                                           ` `` `.`.`` `     ` ` ```.`````````````.``.``.`.`...``....``````.` `                                                                                         
                                             ``..```````` ` `. ``````...`````````````.`.`.`.....,,....````..`                                                                                           
                                            `.`,``````.```   `` ` .```..`````````.```````..,,...,,,,...```````                                                                                          
                                            `.`.`` ```````   ``````.`````````````````..`........,,,,...`````.````                                                                                       
                                             `.``.```````` ` ``.`..``.`....````````............,,,,,,..`````.                                                                                           
                                           ` ...`````````` `````.`.......`````````..`..`.......,,,,,,.`..`.`. `                                                                                         
                                            ``..`````````````.`..........`````````````........,.,,,,,........`                                                                                          
                                            ``````````````````.............````````````........,,,,,,.`.......                                                                                          
                                            .````. ``` `` `.....``.......`.````````````........,,,,,,,.....`.`                                                                                          
                                            `` `` ```` `````.............``````````````.......,,,,,,:,.......``                                                                                         
                                             ``.``  ``` ````................``````````.......,,,,,:,,,...`...`                                                                                          
                                           ` .`````  ``.````................`````````........,,.,,:,::,......`                                                                                          
                                           ``````````` `````.................```````.........,,,,,:,,:..`..,.`                                                                                          
                                            ```.``````` ```....................```..........,,,,,,,,::,.`.....`                                                                                         
                                            . `.``````..````.......,............``.........,,,,,,,,,,:,...,...                                                                                          
                                            `.  ``````.`.````.,.............................,,,,,,,:,:,....,..`                                                                                         
                                             `. `````..`.````.,...,........................,,,,,,,,,,::,...,..                                                                                          
                                            ``.``````....```..,,.,,,,......................,,,,,,,,,:::,,.,,.`                                                                                          
                                            `````````.``.```...,.,,,,,....................,,,,,,,,,,,::,,,.,,`                                                                                          
                                             `.``.`.``..``.....,.,..,,,....................,,,,,,,,,,:::,.,.,,                                                                                          
                                             .```.`..``.```.``.,.,,.,,,,,..................,,,,,,,,,,:::,,.,,`                                                                                          
                                            ` .```.........``..,,,,,,,.....................,,,,,,,,,,:::,,..,`                                                                                          
                                            `` `.````,`,`.```..,,,..,,,.......................,,,,,,,,:::,..,                                                                                           
                                             `````````.`..``...,,,.,,,........................,.,,,,,,:::;,.,.                                                                                          
                                             .`....````,..`.`.,,,,,,,,,........................,,,,,,::::',.,.                                                                                          
                                             ```.... ``.`..`.`,,,,,,,,.,.......................,,,,,,::::;:,,.                                                                                          
                                             ```.,..` ```.. `..,,,,,,,,.,......................,,,,,,,:::;;,:;.                                                                                         
                                             ``...,,,..``.`.`..,,,,,,,,.......................,,,,,,,:::::;,.;`                                                                                         
                                              ````,,.,,..`.`...,,,,,,,,..........`..........,,,,,,,,,,::::;,.:`                                                                                         
                                               `.``...`..```.`.,,,,,,,,....................,,,,,,,,,::::::;:,;.                                                                                         
                                               `.``.`.,``...`.,,,,,,,,,...................,,,,,,::;;;';;::::,;,                                                                                         
                                               ......`````...,:,,,,,,,,,..............,,,,,,:::'''''''''::::,:,                                                                                         
                                               `.....,.......,,,,,,,,,.,,......,,...,,,,,,::;;'++++++''';:::,,,                                                                                         
                                              `..````.......,:,,,,,,,,..,..,...,,,,,,,,,,,:;'++##++''';;;:::,,.                                                                                         
                                                ..``..`..,,:,,,,,,,,,,...,,,..,,:,,,,,,,,,:;'+++'';;;;::;::::.`                                                                                         
                                               `..,.`..,..,,:,,,,,,,,,,,.,,,::::::::,::,,:;'''';;;;;;;:::::::,`                                                                                         
                                               `.,,..,,,...:,,,,,,,,:,::::;;''';;::::,::::;;'''+####++;::::::,`                                                                                         
                                               ``.,:,,,.`..,,,,,,,,,::;;;''+++''';;::,,,,:;''++#@@@####;:::::,.`                                                                                        
                                                .,:;,,,,.:.:,,,,,,,:;''''++++++';;;::,,,:;'+'''@'@@#+++';::::,,                                                                                         
                                                ..';',,.:.,,,,,,,,:;;'''+''+';;;;;;;:,,,:;'+'###+';'';;'::,:::.                                                                                         
                                                 `:::;:,,...,,,,,,;;'''';;:;;;;;;;;;:,..,;+##';;:;;;::::::,,::`                                                                                         
                                                 ,::,,::....,.,,,,;;;;;;:::'#++;;;;;:...,;++';;:::::::;:,:,::;`                                                                                         
                                                 ,;;:,,.....,,.,,:;;;;:;;+@@@'+'';;':.`.,:''';:::::::;:,,,,::;                                                                                          
                                                 .;;':::....,,,,,:;;;;;+##@@#+###'';:.`..,;;;;;;;;;;;;:,,:,,:;                                                                                          
                                                 `;;+':,....,,..,:;;;;###@+#+'';;:;::.`..,,;:::;;;;;:.,,:,:::;`                                                                                         
                                                  ;;'';,,....,,,,,:;;+++';::;;::;;;,:....,,,::,,,:,,...,,::::;,                                                                                         
                                                  :;;'',..,...,,,,:;;;,:,,:,::;;;::,,......,:,,,.......,,,::,;:                                                                                         
                                                  :';;':....,,,,::::;:,,,,,,:;;;:::,.....,.,,,,........,,,::,;:                                                                                         
                                                  .;:;;:.,,,,,,,,:,.,,:,,:::;;::,:,,......,,,,,........,,,,:,;:                                                                                         
                                                   :;;;;,..,,,,,,...,.,:::;;;;:,,,,...``..,..,,........,,,,:,;:                                                                                         
                                                   :;;::,,,,,,,,,..,.,,::;;::,.,,,,...```..,,:,,........,,,,,:;                                                                                         
                                                   .:::;:.:,,,,,,,,.,,............,..`.``.,,:;:,,.......,,,,,:;                                                                                         
                                                    ,:::;:,:,,,,,,,.....``.`.........````..,;'';,......,,,,,,,:                                                                                         
                                                    :;,:;::,,:,,,,......````.`....,,,.```..,;;'',,,,,,.,,,,,,,'                                                                                         
                                                    ,:.:;:::,,,,,,.....````````...,:,,````.,;,,#':,,,,,,,,,,,,.,                                                                                        
                                                     ,,:;:;:::,,,,,....`````````.,:::,.```.,,.,:+;:,,,,,,,,,,,.,                                                                                        
                                                     ,:,,::::,:,,,.....````````.,:,,:,..``..,..,'';:,,,,:::,,:,`                                                                                        
                                                     ,,:,:::::,,,,......``````..::...,..``..,,,,'';;,,:,:::,::,`                                                                                        
                                                     ,.:,,::::,,,,.............,;:......```.,,,,''';:,::::::::,,                                                                                        
                                                      ,.,,::::,,,,............,:;:......``..,,,,''';::::::;::::'                                                                                        
                                                      ,..,::::,,,,,..........,:;::.........,,.:#''';;:::;;;;;;;`                                                                                        
                                                      ,.,,:::,,,,,..........,:;;::,,,,,...,,:;##';'+;:::;;;;;;:                                                                                         
                                                      `..,::::,,,,,,,.......::;;:::::::,,,,:;###':;+':::;;;;;;:                                                                                         
                                                       ..,::::,,,,,,,,,....,:;';::''';:::::;'##+;';'+;::;;;;;;:                                                                                         
                                                       :,,:::,,:,,,,,,,,...,:;;:::;'++';;;;;##+#''+++;;;;;;;;;,                                                                                         
                                                        ,,:::,,,:,,,,,,,,,,:;';;:;;+##++'''###++++'++';;;;;;;;.                                                                                         
                                                       `.:::::,:,:,::,,,,,::;';;;;;'+#+##++###++''++++;:;;;';;`                                                                                         
                                                       . `,:::::::::::::,,::;'';;;;'++++#+'+#+++':'+++;::;;;;;                                                                                          
                                                       ,  '::::::::::::::::;'''';;;''+++##'++'+';;++++;::;;;;'                                                                                          
                                                       :  +:::::::::;::::::;'+';;';'+++++++++''''#+'++;:;;;;;'                                                                                          
                                                       .  +:;::::::;:::;::;'+++''';'''+'++';;'';@#++++::;;';;:                                                                                          
                                                        :.+;;;:::::::;;:::;'+++''':;;;'';;;'';,;@#++++;:';;;'`                                                                                          
                                                        ,::;;;::;:::::;:::;++++''';;;;;;''';;::@##+'++;:;';;'                                                                                           
                                                         ':;;;;;;:;:;;;:::;+++#@;,,:,,,,.:.,::@@#+';'+:;;;;;'                                                                                           
                                                         #@';;;;:::::::;:::'+#+#@;,,.,.,`:,,'#@#+';;'+;;;;;',                                                                                           
                                                         +#:;;;;;;::::;::::;++'##@@#+#::.,'#####+';;'+'';;;'                                                                                            
                                                         ;@,;;;;;;;::;;:::::++';+#####++######++';;;;+''';;'                                                                                            
                                                         #@;';;;;;;::::::,,:;+;::'+##++++#+'#+'';;;:;++';;;,                                                                                            
                                                        `##@+;;;;;;::::;::,,;+::::;;'++''+++'';;;;;;;++'';;#@+                                                                                          
                                                        .;@#:';;';;:::::::,,;+;::,:::;;;'';;::;:;;:;;++';''@@@@@@@:`                                                                                    
                                                        ,+@@,';;;;;;::::;:,,;+;,,,,::,.,::,,:;;::::;;++';;'@@@@@@####@#;,;,`                                                                            
                                                        ,+#@+';;'';;;:::::::;+;:,::,::,,..,::;;::::;'++';;'@@@@@@@@@@#######@@@:`                                                                       
                                                        ,+###,';;'';;::::::,:+::,,::,::,,,,::;::::::;++';;'#@@@@@@##@##@@@@######@:`                                                                    
                                                        .+;##:';;'';;;::::::;+',,,:::,,,,,:::;,:::::'++';''@@@@@@@@###@#############@;  `                                                               
                                                        .'+#@#;;;;;;;;::::;::+':,,,,::,,,:,::,:,,:::'+#;;;'@@@@@@@@#####################@@                                                              
                                                        .':;@#,';;'';;:::;:::+'::,,,:::,,::,,...,,::'+#;;;'@@@@@@@@#######################@                                                             
                                                        `+@;+##'';;;;;:::::;;+'::.,,,,..,,,...,,,:::'+#';;'@#@@@@@#@#######################@                                                            
                                                        ;#@#'#@:';;;;;;;::::'+':,,,,,,....,....,,,::'+#';;'@#@@@@@#@########################+                                                           
                                                       ',+##+'@#:';;;;;:::::;++:,,,,,..,....,...,:,;'+++;;'@+#@@@@@@@########################'                                                          
                                                      `#;+#+#++#++;;;;;::::,;#'',...,...,,,..,`.,,:;++#+;;'@##@@@@###@########################'                                                         
                                                      ###:#'#+;@':+;;;;;::::;++':,.............,,,,;'###;;'@##@@@@@##@#########################'                                                        
                                                     #### #'##+@@',';;;;:::::#+;:,,.......`....:,.:;+##+';'@#@@@@@@###@#########################+                                                       
                                                    :####+:+@#+###+:;;;;;::,;+++;,,.,`,....`...,:,:'+#++;;+##+@@@@@##############################+                                                      
                                                    ###### ##'###@##;;;;;:::'##+':,,...`....,,.,:,;;###+';#:@##@@@@###############################+                                                     
                                                   +#######,#@###@@+#;;;;;:::+#+'::,..,,...,..,:::;'#+++';+:##+#@@@#################################                                                    
                                                  .########.#@###@@#'@;;;;;;;+##+;::,.,,.,..,,.,:;;+#+##+'+#+@'#@@@##################################                                                   
                                                  ########## @#@#@@##'@;;;;'++#++';;:,,,,,,,,,:,:'+##+#+''##,@;@@@@##################################.                                                  
                                                 ############,@###@@#++#;;;;'####''';:,,,,.,.,,:;'++###'';#@,#'@@@@@##################################                                                  
                                                .###########'.#####@##+##;'+######++';;,,.,,.,.;;'+#++''';#@;+@@@@@###################################.                                                 
                                                @##########';;`#@##@@##'@#'+#####+##+';;,,,,,,.;+++++'''';#@@;+##@@####################################;                                                
                                               ###########+;;;;;####@#''#@##########+#+':,.,:,,;++#+''''''+@@,#+#@@####################################@.                                               
                                              +##########+;;;;;;#@###@+''##############;;:,.::::+#''''''''+##:#;#@@####################################@#                                               
                                             :###########;;;;;;;;@###@@+'@@###+#+######'',,.:,;:++';'''';++@#+;:@@@@###################################@#,                                              
                                             ###########;;;;;;;;;;##@#@#'###@@#+++###+++'::,,,'';''''''''++#++.:#@@#######################################                                              
                                            +##########+;;;;;;;;;;:#@#@@++##@@@#@++####+';,,,,,;''''''''++'#;;@;@@########################################                                              
                                           `########+##;;;;;;;;;;;';###@#+##@@@@@;+';'+++;:,.,,;'''''''+++'##;#'@#@####################################@##                                              
                                          `###########+;;;;;;;;;;;;:'#@#@#+#@@@@@:#';;;;';:,,,:''''''''++''+#:####@####################################@##                                              
                                         .############;;;;;;;;;;;;;;,+#@###+@@@@@;#+';''';;;:,:''+''+'+++'++@@'###@#######################################,                                             
                                        `###########+';;;;;;;;;;;;;;;,'##@###@@@@#++'''''';,:,;'++++++++'''+#;;@##@@######################################@                                             
                                        ##########++#;;;;;;;;'';;;;;;','#@@###@@@@'#+''''';:::++++++++++'+'+;:,@##@########################################,                                            
                                       +############;;;;;;;;;''';;;;;;'.:#@###@@@@:#++''''';:+'####++++++'''#+.###@@######################################++                                            
                                       #########@###;;;;;;;;;;''';;;;;'',,#@###@@@:#++++++++##########+++'';+':#@#########################################+'.                                           
                                      '##+######@@@#;;;;;;;;;;;''';;;;;';,`#####@@'##+++++###########+++''';+:;@##@########################################''                                           
                                      ####+#######@#';;;;;;';;;;''';;;;;'':`##+#@@#+#################+++'';;#'########################################@#####'                                           
                                     :##############'';;;;;;;';;'''';;;;''';`:#+##@;#################++''';;+'###############################################:                                          
                                     ###########+###;'';;;';+;::,;''';;;;''''.`@##@,@##@@@@@@#########++';;;;,@######################################@#######:                                          
                                    #########+#+##++;'';;';;;''';;;''';;;;'''';`.@+.@@#@@@@@@@#######++''';;',###############################################+.                                         
                                   `#########++####;;;'+';;'';:;';'##+';;;'''''';`.,@@@@@@@@@@######+++'';;;+;################################################.                                         
                                   ###########+++#';;;;'';;;#':+,';+#'+';;;''''''';.`#@###@@@@######+++';;;;'#################################@###############'.                                        
                                  ;#############'';;;;;;;;;'+++;:+;,+#'';;;;''''''''+:`:+@##########++''';;;,@################################################+.                                        
                                  #############;;;;;;;;;;;;:'#+++;',,:#''';;'''''''''''+':,:+#@#####++'''';;.@###############################################'+'`                                       
                                 #############;;;;;;;;;;;;;;;+#;+++';;;++';;;''''''''''''++++;,;@##++''''';;:@################################################''`                                       
                                .##########+#;;;;;;;;;;;;;;;;;#;+'#+';'#'+';;;''''''''''''''++++'.'++''''';;'@################################################;'`,                                      
                                ###########++;;;;;;;;;;;;;';;;'+'++';,;'#''';;;'''''''''''''''+++++::'''';';#@##################################@####@########''`;:                                     
                               ;#########@##;;;;;;;;;;;;;;;';;'+#+###'::;'+';;;''''''''''''''''++'''+::'';;,@##################################@##############+''. `                                    
                               #####@@###+#;;;;;;;;;;;;;;+:+++''#####++::''+';;;''''''''''''''''''''''':;;;.###################################@@##############'''.                                     
                              '###@@######';;;;;;;;;;;;;;#+##+''######'+;'++'';;;;''''''''''''''''''''''':'.#@@################################@@##############'''+@.                                   
                              ###@@#######;;;;;;;;;;;;;;;;+##+''#######+':''+';;;;'''''''''''''''''''''''+:,##@################################@@##############+''+;,                                   
                             '#@@####@@@@@;;;;;;;;;;;;;;;+++''+++###+;;#++:;''';;;;;''''''''''''''''''''''+;#@@################################@@###############''';'                                   
                             #@########@@@#;;;;;;;;;;;;;;'''''#++++#++@;+++;:+';;;;;''''''''''''''''''''''+'@@#################################@@################'#+#`                                  
                            ,@@###########@+;;;;;;;;;;;;;;;;;++'+++;:#'#;'++;'+';;;;;;'''''''''''''''''''''##@#################################@@#################++#:                                  
                            #@#############+';;;;;;;;;;;;::::;+'+++;,#+#'++';''';;;;;;;''''''''''''''''''+;##@#################################@@##################'''                                  
                            @#############;;;';;;;;;;;;;;:::;+##'+';;+#@+@+#:;''';;;;''''''''';''''''''''':##@##################################@###################''                                  
                           +##############;;;;';;;;;;;;;;:::,'###'+;''++@#+##;''';;;;''''''''';;''''''''''.##@##################################@#################@#+'.                                 
                           @##############;;;;;';;;;;;;;;:,::;###++;':'+';++##;''';;;''''';;''';';''''''''`##@##################################@################@###';                                 
                          ;##############+;;;;;;;;;;;;;;;::,,;+####'',''+##+#';;'';;;;''''';''';;;''''''''`##@##################################@#############@##@####'                                 
                          @#############++;;;;;;'';;;;;;;:,,,:'##+#'+''''+#+#+;;;+';;;''''';;'';;;''''''''.##@@#################################@###############@#####+,                                
                          ###############';;;;;;;';;;;;;;:,:,,;++'###+:'''#;###;;'+;;;;;'''';;;;;;'''''''',#####################################@@##@##########@@######'                                
                         :##############+;;;;;;;;;';;;;;;:,,,::+#@####;'''';##+;;'+';;;'''''';;;;;'''''''''###@##################################@##@##########@########                                
                         @###############;;;;;;;;;;';;;;;;;::,,;+###'#+,'';'##+;;;'+;;;;;'''''';;;''''''';+###@##################################@##@#########@@########:                               
                         ################;;;;;;;;;;;;;;;;;#;:,,:+##+@##;'+:''#;';;''';;;''''''''''''''''',####@##################################@##@########@@##########                               
                        `###############+;;;;;;;;;;;';;;;;;;':,,;+##+;##';+'',#;;;;'+;;;;''''''''''''''''.####@##################################@##@########@###########                               
                        ,#############+#+;;;;;;;;;;;;';;;;'#:;,,:;##;####+'+''++:;;''';;;;;'''''''''''''' #######################################@##@#######@@###########,                              
                        ###############';;;;;;;;;;;;;;';;;;'#'';;#':'#;##+++'',+;;;;'+;;;;;''''''''''''''`#######################################@##@#######@############'                              
                        @##########@;;;;;;;;;;;;;;;;;;;';;;''+':::'+#:@###++;+;'';;;''';;';'''''''''''''':#####@#################################@#@#######@############+;                              
                        ##########+;;;;;;;;;;;;;;;;;;;;';;;';,:',;#+#++'###+:'';;';;###;;;;';''''''''''';'#######################################@@@####################+',                             
                       `########@'';;;;;;;;;;;;;;;;;;;;;';;:';;;:#+;';'@+@#++;+::;;;@##';;;;;''''''''''':######@#################################@#@######@##############'+                             
                       ;#######@;;;;;;;;;;;;;;;;;;;;;;;;;';;:'''''##'#+,#'';+:'+':;;+##+;;;;;'''''''';''`######@#################################@@@@####################'+                             
                       @#######;'';;;;;;;;;;';';;;;;;;;;;';;',;,+,;###;+;####+'+':;'+##+';;;''''''''''''`######@#################################@@@#####################';`                            
                       #######;;'';;;;;;;;;;;'''';;;;;;;;'';',,'':'+###;@:##;;++::;+###++;;;''''''''''''.#######@################################@@@######################;:'
]

kaelig · 2016-08-08T06:10:31Z

jordanbuchman · 2016-08-08T18:47:11Z

Porting to TempleOS may be sufficient, as its text editor has embedded media support.

Daniel15 · 2016-08-08T18:55:01Z

its text editor has embedded media support.

My computer appears to have a text editor with media support. It's called "Microsoft Word". It also lets you write your code in Comic Sans, which is really useful for professional enterprise-level SaaS codebases.

amasad · 2016-08-08T18:58:34Z

Comic sans is pretty SaaSsy

On Mon, Aug 8, 2016, 11:55 AM Daniel Lo Nigro notifications@github.com
wrote:

its text editor has embedded media support.

My computer appears to have a text editor with media support. It's called
"Microsoft Word". It also lets you write your code in Comic Sans, which is
really useful for professional enterprise-level SaaS codebases.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3641 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAj2_oLe0aHkmIuKT-hy0uIhwBpOozdiks5qd3uZgaJpZM4Jd_yQ
.

valioDOTch · 2016-08-08T22:38:06Z

This related issue gets way too few attention
defunctzombie/node-yummy#7

Daniel15 · 2016-08-09T00:34:55Z

Thanks for the fix.

jamiebuilds · 2016-08-09T00:51:44Z

@hzoo @loganfsmyth can we get out an emergency bug fix? My team is blocked on this

sebmck · 2016-08-09T00:55:41Z

TAKE ME TO FLAVOUR TOWN. MERGED VIA 033681a.

evenstensberg · 2016-08-09T00:56:02Z


+// Sorry about all the MBs...
+/* eslint-disable max-len */
+export const guy = [


Hi, it's Babel Bulbasaur from SanFran Recruiting office. We saw this incredible Pull Request and want to offer you a full time job as a open source trainer. The job mainly consists of playing Pokemon and telling people that this practise is a good for having a strong codebase, please don't hesitate to contact us at: dontclosethisthread@sanfranrecruit.us

c9s · 2016-08-09T04:52:28Z

...........................................................................................................

darthrodolfo · 2016-08-09T11:45:05Z

OlegLustenko · 2016-08-09T15:14:18Z

Well done 👍

hemanth · 2016-08-09T17:23:20Z

atticoos · 2016-08-09T18:12:53Z

👎 you missed a dot, please review before submission

nickzuber · 2016-08-09T18:16:36Z

dncrews · 2016-08-09T20:19:58Z

This reverts commit 033681a, reversing changes made to a2d66c0. I brought you into this world, and I can take you out.

Fix exports of babel-core

This reverts commit 033681a, reversing changes made to a2d66c0. I brought you into this world, and I can take you out.

ultrafez · 2016-08-15T17:35:38Z

Jokes are great (and I'm glad this was removed in #3646), but the fact that this was merged makes me seriously question the professionalism of this project's maintainers, considering how widely-used Babel is.

jdan · 2016-08-15T17:49:51Z

@ultrafez All jokes aside. I would give the maintainers a little credit here - they know what they're doing, and they care deeply about their users. They're not going to cause anyone any harm for a joke. They just added a bit of flair to code that's never sent to the client, and I don't see anything particularly unprofessional about that.

atticoos · 2016-08-15T17:52:00Z

It has been removed from the codebase, it was a joke that was not part of any version release - end users will not be affected. I don't think it was ever the plan to incorporate this into any release.

jamiebuilds · 2016-08-15T22:26:10Z

@ultrafez Thank you for your feedback, we take it very seriously and we'll continue to work to improve. Feel free to let us know if we're ever not meeting your standards in the future. It's our job to please you and if we ever fail to do that we want to hear about it.

Your humble servant,
James Kyle

jamiebuilds added 2 commits August 5, 2016 12:36

Fix exports of babel-core

fd89bd1

Fix lint

9eb12e2

hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Aug 6, 2016

hzoo added this to the Next Patch milestone Aug 6, 2016

Fixes from PR comments

f36d07d

jamiebuilds self-assigned this Aug 9, 2016

Remove unnecessary import

10f4546

sebmck closed this Aug 9, 2016

sebmck deleted the guy-fieri branch August 9, 2016 00:55

evenstensberg reviewed Aug 9, 2016
View reviewed changes

jdan added a commit to jdan/babel that referenced this pull request Aug 9, 2016

Revert "Merge pull request babel#3641 from babel/guy-fieri"

7dabeb4

This reverts commit 033681a, reversing changes made to a2d66c0. I brought you into this world, and I can take you out.

d4rkr00t pushed a commit to d4rkr00t/babel that referenced this pull request Aug 9, 2016

Merge pull request babel#3641 from babel/guy-fieri

033681a

Fix exports of babel-core

hzoo pushed a commit that referenced this pull request Aug 15, 2016

Revert "Merge pull request #3641 from babel/guy-fieri" (#3646)

ca27cf1

This reverts commit 033681a, reversing changes made to a2d66c0. I brought you into this world, and I can take you out.

babel locked and limited conversation to collaborators Aug 15, 2016

Uh oh!

Uh oh!

Conversation

jamiebuilds commented Aug 5, 2016

Uh oh!

loganfsmyth commented Aug 5, 2016

Uh oh!

hzoo commented Aug 5, 2016

Uh oh!

samlecuyer commented Aug 5, 2016

Uh oh!

codecov-io commented Aug 5, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 88.13% (diff: 100%)

Uh oh!

mpj commented Aug 6, 2016

Uh oh!

kentcdodds commented Aug 6, 2016

Uh oh!

joshwiens commented Aug 6, 2016

Uh oh!

amasad commented Aug 7, 2016

Uh oh!

raabbajam commented Aug 7, 2016

Uh oh!

amasad commented Aug 7, 2016

Uh oh!

andreasklinger commented Aug 7, 2016

Uh oh!

stevemao commented Aug 8, 2016

Uh oh!

Daniel15 commented Aug 8, 2016

Uh oh!

kaelig commented Aug 8, 2016

Uh oh!

jordanbuchman commented Aug 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel15 commented Aug 8, 2016

Uh oh!

amasad commented Aug 8, 2016

Uh oh!

valioDOTch commented Aug 8, 2016

Uh oh!

Daniel15 commented Aug 9, 2016

Uh oh!

jamiebuilds commented Aug 9, 2016

Uh oh!

sebmck commented Aug 9, 2016

Uh oh!

evenstensberg Aug 9, 2016

Choose a reason for hiding this comment

Uh oh!

c9s commented Aug 9, 2016

Uh oh!

darthrodolfo commented Aug 9, 2016

Uh oh!

OlegLustenko commented Aug 9, 2016

Uh oh!

hemanth commented Aug 9, 2016

Uh oh!

atticoos commented Aug 9, 2016

Uh oh!

nickzuber commented Aug 9, 2016

Uh oh!

dncrews commented Aug 9, 2016

Uh oh!

ultrafez commented Aug 15, 2016

Uh oh!

jdan commented Aug 15, 2016

Uh oh!

atticoos commented Aug 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamiebuilds commented Aug 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

codecov-io commented Aug 5, 2016 •

edited

Loading

jordanbuchman commented Aug 8, 2016 •

edited

Loading

atticoos commented Aug 15, 2016 •

edited

Loading