Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newlines before the update suffix operator in babel-generator #6259

Merged
merged 1 commit into from Sep 17, 2017

Conversation

@zestime
Copy link
Contributor

zestime commented Sep 17, 2017

Q A
Fixed Issues Fixes #6253
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added/Pass? y/y
Spec Compliancy?
License MIT
Doc PR
Any Dependency Changes? n

I added .startTerminatorless(true) and .endTerminatorless() at UpdateExpression. And I also added a test using obj.foo/*comment*/++;

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Sep 17, 2017

@zestime, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kittens, @loganfsmyth and @amasad to be potential reviewers.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Sep 17, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4939/

@loganfsmyth loganfsmyth merged commit f5ad86c into babel:master Sep 17, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.35% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth

This comment has been minimized.

Copy link
Member

loganfsmyth commented Sep 17, 2017

Thanks!

@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.