Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editorconfig for Makefile #9623

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add editorconfig for Makefile #9623

merged 1 commit into from
Mar 4, 2019

Conversation

danez
Copy link
Member

@danez danez commented Mar 2, 2019

Q                       A
License MIT

I guess most editors know that Makefiles are tabs-based, but to be completely sure.

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Mar 2, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10360/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor doesn't know

@danez
Copy link
Member Author

danez commented Mar 3, 2019

Which editor are you using?

@nicolo-ribaudo
Copy link
Member

VSCode. I can probably set it up, but it doesn't work out of the box (I'm too lazy and I have being copy-pasting tabs)

@danez
Copy link
Member Author

danez commented Mar 4, 2019

Weird my vscode automatically uses tabs in the Makefile.

@danez danez merged commit 38ef4b7 into babel:master Mar 4, 2019
@danez danez deleted the editorconfig branch March 4, 2019 22:26
Copy link

@tompop1777 tompop1777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tompop1777
Copy link

Q                       A
License MIT
I guess most editors know that Makefiles are tabs-based, but to be completely sure.

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants