Check if result is null #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may be the case if files are ignored. I do not know what the other cases are, and if they should be handled differently, but at least they don't cause error like this. See babel#265
larsgw
added a commit
to larsgw/citation.js
that referenced
this pull request
May 2, 2018
* [site:test] Fix browser tests again expect.js doesn't play nicely with Babel, so it shouldn't be transformed by Babelify.^1 Note that the ignore option in Babelify is buggy ^2, so this might not work on your end. ^1 Automattic/expect.js#149 ^2 babel/babelify#265 * [test:input] Set up HTTP request mocking Set up proper HTTP request mocking by mocking exports with mock-require. Not possible in the browser, but it wasn't before, so this counts as an improvement. Previously done by nock, but this didn't work for requests made through sync-request, as that spawns a child process over which nock has no control. See #68 See 509d911 Close #134 * [test:input] Increase coverage of input plugins See #123 * [package] Add non-npm patch to dependencies See babel/babelify#267
larsgw
added a commit
to citation-js/citation-js
that referenced
this pull request
Nov 24, 2018
* [site:test] Fix browser tests again expect.js doesn't play nicely with Babel, so it shouldn't be transformed by Babelify.^1 Note that the ignore option in Babelify is buggy ^2, so this might not work on your end. ^1 Automattic/expect.js#149 ^2 babel/babelify#265 * [test:input] Set up HTTP request mocking Set up proper HTTP request mocking by mocking exports with mock-require. Not possible in the browser, but it wasn't before, so this counts as an improvement. Previously done by nock, but this didn't work for requests made through sync-request, as that spawns a child process over which nock has no control. See #68 See 509d911836c7cb7adbc57440ce21a703308e01ff Close #134 * [test:input] Increase coverage of input plugins See #123 * [package] Add non-npm patch to dependencies See babel/babelify#267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be the case if files are ignored. I do not know what the other cases are, and if they
should be handled differently, but at least they don't cause error like this. The two failing tests are failing because of unresolved issues concerning source maps, and should be unrelated to this edit.