This repository has been archived by the owner on May 19, 2018. It is now read-only.
Adjust cloning of nodes in import/export-specifiers and obj-destructuring #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
changed the title
|
👍 |
|
Can we make |
…ring The cloning caused comments that where added to the original node to be persisted into the cloned node. Espree/Acorn does not have any cloning, that's why it is working there. This change adds a parameter to omit comments when cloning, as removing the cloning causes tests in babel to fail.
|
Ok I changed it so that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloning caused comments that where added to the original node to be persisted into the cloned node. And this later on causes problems in babel-eslint/eslint see babel/babel-eslint#163
Espree/Acorn does not have any cloning, that's why it is working there.
This change adds a parameter to omit comments when cloning, as removing the cloning completely
causes tests in babel to fail.