This repository has been archived by the owner on May 19, 2018. It is now read-only.
Disallow import type { type a } from '' #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 97.27% (diff: 100%)@@ master #305 diff @@
==========================================
Files 21 21
Lines 3999 4000 +1
Methods 489 469 -20
Messages 0 0
Branches 1169 1191 +22
==========================================
+ Hits 3890 3891 +1
Misses 49 49
Partials 60 60
|
|
Yes this invariant is correct, I must've overlooked it. Thanks for the follow-up! |
jeffmo
reviewed
Jan 17, 2017
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm probably just not familiar with how the test runner/fixtures work, but shouldn't this output have 2 throws (one for each line)?
There was a problem hiding this comment.
You are right, babylon throws at the first error, and never parses the second line. I extracted that in a second test.
| @@ -1223,6 +1223,10 @@ export default function (instance) { | |||
| specifier.local = specifier.imported.__clone(); | |||
| } | |||
|
|
|||
| if (node.importKind !== "value" && specifier.importKind !== null) { | |||
There was a problem hiding this comment.
Per this discussion with @loganfsmyth, I guess this should stick to explicitly listing out "type" and "typeof"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that flow was failing, but babylon parsed it just fine.
@jeffmo Can you confirm that this is correct?