This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix flow test runner #680
Merged
Fix flow test runner #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has two reasons:
- The object was actually used as a map
- Using an object leads some problems with the
private_class_fields/constructor.js test, since
`tests[test_name] || {}` returned the Obejct
constructor instead of an empty object.
existentialism
approved these changes
Aug 30, 2017
jridgewell
approved these changes
Aug 31, 2017
danez
approved these changes
Aug 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Babylon is tested using the flow parser test suite, but:
I have added a
flow_tests_whitelist.txt, which declares expected failures (like it was done for Test262 – #654)Since
run_flow_tests.jsnow has several code very similar to the Test262 runner, I could extract it in a genericExternalTestsRunnerutility, but I'd prefer to do that in a different PR to keep things simple.