This repository has been archived by the owner on May 19, 2018. It is now read-only.
Comment node loc.filename #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was actually @loganfsmyth's, but I've confirmed that it resolves the issue I was experiencing. When specifying multiple input source files to
babel-generator, an invalid mapping error would occur due to a missingfilenameproperty in comment nodes'loc. This change attaches thefilenamevalue if provided.There is one failing test in master, as well as in this branch. Looks like the issue is fixed in #76.
/cc @loganfsmyth