This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix accidental fall-through in Flow type parsing. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -505,6 +505,8 @@ pp.flowParsePrimaryType = function () { | |||
| node.returnType = this.flowParseType(); | |||
|
|
|||
| return this.finishNode(node, "FunctionTypeAnnotation"); | |||
| } else { | |||
| this.unexpected(); | |||
There was a problem hiding this comment.
This is just minor and makes not a big difference, but maybe adding here just a break and then it would call this.unexpected() on line 395
There was a problem hiding this comment.
Sure, that works, too. I've amended the commit.
|
Good catch. I wonder if we have the same problem with |
Current coverage is 96.91% (diff: 100%)@@ master #82 diff @@
==========================================
Files 19 19
Lines 2913 2914 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2823 2824 +1
Misses 90 90
Partials 0 0
|
|
That certainly also looks suspicious, but I wasn't immediately able to construct an example (I'm new to Babylon). |
When parsing a primary type, `>` would erroneously be treated like `(`.
xiemaisi
force-pushed
the
fix-accidental-fallthrough
branch
from
820f474
to
2bebe36
Compare
|
Yes I also couldn't figure out an example. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a primary type,
>would erroneously be treated like(. For example,>x:int) => stringwas parsed the same as(x:int) => string.