This repository has been archived by the owner. It is now read-only.

Fix declare class with qualified type identifier #97

Merged
merged 1 commit into from Aug 23, 2016

Conversation

Projects
None yet
3 participants
@danez
Copy link
Member

danez commented Aug 19, 2016

This makes declare class extends behave the same way as in flow.
The ast-token after the extends keyword, might be either Identifier or QualifiedTypeIdentifier.

declare class a extends b.c.d {}

To do that this change splits the parseGenericType into two functions, one for parsing genericType and on for qualifiedTypeIdentifier

Fixes #87

Daniel Tschinder
Fix declare class with qualified type identifier
This makes declare class extends behave the same way as in flow
The ast-token after the extends keyword, might be either Identifier or
QualifiedTypeIdentifier

To do that this commits splits the parseGenericType into two functions,
one for parsing genericType and on for qualifiedTypeIdentifier

@danez danez added the Tag: Bug Fix label Aug 19, 2016

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 19, 2016

Current coverage is 96.92% (diff: 100%)

Merging #97 into master will increase coverage by <.01%

@@             master        #97   diff @@
==========================================
  Files            19         19          
  Lines          2922       2927     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2832       2837     +5   
  Misses           90         90          
  Partials          0          0          

Powered by Codecov. Last update b649671...09a3aa0

@hzoo hzoo merged commit 27ad69d into babel:master Aug 23, 2016

3 checks passed

codecov/patch 100% of diff hit (target 96.91%)
Details
codecov/project 96.92% (+<.01%) compared to b649671
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danez danez deleted the danez:fix-87 branch Aug 31, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.