This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix declare class with qualified type identifier #97
Conversation
danez
added
the
Tag: Bug Fix
label
Aug 19, 2016
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Aug 19, 2016
Current coverage is 96.92% (diff: 100%)@@ master #97 diff @@
==========================================
Files 19 19
Lines 2922 2927 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2832 2837 +5
Misses 90 90
Partials 0 0
|
hzoo
merged commit 27ad69d
into
babel:master
Aug 23, 2016
danez
deleted the
danez:fix-87
branch
Aug 31, 2016
danharper
referenced this pull request
Sep 11, 2016
Closed
Parsing error when declaring a class that extends a property of another class (flow) #368
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danez commentedAug 19, 2016
•
edited
This makes declare class extends behave the same way as in flow.
The ast-token after the extends keyword, might be either Identifier or QualifiedTypeIdentifier.
To do that this change splits the parseGenericType into two functions, one for parsing genericType and on for qualifiedTypeIdentifier
Fixes #87