New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve acceptance tests and Ember syntax #164

Merged
merged 9 commits into from Jul 21, 2017

Conversation

Projects
None yet
5 participants
@villander
Copy link
Contributor

villander commented Jul 9, 2017

No description provided.

villander added some commits Jul 9, 2017

const Router = Ember.Router.extend({
const { Router } = Ember;

const EmRouter = Router.extend({

This comment has been minimized.

@kellyselden

kellyselden Jul 10, 2017

Member

I would prefer to stay in sync with the official blueprint.

This comment has been minimized.

@villander

villander Jul 10, 2017

Author Contributor

@kellyselden But the official blueprint has a global sweetening, why not follow the Dockyard styleguide where we reduce global calls?

https://github.com/DockYard/styleguides/blob/master/engineering/ember.md#import-what-you-use-do-not-use-globals

This comment has been minimized.

@kellyselden

kellyselden Jul 10, 2017

Member

That styleguide will soon be out of date. This is the new importing standard: https://github.com/ember-cli/ember-rfc176-data

This comment has been minimized.

@villander

villander Jul 10, 2017

Author Contributor

@kellyselden Can I make that change then? From which ember-cli version is it already available? I've seen that ember-basic-dropdown is already using it, although it's still in beta.

https://github.com/cibernox/ember-basic-dropdown/blob/master/addon/components/basic-dropdown/content.js#L1

@@ -1,9 +1,12 @@
import Ember from 'ember';

export default Ember.Controller.extend({
const { Controller, A, computed } = Ember;

This comment has been minimized.

@kellyselden

kellyselden Jul 10, 2017

Member

This is going to be outdated syntax extremely soon now that addons are starting to update to the new module api.

This comment has been minimized.

@villander

villander Jul 10, 2017

Author Contributor

Ok I'll go back to the original

assert.equal('one', find('#first-value').text());
assert.equal('two', find('#last-value').text());
assert.equal('Test Value', find('#test-input').val(), 'Has arrow functions and template string as ES6 feature');
assert.equal('one', find('#first-value').text(), 'Has generatos as ES6 feature');

This comment has been minimized.

@kellyselden

kellyselden Jul 10, 2017

Member

generatos => generators

}
});

test('value of input', function(assert) {
test('ES6 features work correcly', function(assert) {

This comment has been minimized.

@kellyselden

kellyselden Jul 10, 2017

Member

all these text clarifications I like.

villander added some commits Jul 10, 2017

@villander

This comment has been minimized.

Copy link
Contributor Author

villander commented Jul 10, 2017

@villander

This comment has been minimized.

Copy link
Contributor Author

villander commented Jul 21, 2017

@kellyselden we can do merge this?

@kellyselden

This comment has been minimized.

Copy link
Member

kellyselden commented Jul 21, 2017

I'm trying to get #167 merged first so we can add some linting rules.

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Jul 21, 2017

#167 has landed

villander added some commits Jul 21, 2017

@stefanpenner
Copy link
Member

stefanpenner left a comment

looks great!

@rwjblue rwjblue merged commit a06803d into babel:master Jul 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Turbo87 Turbo87 added the internal label Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment