Improve acceptance tests and Ember syntax #164
Conversation
tests/dummy/app/router.js
Outdated
| const Router = Ember.Router.extend({ | ||
| const { Router } = Ember; | ||
|
|
||
| const EmRouter = Router.extend({ |
There was a problem hiding this comment.
I would prefer to stay in sync with the official blueprint.
There was a problem hiding this comment.
@kellyselden But the official blueprint has a global sweetening, why not follow the Dockyard styleguide where we reduce global calls?
There was a problem hiding this comment.
That styleguide will soon be out of date. This is the new importing standard: https://github.com/ember-cli/ember-rfc176-data
There was a problem hiding this comment.
@kellyselden Can I make that change then? From which ember-cli version is it already available? I've seen that ember-basic-dropdown is already using it, although it's still in beta.
| @@ -1,9 +1,12 @@ | |||
| import Ember from 'ember'; | |||
|
|
|||
| export default Ember.Controller.extend({ | |||
| const { Controller, A, computed } = Ember; | |||
There was a problem hiding this comment.
This is going to be outdated syntax extremely soon now that addons are starting to update to the new module api.
There was a problem hiding this comment.
Ok I'll go back to the original
tests/acceptance/simple-test.js
Outdated
| assert.equal('one', find('#first-value').text()); | ||
| assert.equal('two', find('#last-value').text()); | ||
| assert.equal('Test Value', find('#test-input').val(), 'Has arrow functions and template string as ES6 feature'); | ||
| assert.equal('one', find('#first-value').text(), 'Has generatos as ES6 feature'); |
tests/acceptance/simple-test.js
Outdated
| } | ||
| }); | ||
|
|
||
| test('value of input', function(assert) { | ||
| test('ES6 features work correcly', function(assert) { |
There was a problem hiding this comment.
all these text clarifications I like.
|
Done @kellyselden |
|
@kellyselden we can do merge this? |
|
I'm trying to get #167 merged first so we can add some linting rules. |
|
#167 has landed |
No description provided.