This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Add func-params-comma-dangle rule #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
^ @cpojer |
ghost
pushed a commit
to facebookarchive/nuclide
that referenced
this pull request
Jul 16, 2016
…or of eslint-plugin-babel's Summary: We upstreamed a better version of this rule. babel/eslint-plugin-babel#64 Reviewed By: nmote Differential Revision: D3573577 fbshipit-source-id: c7492d3f76d577f9bd77a57e3b90f3d9b7c9e8ab
|
babel/babylon#51 is fixed in the latest babylon |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
Add func-params-comma-dangle rule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
comma-dangle, with the same options, but for trailing commas in function parameter lists.There is a bug in the AST, where in arrows functions, the loc's for params with flow types only cover the argument identifier (or rest element), and not the flow type. So for this case, this rule is a noop. I'll have to investigate it separately.