If..Else preserve vars from the removed Block #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ (Close #48) + dead-code-elimination
| node.alternate = null; | ||
| node.test = t.unaryExpression("!", test, true); | ||
| consequent.replaceWith(alternate.node); | ||
| alternate.skip(); |
There was a problem hiding this comment.
here, is it safe to skip this, as the node will be inserted in consequent and will go through other plugins and the alternate node removed will be skipped. Should there be a test case for this ?
There was a problem hiding this comment.
Sure, can you please add a test for this?
There was a problem hiding this comment.
FYI: babel-traverse marks it as shouldSkip when .remove
|
LGTM |
A test case to verify that optimizations are applied when an empty consequent block statement is replaced with the alternate statement.
|
Now there are 2 failing test cases because of indentation issues, help! |
|
Ok, I'll merge and check tests locally |
|
This introduced some regressions, looking at it now. You can see the failing tests here: https://travis-ci.com/amasad/babel-minify/jobs/46513934 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This somehow makes one test case fail due to some indentation issue.
I'm doing
path.skip()the paths that are removed - is that safe to do ?