fix: Improve the process of fetching the release URL. #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| url, | ||
| publishedAt: release.published_at | ||
| } | ||
| }) |
There was a problem hiding this comment.
Bug: URL Assignment Fails for Unmatched Patterns
It looks like the url variable can end up undefined if rawUrl doesn't match either the refs/heads/ or release/ patterns. The new conditional assignment means url isn't always given a value, unlike the previous logic. This creates release objects with an undefined URL, which will likely cause problems when fetching markdown content.
web3jenks
approved these changes
Aug 19, 2025
web3jenks
added a commit
that referenced
this pull request
Aug 21, 2025
* chore: replace "l2scan" with "Xangle" (#242) * chore: replace "l2scan" with "Xangle" * chore: modify faucet description & xangle png --------- Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Daria/cli ref clean (#208) * create clean branch w new color scheme * overview * rm duplicate overview * rm guide --------- Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> * fixed borken links * fix: optimize api response css & faucet typo * re-draw bsn architecture diagrams in engineering diagram styles (#216) * Jenks/re org nav (#244) * initial structure * small fixes to developer docs * update developer.mdx & populated stakers.mdx pagfe * fixed broken links * Update query.mdx * removed community pool proposal type * Update docusaurus.config.js * initial structure * fix: adjust style & format baby staking guide (#196) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * updated cosmos & op stack chain .mdxs (#200) * Merge remote-tracking branch 'origin/main' into jenks/re-org-nav --------- Co-authored-by: Kevin <33023258+kkkk666@users.noreply.github.com> Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * corrected duplication issue with to Nav * fix: Restore the image link * chore: Update-Unbonding-Time (#249) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Added commands to babylon_usage_guide.mdx (#246) * Update docs/stakers/btc_stakers/native_staking/unbonding_via_cli.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * removed global_config.mdx * fixed broken links * fix: fix broken link (#254) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Update docs/stakers/btc_stakers/native_staking/unbonding_via_web.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * added redirect plugin * upload whitepaper (#260) Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> * add btc vault whitepaper (#264) Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> * chore: update Bitgo Custody Services Staking Status (#262) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * chore: add legal notice (#266) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Update docs/guides/overview/babylon_genesis/baby_tokenomics.mdx Fix typos. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: Improve the process of fetching the release URL. (#271) * fix: Improve the process of fetching the release URL. * fix: Improve the process of fetching the release URL. --------- Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * chore: update-staking-image (#267) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * add validator setup guide (#217) * add validator setup guide * change title --------- Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> * feat: simple-finality-provider guide & Docker Deployment Guide (#253) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Update docs/stakers/btc_stakers/native_staking/unbonding_via_web.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "Update docs/stakers/btc_stakers/native_staking/unbonding_via_web.mdx" This reverts commit 065a61f. * fix: Adjust the document format --------- Co-authored-by: Kevin <33023258+kkkk666@users.noreply.github.com> Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> Co-authored-by: Daria <dariaagad@gmail.com> Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> Co-authored-by: Sam <48280694+itrocket-team@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
web3jenks
added a commit
that referenced
this pull request
Sep 9, 2025
* chore: replace "l2scan" with "Xangle" (#242) * chore: replace "l2scan" with "Xangle" * chore: modify faucet description & xangle png --------- Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Daria/cli ref clean (#208) * create clean branch w new color scheme * overview * rm duplicate overview * rm guide --------- Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> * fixed borken links * fix: optimize api response css & faucet typo * re-draw bsn architecture diagrams in engineering diagram styles (#216) * Jenks/re org nav (#244) * initial structure * small fixes to developer docs * update developer.mdx & populated stakers.mdx pagfe * fixed broken links * Update query.mdx * removed community pool proposal type * Update docusaurus.config.js * initial structure * fix: adjust style & format baby staking guide (#196) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * updated cosmos & op stack chain .mdxs (#200) * Merge remote-tracking branch 'origin/main' into jenks/re-org-nav --------- Co-authored-by: Kevin <33023258+kkkk666@users.noreply.github.com> Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * corrected duplication issue with to Nav * fix: Restore the image link * chore: Update-Unbonding-Time (#249) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Added commands to babylon_usage_guide.mdx (#246) * Update docs/stakers/btc_stakers/native_staking/unbonding_via_cli.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * removed global_config.mdx * fixed broken links * fix: fix broken link (#254) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Update docs/stakers/btc_stakers/native_staking/unbonding_via_web.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * added redirect plugin * upload whitepaper (#260) Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> * add btc vault whitepaper (#264) Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> * chore: update Bitgo Custody Services Staking Status (#262) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * chore: add legal notice (#266) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Update docs/guides/overview/babylon_genesis/baby_tokenomics.mdx Fix typos. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: Improve the process of fetching the release URL. (#271) * fix: Improve the process of fetching the release URL. * fix: Improve the process of fetching the release URL. --------- Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * chore: update-staking-image (#267) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * add validator setup guide (#217) * add validator setup guide * change title --------- Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> * feat: simple-finality-provider guide & Docker Deployment Guide (#253) Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Update docs/stakers/btc_stakers/native_staking/unbonding_via_web.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "Update docs/stakers/btc_stakers/native_staking/unbonding_via_web.mdx" This reverts commit 065a61f. * fix: Adjust the document format * Update bsns.mdx (#272) * Update bsns.mdx * fix: broken image link --------- Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> * Update src/components/RemoteMD.jsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/operators/finality_providers/finality_provider_simple_guide.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Kevin <33023258+kkkk666@users.noreply.github.com> Co-authored-by: kevin <liukangtian@liukangtiandeMacBook-Pro.local> Co-authored-by: Daria <dariaagad@gmail.com> Co-authored-by: Daria Agadzhanova <dariaagadzhanova@Darias-MacBook-Air.local> Co-authored-by: Sam <48280694+itrocket-team@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the process of fetching the release URL.