-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding update checker test env variable #3997
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
// The BACALHAU_UPDATE_CHECKER_TEST is an env variable a user can set so that we can track | ||
// when the binary is being run by a non-user, to enable easier filtering of queries | ||
// to their update server for internal/CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I assume this has some relation to: https://github.com/bacalhau-project/getbacalhauorg/pull/29 ?
when the binary is being run by a non-user
What does this mean? Like a linux user or a person who uses bacalhau?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
person who uses / deploys / etc bacalhau.
Basically just let users set (if they want) a key indicating this run is "internal".
No description provided.