Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] upload an inserted image automatically #1199

Closed
jenlampton opened this issue Sep 16, 2015 · 5 comments
Closed

[UX] upload an inserted image automatically #1199

jenlampton opened this issue Sep 16, 2015 · 5 comments

Comments

@jenlampton
Copy link
Member

If you add an image in the rich-text editor but forget to hit the Upload button, closing the dialog does not insert the image. Let's automatically upload the image, just like we do for fields.

@quicksketch
Copy link
Member

Let's automatically upload the image, just like we do for fields.

The easiest way to solve this is in the same manner as Drupal 8, in which the problem isn't actually fixed, but it is greatly obscured to the point that it's irrelevant. In D8, files auto-upload upon selection, whether on file fields or in the dialog for uploading an image. This auto-upload saves the user from needing to click the "Upload" button, and in turn hides the fact that images are not uploaded upon saving the dialog.

Implementing this is fairly trivial. If we take that approach, it shouldn't be much work at all.

@ghost
Copy link

ghost commented Feb 23, 2016

FWIW, backdrop/backdrop#1226 implements a backdropuploadimage plugin, which allows image upload without any dialog, 0 click, just drag and drop.
It just requires CKEditor 4.5.5 (for its uploadwidget)

@quicksketch
Copy link
Member

FWIW, backdrop/backdrop#1226 implements a backdropuploadimage plugin, which allows image upload without any dialog, 0 click, just drag and drop.

That's awesome. I'd love to get that into 1.4.0. I left some feedback on moving forward on that issue in #1560 (comment).

We'll still want to fix this dialog in any case, we'll still want to have a button for uploading an image as it's more discoverable than drag-and-drop, plus not all systems have that option anyway (iOS, Android).

I'll file a PR to fix the dialog by auto-uploading.

@quicksketch
Copy link
Member

Merged in backdrop/backdrop#1275 for 1.3.3.

@klonos
Copy link
Member

klonos commented Feb 25, 2016

This is great! Thanx. Mind if I shamelessly promote the related #869??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants