[META] CKEditor/Rich text editor followups

[quicksketch]

This issue summarizes follow-ups to the new WYSIWYG/rich text editor issue #101.

Todo:

• [UX] CKEditor: Replace the "Add a caption" checkbox with a "Caption" field #1093 - [UX] CKEditor: Replace the "Add a caption" checkbox with a "Caption" field
• [D7] Support summaries in CKEditor or introduce a teaser break plugin #1222 - Add a teaser break plugin
• When editing in source mode (inside a dialogue window) changes are not saved unless you switch back out of source mode #1259 - Custom block content not updated if you are switched to Source mode before saving the block.
• [META][UX] Improvements for the image library #1307 - Add a file/image browser
• Support tokens in upload directory definition for CKEditor and image fields #1585 - Add token support in upload directory definition
• CKEditor links do not handle aliases #1595 - CKEditor links do not handle aliases
• Add ability to disable the automatic linking of URLs and email addresses by wrapping them in a 'nolink' class. #1926 - Prevent URLs or email addresses turning into links (partly editor related)
• [UX] Add an option to "lock" aspect ratio when resizing images in the editor dialog #2054 - Retain aspect ratio when resizing images (option, set by default)
• [UX] Add the ckeditor spell-check plugin #2071 - Add a spell-check plugin
• [UX] CKEditor block element formats drop-down: Change "Normal" to "Paragraph" #2176 - [UX] CKEditor block element formats drop-down: Change "Normal" to "Paragraph"
• [UX] - CKEditor: Allow fail-safe adding of external links #2476 - [UX] - CKeditor: Allow fail-safe adding of external links
• [UX] CKeditor: Allow the Styles dropdown to use tag names (for easy use of the <small> tag) #2980 - [UX] Allow the use of the <small> tag
• [D8] CKEditor: Allow Image Styles to be used with inline images #2658 - [D8 feature parity] CKEditor: Allow Image Styles to be used with inline images
• [UX] CKEditor: Consider adding the Auto Grow and Fixed plugins in core #3354 - [UX] CKEditor: Consider adding the Auto Grow plugin
• [UX] CKEditor: Include the Balloon Toolbar plugin introduced in 4.8, and start using it. #3356 - [UX] CKEditor: Include the Balloon Toolbar plugin introduced in 4.8, and start using it.
• CKEditor: consider the new Autocomplete plugin (introduced in 4.10) for addition to core. #3357 - CKEditor: consider the new Autocomplete plugin (introduced in 4.10) for addition to core.
• CKEditor: URLs added in the image caption are not converted to links (although the text filter allows it) #3383 - URLs added in the image caption are not converted to links (although the text filter allows it)
• [UX] CKEditor - Provide default styles  #4233 - CKEditor - Provide default styles

Done:

• [UX] move text filter configuration into modals #1032 - [UX] New text format configuration UI.
• [UX] Open long filter tips in a dialog and rework the contents #1089 - [UX] Open long filter tips in a dialog and rework the contents
• [UX][D8] Add support for more link attributes in rich-text editor (id, rel, target, title) #1777 - Add a custom link plugin (or port the Drupal 8 one)
• [UX] Allow uploading a file from the link dialog in rich-text editor #2072 - Add a file as an option for link source
• [UX] Collapse the input format options fieldset on node edit forms #938 - [UX] Collapse the input format options fieldset on node edit forms
• CKEditor: allow uploading an image. #1088 - Allow uploading an image.
• Ship with a text format that includes a text editor. #1091 - Ship with a text editor enabled out of the box
• Cannot insert an image into CKEditor when editing a custom block through Layouts #1125 - Cannot insert an image into CKEditor when editing a custom block through Layouts
• [UX] upload an inserted image automatically #1199 - Bug: Images are not uploaded automatically, need the button to be pushed.
• [UX] CKEditor: Allow to browse and enter links of local paths (content, users etc.). #1206 - [UX] CKEditor: Allow to browse and enter links of local paths (content, users etc.).
• CKEditor toolbar: Cannot save the flag button ("Anchor") position in the toolbar. #1231 - Bug: Cannot add the Anchor button
• CKEditor insisting on converting line breaks into paragraphs #1350 - Bug: CKEditor insisting on converting line breaks into paragraphs
• Image files uploaded through custom block wysiwyg are removed by garbage collection #1373 - Bug: Image files removed by garbage collection
• Plan to upgrade CKEditor to 4.5.x. #1560 - Update to latest version of CKeditor
• CKEditor - need to be able to add a link to an image. #1586 - Add a link to an image.
• Editor disappears when AJAX runs on node form #1975 - Editor disappears when AJAX runs on node form
• Add back the missing ckeditor link/unlink/anchor buttons #2142 - Bug: add back missing link buttons
• [UX] Add a HTML tag selector (Format dropdown) into the Rich-Text editor #2148 - Add format drop-down by default
• ckeditor: Strike button will not appear, though <del> added to allowed tags #2174 - Bug: Cannot add the Strike button
• Restore browser-based spellcheck ability in CKeditor #2386 - [UX] Restore browser based spellcheck
• Upload images in CKEditor via Drag and Drop or Clipboard Paste #2630 - Upload images in CKEditor via Drag and Drop or Clipboard Paste

[docwilmot]

re #938 I feel if we get the "filter tips" in a modal as planned, the text format selection area will be completely acceptable without the collapsed fieldset, so is it worth the extra click then?

[klonos]

I've updated the list to add a couple of issues reported by @Graham-72, fixed a minor typo and removed a duplicate entry (issue 1125).

[Graham-72]

Please may I register a plea that these CKEditor issues now become high priority. You have done a brilliant job with release 1.3.0 for which I am very grateful, but CKEditor is a large part of the face of Backdrop to my end users, and if there are things it cannot do or gets wrong my end users are not impressed.

[ghost]

👍 to @Graham-72 post : The missing Save button and plugin, the missing Autogrow plugin, are not understandable by my end users; they'd say it's not serious.
Ok, this is trivial to implement in a custom module, but not every one in small non-profit organisations have the option to write a single line of php (or the dozen of javascript lines to size the CKEditor area to the useable screen height)...

[quicksketch]

Moving this to 1.5.0 for further work. We upgrading CKEditor in 1.4.0 to version 4.5.9. We still have several items needing addressing.

[docwilmot]

Just a note, this is not the kind of thing I can handle, so I cant lend a hand here. But it would be great if this could be actually assigned to someone (or someones, since that's now possible), so that it doesnt just sit. I'm not sure (I hope I'm not being too presumptuous) how many of us are able to actually handle this. Would be great to see a show of hands here before we run out of time again.

[jenlampton]

I'm removing the bullet for "Add the ability to reuse an existing image on managed file elements" since I don't really understand what that means. Are we talking about building a new managed file form element that would allow the same toggle between autocomplete / file browser / view? Just like we already have in the CKEditor image dialog?

Would someone who understands that request create an issue with an explanation (and link it here) so we don't forget what it means all over again? :)

[Graham-72]

create an issue with an explanation

I now have tried to do this at issue #2056 'CKEditor - add the ability to reuse an existing image'.

[jenlampton]

We already have an issue for that in our list: #1307 Allow reusing images in the Editor dialog

[Graham-72]

👍

[olafgrabienski]

I've added some CKeditor related issues in the checklist which were missing (1206, 1595, 1926, 2176, 2476).

[quicksketch]

We will have knocked off #2630 and #1206 in 1.7.0.

I'm not sure if we should keep bumping this to the next minor release, but honestly I like having it accessible/findable there. Bumping to 1.8.0 for now.

[jenlampton]

I'm going to bump the milestone for the meta to 1.9, I agree I like having it in focus for people looking for our priorities.

[jenlampton]

bumping milestone.

[quicksketch]

Knocked out #2072 in 1.10.

[jenlampton]

bumping milestone.

[klonos]

@jenlampton this is a meta-issue. Should we just change the milestone to 1.x-future to avoid having to bump it every time?

[jenlampton]

Sounds good!

[klonos]

Done 😄