Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the missing ckeditor link/unlink/anchor buttons #2142

Closed
jenlampton opened this issue Sep 7, 2016 · 5 comments
Closed

Add back the missing ckeditor link/unlink/anchor buttons #2142

jenlampton opened this issue Sep 7, 2016 · 5 comments
Assignees
@quicksketch
Labels
status - fixed status - has pull request type - bug report
Milestone
1.4.5

Comments

@jenlampton
Copy link
Member

In the latest version of Backdrop the link/unlink/anchor buttons are missing. This is because we pulled Drupal 8's compiled version of CKeditor, and Drupal 8 uses their own link plugin, so has removed the default.

Is it time to start rolling our own compiled version of the CKeditor library? Let's document here the steps to follow to get an adequate version of CKeditor for Backdrop. We can follow this recipe every time the editor needs to be updated so we don't accidentally remove features people know and love.
@jenlampton jenlampton added this to the 1.5.0 milestone Sep 7, 2016
@jenlampton jenlampton mentioned this issue Sep 7, 2016
Closed
@quicksketch quicksketch mentioned this issue Sep 7, 2016
Open
39 tasks
@jenlampton jenlampton mentioned this issue Sep 7, 2016
Closed
@jenlampton jenlampton modified the milestones: 1.4.5, 1.5.0 Sep 7, 2016
@quicksketch
Copy link
Member

I have no idea how/why our link buttons were removed from the default format. That is just crazy. I'll whip up a PR for this one.

@quicksketch quicksketch self-assigned this Sep 9, 2016
@quicksketch quicksketch mentioned this issue Sep 9, 2016
Merged
@quicksketch
Copy link
Member

Backdrop already includes link buttons and they are supposed to be enabled by default. You can still enable them manually after install, but the fact that they are missing on new installs is a bug. As shown in the PR, backdrop/backdrop#1527, we just omitted the word "Backdrop" from the button names, they're already supposed to be positioned in the default toolbar.

@quicksketch
Copy link
Member

Much better!

screenshot from 2016-09-08 22-59-55

@jenlampton
Copy link
Member Author

Hooray, the links are back :) RTBC from me.

@olafgrabienski olafgrabienski mentioned this issue Sep 9, 2016
Closed
backdrop-ci referenced this issue in backdrop/backdrop Sep 10, 2016
@quicksketch
Issue #2142: Fix Backdrop link/unlink plugin buttons.
3b04d60
@quicksketch
Copy link
Member

Merged into 1.x and 1.4.x.

backdrop-ci referenced this issue in backdrop/backdrop Sep 11, 2016
@quicksketch
Issue #2142: Fix Backdrop link/unlink plugin buttons.
d244e8b
@serundeputy serundeputy mentioned this issue Sep 17, 2016
Closed
backdrop-ci referenced this issue in backdrop/backdrop Dec 21, 2023
@quicksketch
Issue #2142: Fix Backdrop link/unlink plugin buttons.
eade303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quicksketch quicksketch

Labels
status - fixed status - has pull request type - bug report
Projects
None yet
Milestone
1.4.5
Development

No branches or pull requests
2 participants
@quicksketch @jenlampton