Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Remove the dependency on specific system module version from entityreference module. #5734

Closed
klonos opened this issue Aug 21, 2022 · 2 comments · Fixed by backdrop/backdrop#4176
Closed

Fixed: Remove the dependency on specific system module version from entityreference module. #5734

klonos opened this issue Aug 21, 2022 · 2 comments · Fixed by backdrop/backdrop#4176
Assignees
@klonos
Labels
status - fixed status - has pull request type - task
Milestone
1.23.0

Comments

@klonos
Copy link
Member

klonos commented Aug 21, 2022

This is just a small cleanup task. The dependencies[] = system (>= 1.21.0) line is originating from the contrib module, where it made sense to exist. It serves no purpose now that the module is included in core, since the System module is always enabled, and whatever the current version is will always be the appropriate one.
@klonos klonos self-assigned this Aug 21, 2022
klonos added a commit to klonos/backdrop that referenced this issue Aug 21, 2022
@klonos
Issue #5734: Remove the system dependency from entityreference.info
f03c231 
Fixes backdrop/backdrop-issues#5734
@klonos klonos mentioned this issue Aug 21, 2022
Merged
@herbdool herbdool added this to the 1.22.3 milestone Aug 21, 2022
@herbdool
Copy link

Makes sense

@herbdool herbdool modified the milestones: 1.22.3, 1.23.0 Aug 27, 2022
backdrop-ci referenced this issue in backdrop/backdrop Aug 29, 2022
@klonos
Issue #5734: Remove the system dependency from entityreference.info
95e3e19 
By @klonos and @herbdool.
@quicksketch
Copy link
Member

quicksketch commented Aug 29, 2022 •
edited
Loading

Thanks @klonos and @herbdool! Merged backdrop/backdrop#4176 into 1.x for 1.23.0. No back-port to 1.22.x needed since core Entity Reference is new.

@jenlampton jenlampton changed the title Remove the unnecessary dependency to system module from entityreference.info Fixed: Remove the dependency on specific system module version from entityreference module. Sep 16, 2022
@jenlampton jenlampton mentioned this issue Sep 16, 2022
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klonos klonos

Labels
status - fixed status - has pull request type - task
Projects
None yet
Milestone
1.23.0
Development

Successfully merging a pull request may close this issue.

Issue #5734: Remove the system dependency from entityreference.info klonos/backdrop
3 participants
@quicksketch @herbdool @klonos