-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow passing key to [stackexchange] #8539
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. couple inline thoughts but nothing that needs to block
Modifying the docs has dismissed the review. If you can give me a quick re-:+1: on this one I'll sort out getting it deployed with a key over the weekend. |
closes #5415
closes #3591
This is the code bit. It allows us to optionally pass a key when calling the StackExchange API. Once deployed, I'll also need to set a
stackapps_api_key
in prod. I've tested locally with a key and can confirm that without auth our quota is 300 per day and passing a key raises our quota from 300 requests per day to 10,000. This should cover our current usage (although these have been unreliable for a long time, so I suspect that contributes to the low traffic on these badges).If we ever outgrow that: