chore(deps): bump webextension-store-meta from 1.1.0 to 1.2.1; test [chromewebstore] #10094
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [webextension-store-meta](https://github.com/awesome-webextension/webextension-store-meta) from 1.1.0 to 1.2.1. - [Changelog](https://github.com/awesome-webextension/webextension-store-meta/blob/main/CHANGELOG.md) - [Commits](https://github.com/awesome-webextension/webextension-store-meta/commits/v1.2.1) --- updated-dependencies: - dependency-name: webextension-store-meta dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
🚀 Updated review app: https://pr-10094-badges-shields.fly.dev |
chris48s
changed the title
|
https://pr-10094-badges-shields.fly.dev/chrome-web-store/stars/hkgmldnainaglpjngpajnnjfhpdjkohh It still says "inaccessible". Seems confusing. |
|
This version is at least installable, but breaks all chrome web store badges. Failure is There are no documented changes to the public API. We are using the library as documented. I'm out of time today. I'll come back to it tomorrow, but it looks like the BC break is this commit: awesome-webextension/webextension-store-meta@0565f15 |
|
Thanks for the investigation. I can further diagnose this issue and report to upstream. |
Well, the usage example in README did change to reflect the new API signature. It's not obvious to existing users though.
After discussing with the upstream, they decided to keep this breaking change and document it in CHANGELOG. Changing |
I don't love this, but it will do
|
|
🚀 Updated review app: https://pr-10094-badges-shields.fly.dev |
|
OK. There shouldn't really be breaking changes in a minor version, but thanks for following it up. |
| // Keep this "inaccessible" test, since this service does not use BaseService#_request. | ||
| const mockAgent = new MockAgent() | ||
| t.create('Version (inaccessible)') | ||
| .get('/alhjnofcnnpeaphgeakdhkebafjcpeae.json') | ||
| .networkOff() | ||
| // webextension-store-meta uses undici internally, so we can't mock it with nock | ||
| .before(function () { | ||
| setGlobalDispatcher(mockAgent) | ||
| mockAgent.disableNetConnect() | ||
| }) | ||
| .after(async function () { | ||
| await mockAgent.close() | ||
| setGlobalDispatcher(new Agent()) | ||
| }) |
There was a problem hiding this comment.
Just for code archaeology purposes:
Uniquely, the chrome web store integration bypasses our usual HTTP client. We farm out making the request to an external library.
In v1.2.0, webextension-store-meta switched their HTTP client from node-fetch to undici.
In theory, that is just internals not API surface but because undici bypasses the normal node HTTP stack, this means we now can't mock the requests it makes using nock (see nock/nock#2183 ). Oh no - they removed spacebar heating!
For the purposes of just getting these tests to work, I've implemented an ad-hoc mocking solution for undici and copy/pasted it to the 3 places we need to do this. If we had a lot of code using undici, I'd pull this out to an abstraction but given this is a uniquely non-standard service it is probably actively unhelpful to implement this on the core test helper. We can live with this.
There was a problem hiding this comment.
Yep, it intentionally bypasses the node http module because it has problems handling non-ascii location headers sent by Google's server.
chris48s
deleted the
dependabot/npm_and_yarn/webextension-store-meta-1.2.1
branch
Bumps webextension-store-meta from 1.1.0 to 1.2.1.
Changelog
Sourced from webextension-store-meta's changelog.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)