Remove namedLogo from defaultBadgeData of non-social badges #10195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to our badge guidelines:
The following line of code does remove the logo when the badge has a non-social style, so we're not violating our guidelines per say:
shields/core/base-service/coalesce-badge.js
Line 153 in d682172
However, I think it's best to remove the
namedLogo
from the very few non-social badges where it is included, both from a consistency perspective, and to avoid any confusion (for example in #7759). Having something specified that is then overridden deep down somewhere else in the code is not exactly intuitive.