Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namedLogo from defaultBadgeData of non-social badges #10195

Merged
merged 1 commit into from
May 27, 2024

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented May 25, 2024

According to our badge guidelines:

Except for badges using the social style, logos and links should be turned off by default.

The following line of code does remove the logo when the badge has a non-social style, so we're not violating our guidelines per say:

style === 'social' ? defaultNamedLogo : undefined,

However, I think it's best to remove the namedLogo from the very few non-social badges where it is included, both from a consistency perspective, and to avoid any confusion (for example in #7759). Having something specified that is then overridden deep down somewhere else in the code is not exactly intuitive.

@PyvesB PyvesB added the service-badge New or updated service badge label May 25, 2024
Copy link
Contributor

Warnings
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 8c71323

Copy link
Contributor

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PyvesB PyvesB added this pull request to the merge queue May 27, 2024
Merged via the queue into badges:master with commit f57c4ed May 27, 2024
24 checks passed
@PyvesB PyvesB deleted the remove-namedLogo-non-social branch May 27, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants