update logo guidance #2888
Merged
update logo guidance #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doc/logos.md
Outdated
|
|
||
| ## Contributing Logos | ||
|
|
||
| Our preferred way to consume icons is via the SimpleIcons logo. As a first port of call, we encourage you to contribute logos to [the SimpleIcons project][simple-icons github]. In some cases we may also accept logo submissions directly. In general, we do this only when: |
There was a problem hiding this comment.
Should we pull in some of the Simple Icons limitations, like the Page Rank guideline?
There was a problem hiding this comment.
I've added a link to their guidance 👍
doc/logos.md
Outdated
|
|
||
| - We have a corresponding badge on the homepage, (e.g. the Eclipse logo because we support service badges for the Eclipse Marketplace). We may also approve logos for other tools widely used by developers. | ||
| - The logo provided in SimpleIcons is unclear when displayed at small size on a badge or | ||
| - There is substantial benefit in using a multi-colored icon over a monochrome icon |
There was a problem hiding this comment.
Is "it doesn't quality for Simple Icons" a valid reason? Should it go through a PR over there in order to determine if an exception can be made?
There was a problem hiding this comment.
Good question. In practice, I doubt this will be common but I've added a sentence. I wouldn't want to make it a hard requirement that you have to go and waste another maintainer's time to review and reject your PR before we'll consider a logo PR
paulmelnikow
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.