-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate discord logo to simple-icons, which matches the current branding #6764
Conversation
|
Thanks for this! There's a bit of a backstory with the handful of logos we actually maintain here locally, but the gist is that when we switched over to Simple Icons for our logos there were a couple we decided to hang on to because they'd other been provided to us directly by the vendor/owner and/or because the version of the logo in Simple Icons looked objectively "bad" at that time. Discord was one of these logos, which is why we still have a logo definition. Here's what it use to look like: However, the Simple Icon version has changed markedly since then and has aligned to Discord's branding (including their recent changes), so I actually think we should just drop our custom logo and pull in the Discord logo from the Simple Icons package like we do for 99% of the other logos (cc @badges/shields-maintainers in case others feel differently) I believe our icon loader will handle this properly simply by deleting the corresponding svg file. Is that something you'd be willing to help with @Cisien? |
So much for a seemingly simple change (but when is it ever) 😄 I probably won't have the time to dig into this deeper, sorry. |
Just to be clear, the target direction is to simply delete https://github.com/badges/shields/blob/master/logo/discord.svg from the repo. I'd suggest that's actually a bit easier than modifying the file 😉 |
Ahh, got it. I'll update this PR with the change! |
Thanks! The Simple Icons logo definitely looks much better now. I'd like to move ahead personally but want to wait to see if any of the other maintainers have any thoughts or concerns. The default logo color is their prescribed "blurple" so I don't think there's any going back to the shade of the old logo. Suppose we could change the default to one of their other permitted colors if anyone feels really strongly, but this seems like a good opportunity to me to get rid of the maintenance of another logo. (Shields.io with custom logo) (This PR with the Simple Icons logo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm on board with dumping the custom logo and just using the SI one
ew! |
https://discord.com/branding