Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate discord logo to simple-icons, which matches the current branding #6764

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Conversation

Cisien
Copy link
Contributor

@Cisien Cisien commented Jul 13, 2021

@shields-ci
Copy link

shields-ci commented Jul 13, 2021

Messages
📖 ✨ Thanks for your contribution to Shields, @Cisien!

Generated by 🚫 dangerJS against 45e699c

@Cisien
Copy link
Contributor Author

Cisien commented Jul 13, 2021

This still needs more work, the logo changed as well.
My latest push updated the discord svg to match the press kit icon_clyde_blurple_RGB.svg file.

@calebcartwright
Copy link
Member

Thanks for this! There's a bit of a backstory with the handful of logos we actually maintain here locally, but the gist is that when we switched over to Simple Icons for our logos there were a couple we decided to hang on to because they'd other been provided to us directly by the vendor/owner and/or because the version of the logo in Simple Icons looked objectively "bad" at that time.

Discord was one of these logos, which is why we still have a logo definition. Here's what it use to look like:

image

However, the Simple Icon version has changed markedly since then and has aligned to Discord's branding (including their recent changes), so I actually think we should just drop our custom logo and pull in the Discord logo from the Simple Icons package like we do for 99% of the other logos (cc @badges/shields-maintainers in case others feel differently)

I believe our icon loader will handle this properly simply by deleting the corresponding svg file. Is that something you'd be willing to help with @Cisien?

@calebcartwright calebcartwright added the core Server, BaseService, GitHub auth, Shared helpers label Jul 14, 2021
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6764 July 14, 2021 01:14 Inactive
@Cisien
Copy link
Contributor Author

Cisien commented Jul 14, 2021

So much for a seemingly simple change (but when is it ever) 😄

I probably won't have the time to dig into this deeper, sorry.

@calebcartwright
Copy link
Member

I probably won't have the time to dig into this deeper, sorry.

Just to be clear, the target direction is to simply delete https://github.com/badges/shields/blob/master/logo/discord.svg from the repo. I'd suggest that's actually a bit easier than modifying the file 😉

@Cisien
Copy link
Contributor Author

Cisien commented Jul 14, 2021

Ahh, got it. I'll update this PR with the change!

@shields-cd shields-cd temporarily deployed to shields-staging-pr-6764 July 14, 2021 02:38 Inactive
@calebcartwright
Copy link
Member

Thanks! The Simple Icons logo definitely looks much better now. I'd like to move ahead personally but want to wait to see if any of the other maintainers have any thoughts or concerns. The default logo color is their prescribed "blurple" so I don't think there's any going back to the shade of the old logo. Suppose we could change the default to one of their other permitted colors if anyone feels really strongly, but this seems like a good opportunity to me to get rid of the maintenance of another logo.

(Shields.io with custom logo)
https://img.shields.io/badge/discord-custom-blue?logo=discord

(This PR with the Simple Icons logo)
https://shields-staging-pr-6764.herokuapp.com/badge/discord-custom-blue?logo=discord

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm on board with dumping the custom logo and just using the SI one

@paulmelnikow
Copy link
Member

"blurple"

ew!

@paulmelnikow paulmelnikow changed the title Update the discord logo color to match the current branding Delegate discord logo to simple-icons, which matches the current branding Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants