Support nested groups on [GitLabTag] badge #7158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chris48s
reviewed
Oct 16, 2021
| t.create('Tag (project id latest by date)') | ||
| .get('/29538796.json') | ||
| .expectBadge({ label: 'tag', message: 'v2.0.0', color: 'blue' }) | ||
|
|
There was a problem hiding this comment.
Code looks good. I reckon we should probably also add a test case with a repo that is nested in a group (and make that standard for gitlab badges).
There was a problem hiding this comment.
Sounds reasonable to me. I did add one such test as part of #7159 to update the Pipeline status badge and can use the same project as the test case here since they do have tags. However, that project doesn't have any releases published and I don't know of any nested examples that do for #7021.
I don't think trying to use such a target with a "no releases found" test would work either, since a bad project path route produces a 404 response as well
chris48s
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #7021 (comment)