Fix compose view detach #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonshilov
reviewed
May 8, 2021
| // If there was already another child attached, then this one in | ||
| // MutableState was overwritten, and already removed from the composition as a result, | ||
| // so no further action is needed. | ||
| if (child == lastChildAttached) { |
There was a problem hiding this comment.
With the current implementation we have an important difference between AndroidView and ComposeView attach logic.
For AndroidView we add the child to the view group. So other children are still there when new one is attached.
But for ComposeView we are replacing the previous child in target:mutableState. So the default configuration essentially support only one child to be shown. Which is actually the reason of the bug we're fixing in this PR.
Is this difference in attach behavior intended? Users may expect ComposeView to behave like AndroidView, maybe we should make them the same, or document the differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289