Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retweet should also show the @-handle #234

Open
hfiguiere opened this issue Sep 2, 2014 · 7 comments
Open

Retweet should also show the @-handle #234

hfiguiere opened this issue Sep 2, 2014 · 7 comments

Comments

@hfiguiere
Copy link

Retweet should also show the @-handle in addition to the name. Because people often change the name to annoy other users making this info "useless".

@Vistaus
Copy link

Vistaus commented Feb 10, 2018

I'm sorry to necrobump this, but I'm trying to see if a few of the long-standing open issues are actually still relevant. I know Corebird still doesn't display the @-handle in addition to the name, but you can click the name and it'll direct you to the right profile. So is this still relevant, @hfiguiere ?

@IBBoard
Copy link
Contributor

IBBoard commented Feb 10, 2018

The @-handle is shown in a tooltip if you hover, so it is available. I can see it'd be more consistent to have both, as with the tweet poster, though. Should be a trivial change.

@Vistaus
Copy link

Vistaus commented Feb 10, 2018

@IBBoard But like I said: you can click the name and be directed to the right profile. So it doesn't really matter if the right handle is show, right?

@IBBoard
Copy link
Contributor

IBBoard commented Feb 10, 2018

By that argument, why show @-handle above tweet? But you show it because @-handle is (generally) persistent, but display names change.

Also, clicking the name loads a user's public timeline. That's an API request. It's better not to make users make API requests just to find out who RTed a post!

@Vistaus
Copy link

Vistaus commented Feb 10, 2018

@IBBoard commented on Feb 10, 2018, 2:29 PM GMT+1:

Also, clicking the name loads a user's public timeline. That's an API request. It's better not to make users make API requests just to find out who RTed a post!

You're right about that. In that case, this wouldn't be a bad enhancement.

IBBoard added a commit to IBBoard/corebird that referenced this issue Feb 10, 2018
The tweet author uses a separate button and label for name and handle
but the RT already includes bespoke HTML, so we extend that

Fixes bug baedert#234
@IBBoard
Copy link
Contributor

IBBoard commented Feb 10, 2018

That's my quick fix for this. I put a bold tag around the name at first, but somehow it doesn't look right compared to the tweet author at the top. Maybe too much emphasis on supplemental info if you bold it as well?

Thoughts?

@Vistaus
Copy link

Vistaus commented Feb 10, 2018

I think bolding isn't necessary. Just the @-handle would be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants