-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retweet should also show the @-handle #234
Comments
I'm sorry to necrobump this, but I'm trying to see if a few of the long-standing open issues are actually still relevant. I know Corebird still doesn't display the @-handle in addition to the name, but you can click the name and it'll direct you to the right profile. So is this still relevant, @hfiguiere ? |
The @-handle is shown in a tooltip if you hover, so it is available. I can see it'd be more consistent to have both, as with the tweet poster, though. Should be a trivial change. |
@IBBoard But like I said: you can click the name and be directed to the right profile. So it doesn't really matter if the right handle is show, right? |
By that argument, why show @-handle above tweet? But you show it because @-handle is (generally) persistent, but display names change. Also, clicking the name loads a user's public timeline. That's an API request. It's better not to make users make API requests just to find out who RTed a post! |
@IBBoard commented on Feb 10, 2018, 2:29 PM GMT+1:
You're right about that. In that case, this wouldn't be a bad enhancement. |
The tweet author uses a separate button and label for name and handle but the RT already includes bespoke HTML, so we extend that Fixes bug baedert#234
That's my quick fix for this. I put a bold tag around the name at first, but somehow it doesn't look right compared to the tweet author at the top. Maybe too much emphasis on supplemental info if you bold it as well? Thoughts? |
I think bolding isn't necessary. Just the @-handle would be enough. |
Retweet should also show the @-handle in addition to the name. Because people often change the name to annoy other users making this info "useless".
The text was updated successfully, but these errors were encountered: