fix: remove filenames in typescript symbols #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bafolts thanks! I'm still having this issue, but with classes too. |
|
What are the steps to recreate? The last provided input is in a regression
test that passes. Are you using main branch?
…On Sat, Sep 30, 2023, 7:06 AM Guga Berro ***@***.***> wrote:
@bafolts <https://github.com/bafolts> thanks!
I'm still having this issue, but with classes too.
—
Reply to this email directly, view it on GitHub
<#116 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUVDA7HRZOF7MFXUBDBHD3X5AKNRANCNFSM6AAAAAA5IIFA2U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sorry, I didn't notice that. Running from main works perfectly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can close #115 . I added the included sample from the issue in a regression test. Should always be able to remove the filename that typescript sometimes includes from the output.