Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ithaca #86

Merged
merged 52 commits into from
Mar 28, 2022
Merged

Ithaca #86

merged 52 commits into from
Mar 28, 2022

Conversation

Groxan
Copy link
Member

@Groxan Groxan commented Mar 15, 2022

Changes in the API models:

  • Account models:
    • [breaking] fields frozenDeposits, frozenRewards, frozenFees were replaced with frozenDeposit;
    • fields frozenDepositLimit, delegatedBalance, numPreendorsements, numDoublePreendorsing, numEndorsingRewards, numSetDepositsLimits were added.
  • Rewards models:
    • [breaking] fields OwnBlocks, ExtraBlocks were replaced with blocks;
    • [breaking] fields MissedOwnBlocks, MissedExtraBlocks, UncoveredOwnBlocks, UncoveredExtraBlocks were replaced with missedBlocks;
    • [breaking] fields OwnBlockRewards, ExtraBlockRewards were replaced with blockRewards;
    • [breaking] fields MissedOwnBlockRewards, MissedExtraBlockRewards, UncoveredOwnBlockRewards, UncoveredExtraBlockRewards were replaced with missedBlockRewards;
    • [breaking] fields OwnBlockFees, ExtraBlockFees were replaced with blockFees;
    • [breaking] fields MissedOwnBlockFees, MissedExtraBlockFees, UncoveredOwnBlockFees, UncoveredExtraBlockFees were replaced with missedBlockFees;
    • [breaking] fields DoubleBakingLostDeposits, DoubleBakingLostRewards, DoubleBakingLostFees were replaced with doubleBakingLosses;
    • [breaking] fields DoubleEndorsingLostDeposits, DoubleEndorsingLostRewards, DoubleEndorsingLostFees were replaced with doubleEndorsingLosses;
    • [breaking] fields RevelationLostRewards, RevelationLostFees were replaced with revelationLosses;
    • [breaking] fields UncoveredEndorsements, UncoveredEndorsementRewards, FutureBlockDeposits, BlockDeposits, FutureEndorsementDeposits, EndorsementDeposits were removed;
    • fields activeStake, selectedStake, doublePreendorsingRewards, doublePreendorsingLosses were added.
  • Baking right model:
    • [breaking] field priority was replaced with round;
    • [breaking] status uncovered was removed.
  • Cycle model:
    • [breaking] field totalRolls was removed;
    • fields selectedBakers, selectedStake were added.
  • Block model:
    • [breaking] field priority was replaced with fields payloadRound and blockRound;
    • [breaking] field baker was replaced with fields proposer and producer;
    • fields bonus, preendorsements, doublePreendorsing, endorsingRewards, setDepositsLimits were added.
  • Baking operation model:
    • [breaking] field priority was replaced with fields payloadRound and blockRound;
    • [breaking] field baker was replaced with fields proposer and producer;
    • field bonus was added.
  • Double baking operation model:
    • [breaking] field accuserRewards was replaced with accuserReward;
    • [breaking] fields offenderLostDeposits, offenderLostRewards, offenderLostFees were replaced with offenderLoss.
  • Double endorsing operation model:
    • [breaking] field accuserRewards was replaced with accuserReward;
    • [breaking] fields offenderLostDeposits, offenderLostRewards, offenderLostFees were replaced with offenderLoss.
  • Nonce revelation operation model:
    • [breaking] field bakerRewards was replaced with reward;
    • fields revealedCycle, nonce were added.
  • Revelation penalty operation model:
    • [breaking] fields lostReward, lostFees were replaced with loss.
  • Protocol model:
    • new Ithaca constants added.
  • Statistics model:
    • [breaking] field totalVested was removed.

Changes in the API endpoints:

  • /blocks parameter baker was replaced with proposer and producer;
  • /operations/baking parameters baker and priority were replaced with proposer, producer, payloadRound, and blockRound;
  • /rights parameter priority was replaced with round;
  • /operations/preendorsements/* were added;
  • /operations/double_preendorsing/* were added;
  • /operations/endorsing_rewards/* were added;
  • /operations/set_deposits_limits/* were added;

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 105 Code Smells

0.0% 0.0% Coverage
39.2% 39.2% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants