Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glslang 3rd-party library does not compile on modern Clang #1851

Closed
ebatsin opened this issue Apr 28, 2020 · 1 comment
Closed

glslang 3rd-party library does not compile on modern Clang #1851

ebatsin opened this issue Apr 28, 2020 · 1 comment
Labels
Bug A crash, misbehaviour, or other problem Unresolved Waiting for a fix or implementation

Comments

@ebatsin
Copy link

ebatsin commented Apr 28, 2020

Description

I get a compilation error in glslang using Clang 10.0.0 (In PoolAlloc.h, setAllocator tries to call private operator= on a TPoolAllocator). This issue only happens on modern versions of Clang that try to compile this method even if it is not used by renderdoc.

This issue have been fixed upstream here: KhronosGroup/glslang#2010

The first version of glslang that contains the changes should be 8.13.3559 (but simply removing the setAllocator method fixes the issue if updating glslang version is a problem).

Steps to reproduce

CMake and build renderdoc with Clang 10 with the default CMake options (I just forced BUILD_TYPE to "Release")

Environment

  • RenderDoc version: master (f29fe58)
  • Operating System: Arch Linux
  • Compiler: Clang++10
  • Build System: Ninja
  • Graphics API: -
@baldurk baldurk added Bug A crash, misbehaviour, or other problem Unresolved Waiting for a fix or implementation labels Apr 28, 2020
@baldurk
Copy link
Owner

baldurk commented Apr 28, 2020

Updated glslang to latest and also fixed another warning elsewhere that was firing on clang 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A crash, misbehaviour, or other problem Unresolved Waiting for a fix or implementation
Projects
None yet
Development

No branches or pull requests

2 participants