Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BallerinaSymbol as a parent class of BallerinaMethodSymbol #29788

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Add BallerinaSymbol as a parent class of BallerinaMethodSymbol #29788

merged 1 commit into from
Apr 15, 2021

Conversation

dulajdilshan
Copy link
Contributor

@dulajdilshan dulajdilshan commented Apr 2, 2021 •
edited
Loading

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #28388
Fixes #29467

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@dulajdilshan dulajdilshan marked this pull request as draft April 2, 2021 05:39
@dulajdilshan dulajdilshan marked this pull request as ready for review April 6, 2021 08:38
@pubudu91 pubudu91 added Area/SemanticAPI Semantic API Related Issues #Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Apr 15, 2021
@pubudu91 pubudu91 added this to the Ballerina Swan Lake - Alpha5 milestone Apr 15, 2021
@mohanvive mohanvive added Team/LanguageServer Language Server Implementation related issues. #Compiler and removed Team/LanguageServer Language Server Implementation related issues. #Compiler labels Apr 15, 2021
@hasithaa hasithaa merged commit 702abef into ballerina-platform:master Apr 15, 2021
@dulajdilshan dulajdilshan deleted the bug-fix branch April 16, 2021 16:46
@pubudu91 pubudu91 mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasithaa hasithaa hasithaa approved these changes

@pubudu91 pubudu91 Awaiting requested review from pubudu91

Assignees
No one assigned
Labels
Area/SemanticAPI Semantic API Related Issues #Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Team/LanguageServer Language Server Implementation related issues. #Compiler
Projects
None yet
Milestone
Ballerina Swan Lake - Alpha5
Development

Successfully merging this pull request may close these issues.

Cannot rename methods in a class Cannot get references of a method within a class
4 participants
@dulajdilshan @hasithaa @pubudu91 @mohanvive