Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert idl client declaration feature #38644

Merged
merged 23 commits into from
Nov 14, 2022

Conversation

azinneera
Copy link
Contributor

@azinneera azinneera commented Nov 13, 2022

Purpose

Revert idl client declaration feature

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@hasithaa
Copy link
Contributor

@azinneera Are we keeping IDLPluginContext for later use?

@azinneera
Copy link
Contributor Author

azinneera commented Nov 14, 2022

@azinneera Are we keeping IDLPluginContext for later use?

It is removed with #38638

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 76.35% // Head: 76.30% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (1a494ad) compared to base (c2a7201).
Patch coverage: 79.84% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             2201.3.0-stage   #38644      +/-   ##
====================================================
- Coverage             76.35%   76.30%   -0.06%     
+ Complexity            53127    52792     -335     
====================================================
  Files                  3388     3368      -20     
  Lines                200294   198714    -1580     
  Branches              26024    25794     -230     
====================================================
- Hits                 152934   151623    -1311     
+ Misses                38649    38448     -201     
+ Partials               8711     8643      -68     
Impacted Files Coverage Δ
...va/io/ballerina/runtime/internal/values/XmlPi.java 82.35% <0.00%> (ø)
.../io/ballerina/runtime/internal/values/XmlText.java 70.37% <0.00%> (ø)
...va/io/ballerina/compiler/api/impl/BaseVisitor.java 22.58% <ø> (-0.36%) ⬇️
...ava/io/ballerina/compiler/api/impl/NodeFinder.java 56.54% <ø> (-0.34%) ⬇️
...o/ballerina/compiler/api/impl/ReferenceFinder.java 80.23% <ø> (+0.39%) ⬆️
.../io/ballerina/compiler/api/impl/SymbolFactory.java 90.55% <ø> (-0.39%) ⬇️
...a/io/ballerina/compiler/api/impl/SymbolFinder.java 71.44% <ø> (+0.25%) ⬆️
...er/api/impl/symbols/BallerinaAnnotationSymbol.java 97.29% <ø> (-0.08%) ⬇️
.../io/ballerina/compiler/api/symbols/SymbolKind.java 100.00% <ø> (ø)
...rc/main/java/io/ballerina/projects/BalaWriter.java 85.21% <ø> (+2.43%) ⬆️
... and 258 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azinneera azinneera merged commit 084b505 into 2201.3.0-stage Nov 14, 2022
@ThisaruGuruge ThisaruGuruge deleted the revert-idl-client-declaration branch January 18, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants