Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2.x] Remove line breaks from logs #41827

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

msm1992
Copy link

@msm1992 msm1992 commented Dec 4, 2023

Purpose

Removes line break characters from log inputs.

Approach

Texts are sanitized before appending to logs.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2023

CLA assistant check
All committers have signed the CLA.

ThisaruGuruge
ThisaruGuruge previously approved these changes Dec 6, 2023
Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bhashinee Bhashinee merged commit 51559c0 into ballerina-platform:ballerina-1.2.x Dec 11, 2023
7 checks passed
@dulajdilshan
Copy link
Contributor

The better practice is to create an issue in the ballerina-lang and link it with this PR. The created issue should be linked with the internal issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants