[master] Remove unused variables & make caller isolated #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Decided to remove the 2 public records
RemoteandLocalwhich were fields of the caller. However this won't be a breaking change for users as the caller is not exposed to the user and only the enwrapped caller class (ex -ChatStringCaller) uses thegrpc:Callerwhich doesnt have any usage of the above fields. Also theremoteandlocalvalues were not populated by the runtime as well (engineering mistake).Related to ballerina-platform/ballerina-library#6656
Examples
Checklist