Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency versions #44

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

daneshk
Copy link
Member

@daneshk daneshk commented Apr 19, 2024

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@daneshk daneshk requested a review from Bhashinee April 19, 2024 05:44
ballerina/Module.md Outdated Show resolved Hide resolved
Comment on lines +29 to +55
observeVersion=1.2.3-20240408-194900-a0e331f
observeInternalVersion=1.2.2-20240408-195500-1436319

# Transitive Dependencies
# Level 01
stdlibConstraintVersion=1.4.0
stdlibConstraintVersion=1.5.0
stdlibUrlVersion=2.4.0

# Level 02
stdlibCryptoVersion=2.5.0
stdlibCryptoVersion=2.7.0-20240410-115200-2ae9fd5
stdlibTaskVersion=2.5.0

# Level 03
stdlibCacheVersion=3.7.0
stdlibCacheVersion=3.8.0-20240409-101100-e2d7f4e
stdlibMimeVersion=2.9.0
stdlibUuidVersion=1.7.0
stdlibUuidVersion=1.8.0-20240410-125400-bbe7ac5

# Level 04
stdlibAuthVersion=2.10.0
stdlibJwtVersion=2.10.0
stdlibOAuth2Version=2.10.0
stdlibAuthVersion=2.11.0-20240410-121600-c514b62
stdlibJwtVersion=2.11.0-20240410-124800-1a4eb44
stdlibOAuth2Version=2.11.0-20240410-121700-502990d

# Level 05
stdlibHttpVersion=2.10.0
stdlibHttpVersion=2.11.0-20240410-121300-ae1095d

# Level 06
stdlibTransactionVersion=1.8.0
stdlibTransactionVersion=1.9.0-20240410-104900-57aec29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for not using the docker image and using timestamp versions of library modules?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the Snowflake connector is similar to other SQL connectors, I decided to use the same way to align with other SQL connectors. that is the only reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using the connector builds for this since it is similar to the other connectors and maintaining the dependencies like this will be hard for a connector in the future. We have to bump the timestamp versions for each release and maintaining the dependent library versions manually might be cumbersome work. Given the automated workflow doesn't support ballerinax modules (this is the expected behavior since we use it for the modules packed with the distribution), we might miss this module to update to the latest version and even check for compatibility of the new distribution will be hard.

I'd recommend using the connector builds for such connectors (except if there is an unavoidable reason such as having a compiler plugin such as NATS, RabbitMQ, Kafka, etc.) to make the processes easier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ballerina/Module.md Outdated Show resolved Hide resolved
ballerina/Module.md Outdated Show resolved Hide resolved
ballerina/Module.md Outdated Show resolved Hide resolved
daneshk and others added 2 commits April 19, 2024 11:47
Co-authored-by: Thisaru Guruge <thisaru@wso2.com>
Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR for the time being, but we should consider migrating this to a connector build in the future.

@daneshk daneshk merged commit b5c74ae into ballerina-platform:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants