Address review suggestions

build.gradle

@@ -32,7 +32,7 @@ apply plugin: "org.javamodularity.moduleplugin"
 apply from: "$rootDir/gradle/javaProject.gradle"
 
 ext.clientNativeVersion = project.clientNativeVersion
-ext.skipClientNativePublish = project.skipClientNativePublish
+ext.clientNativePublish = project.clientNativePublish
 ext.ballerinaLangVersion = project.ballerinaLangVersion
 ext.testngVersion = project.testngVersion
 ext.commonsLang3Version = project.commonsLang3Version

gradle.properties

@@ -4,8 +4,8 @@ version=1.9.0-SNAPSHOT
 
 # Client Native Version
 clientNativeVersion=1.0.0-SNAPSHOT
-# Mark this as true to skip publishing the client native artifacts
-skipClientNativePublish=false
+# Mark this as false to skip publishing the client native artifacts
+clientNativePublish=true
 
 #dependency
 ballerinaLangVersion=2201.9.0-20240419-152500-bd530dd2

openapi-bal-task-plugin/src/main/java/io/ballerina/openapi/bal/tool/OpenAPICodeGeneratorTool.java

@@ -466,16 +466,14 @@ private static List<GenSrcFile> generateClientFiles(OASClientConfig oasClientCon
 
         List<ClientDiagnostic> clientDiagnostic = ballerinaClientGenerator.getDiagnostics();
 
-        if (!clientDiagnostic.isEmpty()) {
-            for (ClientDiagnostic diagnostic : clientDiagnostic) {
-                createDiagnostics(toolContext, diagnostic.getMessage(), diagnostic.getCode(),
-                        diagnostic.getDiagnosticSeverity(), location);
-            }
+        for (ClientDiagnostic diagnostic : clientDiagnostic) {
+            createDiagnostics(toolContext, diagnostic.getMessage(), diagnostic.getCode(),
+                    diagnostic.getDiagnosticSeverity(), location);
+        }
 
-            if (clientDiagnostic.stream().anyMatch(
-                    diagnostic -> diagnostic.getDiagnosticSeverity() == DiagnosticSeverity.ERROR)) {
-                throw new ClientException("Error occurred while generating client");
-            }
+        if (clientDiagnostic.stream().anyMatch(
+                diagnostic -> diagnostic.getDiagnosticSeverity() == DiagnosticSeverity.ERROR)) {
+            throw new ClientException("Error occurred while generating client");
         }
 
         sourceFiles.add(new GenSrcFile(GenSrcFile.GenFileType.GEN_SRC, null, CLIENT_FILE_NAME,

openapi-cli/src/main/java/io/ballerina/openapi/cmd/BallerinaCodeGenerator.java

@@ -203,10 +203,8 @@ public void generateClientAndService(String definitionPath, String serviceName,
         //display diagnostics- client
         List<ClientDiagnostic> clientDiagnostic = clientGenerator.getDiagnostics();
 
-        if (!clientDiagnostic.isEmpty()) {
-            for (ClientDiagnostic diagnostic : clientDiagnostic) {
-                outStream.println(diagnostic.getDiagnosticSeverity() + ":" + diagnostic.getMessage());
-            }
+        for (ClientDiagnostic diagnostic : clientDiagnostic) {
+            outStream.println(diagnostic.getDiagnosticSeverity() + ":" + diagnostic.getMessage());
         }
         printDiagnostic(diagnostics);
         writeGeneratedSources(newGenFiles, srcPath, implPath, GEN_BOTH);
@@ -434,10 +432,8 @@ private List<GenSrcFile> generateClientFiles(Path openAPI, Filter filter, boolea
         }
 
         List<ClientDiagnostic> clientDiagnostic = clientGenerator.getDiagnostics();
-        if (!clientDiagnostic.isEmpty()) {
-            for (ClientDiagnostic diagnostic : clientDiagnostic) {
-                outStream.println(diagnostic.getDiagnosticSeverity() + ":" + diagnostic.getMessage());
-            }
+        for (ClientDiagnostic diagnostic : clientDiagnostic) {
+            outStream.println(diagnostic.getDiagnosticSeverity() + ":" + diagnostic.getMessage());
         }
         printDiagnostic(diagnosticList);
         return sourceFiles;

openapi-client-native/build.gradle

@@ -120,7 +120,7 @@ tasks.withType(PublishToMavenRepository) {
     onlyIf {
         (repository == publishing.repositories.GitHub && publication == publishing.publications.GitHub) ||
                 (repository == publishing.repositories.WSO2Nexus && publication == publishing.publications.WSO2Nexus
-                 && (clientNativeVersion.endsWith('-SNAPSHOT') || !skipClientNativePublish))
+                 && (clientNativeVersion.endsWith('-SNAPSHOT') || clientNativePublish))
     }
 }