Skip to content

refactor(deps): use format rules from eslint-plugin-jest #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024
Merged

refactor(deps): use format rules from eslint-plugin-jest #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6655ffa
dep: update eslint-plugin-jest to 28
AntoineThibi Nov 6, 2024
a2b4063
fact: remove the use of jest-formating which is now inside the jets p…
AntoineThibi Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example-app/eslint-breaking-examples/break-jest-formatting-rules.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Save without formatting: [⌘ + K] > [S]

// This should trigger an error breaking eslint-jest-formatting rule:
// jest-formatting/padding-around-all
// This should trigger an error breaking eslint-pluging-jest rule:
// jest/padding-around-all

it("a test", () => {
const abc = 123;
Expand Down
3 changes: 1 addition & 2 deletions example-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
"eslint-config-prettier": "^9.0.0",
"eslint-import-resolver-typescript": "^3.6.1",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jest": "^27.2.2",
"eslint-plugin-jest-formatting": "^3.1.0",
"eslint-plugin-jest": "^28.9.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-react": "^7.31.11",
"eslint-plugin-react-hooks": "^4.6.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-plugin/lib/configs/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const testsConfig = defineConfig({
env: {
"jest/globals": true,
},
plugins: ["jest", "jest-formatting", "testing-library"],
plugins: ["jest", "testing-library"],
rules: {
// Setting the recommended rules manually, because we don't want warnings, only errors
"jest/no-alias-methods": "error", // STYLE
Expand All @@ -26,7 +26,7 @@ export const testsConfig = defineConfig({
"jest/valid-expect": "error",
"jest/valid-expect-in-promise": "error",
"jest/valid-title": ["error", { disallowedWords: ["should"] }], // STYLE
"jest-formatting/padding-around-all": "error", // STYLE
"jest/padding-around-all": "error", // STYLE
"testing-library/await-async-queries": "error",
"testing-library/no-manual-cleanup": "error",
"testing-library/no-container": "error",
Expand Down
4 changes: 1 addition & 3 deletions packages/eslint-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"eslint-import-resolver-typescript": "^3.6.1",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jest": "^27.2.2",
"eslint-plugin-jest-formatting": "^3.1.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-react": "^7.31.11",
"eslint-plugin-react-hooks": "^4.6.0",
Expand All @@ -56,8 +55,7 @@
"eslint-import-resolver-typescript": "^3.6.1",
"eslint-plugin-eslint-plugin": "^5.1.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jest": "^27.2.2",
"eslint-plugin-jest-formatting": "^3.1.0",
"eslint-plugin-jest": "^28.9.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-react": "^7.31.11",
"eslint-plugin-react-hooks": "^4.6.0",
Expand Down
116 changes: 86 additions & 30 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,7 +1686,6 @@ __metadata:
eslint-import-resolver-typescript: ^3.6.1
eslint-plugin-import: ^2.29.1
eslint-plugin-jest: ^27.2.2
eslint-plugin-jest-formatting: ^3.1.0
eslint-plugin-prettier: ^5.0.0
eslint-plugin-react: ^7.31.11
eslint-plugin-react-hooks: ^4.6.0
Expand All @@ -1713,8 +1712,7 @@ __metadata:
eslint-import-resolver-typescript: "npm:^3.6.1"
eslint-plugin-eslint-plugin: "npm:^5.1.0"
eslint-plugin-import: "npm:^2.29.1"
eslint-plugin-jest: "npm:^27.2.2"
eslint-plugin-jest-formatting: "npm:^3.1.0"
eslint-plugin-jest: "npm:^28.9.0"
eslint-plugin-prettier: "npm:^5.0.0"
eslint-plugin-react: "npm:^7.31.11"
eslint-plugin-react-hooks: "npm:^4.6.0"
Expand All @@ -1736,7 +1734,6 @@ __metadata:
eslint-import-resolver-typescript: ^3.6.1
eslint-plugin-import: ^2.29.1
eslint-plugin-jest: ^27.2.2
eslint-plugin-jest-formatting: ^3.1.0
eslint-plugin-prettier: ^5.0.0
eslint-plugin-react: ^7.31.11
eslint-plugin-react-hooks: ^4.6.0
Expand Down Expand Up @@ -3956,6 +3953,16 @@ __metadata:
languageName: node
linkType: hard

"@typescript-eslint/scope-manager@npm:8.13.0":
version: 8.13.0
resolution: "@typescript-eslint/scope-manager@npm:8.13.0"
dependencies:
"@typescript-eslint/types": "npm:8.13.0"
"@typescript-eslint/visitor-keys": "npm:8.13.0"
checksum: 10c0/1924b3e740e244d98f8a99740b4196d23ae3263303b387c66db94e140455a3132e603a130f3f70fc71e37f4bda5d0c0c67224ae3911908b097ef3f972c136be4
languageName: node
linkType: hard

"@typescript-eslint/type-utils@npm:6.18.1":
version: 6.18.1
resolution: "@typescript-eslint/type-utils@npm:6.18.1"
Expand Down Expand Up @@ -3987,6 +3994,13 @@ __metadata:
languageName: node
linkType: hard

"@typescript-eslint/types@npm:8.13.0":
version: 8.13.0
resolution: "@typescript-eslint/types@npm:8.13.0"
checksum: 10c0/bd3f88b738a92b2222f388bcf831357ef8940a763c2c2eb1947767e1051dd2f8bee387020e8cf4c2309e4142353961b659abc2885e30679109a0488b0bfefc23
languageName: node
linkType: hard

"@typescript-eslint/typescript-estree@npm:5.62.0":
version: 5.62.0
resolution: "@typescript-eslint/typescript-estree@npm:5.62.0"
Expand Down Expand Up @@ -4024,6 +4038,25 @@ __metadata:
languageName: node
linkType: hard

"@typescript-eslint/typescript-estree@npm:8.13.0":
version: 8.13.0
resolution: "@typescript-eslint/typescript-estree@npm:8.13.0"
dependencies:
"@typescript-eslint/types": "npm:8.13.0"
"@typescript-eslint/visitor-keys": "npm:8.13.0"
debug: "npm:^4.3.4"
fast-glob: "npm:^3.3.2"
is-glob: "npm:^4.0.3"
minimatch: "npm:^9.0.4"
semver: "npm:^7.6.0"
ts-api-utils: "npm:^1.3.0"
peerDependenciesMeta:
typescript:
optional: true
checksum: 10c0/2d45bc5ed4ac352bea927167ac28ef23bd13b6ae352ff50e85cddfdc4b06518f1dd4ae5f2495e30d6f62d247987677a4e807065d55829ba28963908a821dc96d
languageName: node
linkType: hard

"@typescript-eslint/utils@npm:6.18.1":
version: 6.18.1
resolution: "@typescript-eslint/utils@npm:6.18.1"
Expand All @@ -4041,7 +4074,7 @@ __metadata:
languageName: node
linkType: hard

"@typescript-eslint/utils@npm:^5.10.0, @typescript-eslint/utils@npm:^5.38.1, @typescript-eslint/utils@npm:^5.58.0":
"@typescript-eslint/utils@npm:^5.38.1, @typescript-eslint/utils@npm:^5.58.0":
version: 5.62.0
resolution: "@typescript-eslint/utils@npm:5.62.0"
dependencies:
Expand All @@ -4059,6 +4092,20 @@ __metadata:
languageName: node
linkType: hard

"@typescript-eslint/utils@npm:^6.0.0 || ^7.0.0 || ^8.0.0":
version: 8.13.0
resolution: "@typescript-eslint/utils@npm:8.13.0"
dependencies:
"@eslint-community/eslint-utils": "npm:^4.4.0"
"@typescript-eslint/scope-manager": "npm:8.13.0"
"@typescript-eslint/types": "npm:8.13.0"
"@typescript-eslint/typescript-estree": "npm:8.13.0"
peerDependencies:
eslint: ^8.57.0 || ^9.0.0
checksum: 10c0/3fc5a7184a949df5f5b64f6af039a1d21ef7fe15f3d88a5d485ccbb535746d18514751143993a5aee287228151be3e326baf8f899a0a0a93368f6f20857ffa6d
languageName: node
linkType: hard

"@typescript-eslint/visitor-keys@npm:5.62.0":
version: 5.62.0
resolution: "@typescript-eslint/visitor-keys@npm:5.62.0"
Expand All @@ -4079,6 +4126,16 @@ __metadata:
languageName: node
linkType: hard

"@typescript-eslint/visitor-keys@npm:8.13.0":
version: 8.13.0
resolution: "@typescript-eslint/visitor-keys@npm:8.13.0"
dependencies:
"@typescript-eslint/types": "npm:8.13.0"
eslint-visitor-keys: "npm:^3.4.3"
checksum: 10c0/50b35f3cf673aaed940613f0007f7c4558a89ebef15c49824e65b6f084b700fbf01b01a4e701e24bbe651297a39678645e739acd255255f1603867a84bef0383
languageName: node
linkType: hard

"@ungap/structured-clone@npm:^1.2.0":
version: 1.2.0
resolution: "@ungap/structured-clone@npm:1.2.0"
Expand Down Expand Up @@ -6669,30 +6726,21 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-jest-formatting@npm:^3.1.0":
version: 3.1.0
resolution: "eslint-plugin-jest-formatting@npm:3.1.0"
peerDependencies:
eslint: ">=0.8.0"
checksum: 10c0/fac94186abdfbb4059134171835fdce7941b09e3c0b6cab17661c2a2d6a80fc9452f476f0fe2062c524e08f9ff61cf1d669f7c6f7216db85016d2aeff701cbd6
languageName: node
linkType: hard

"eslint-plugin-jest@npm:^27.2.2":
version: 27.6.1
resolution: "eslint-plugin-jest@npm:27.6.1"
"eslint-plugin-jest@npm:^28.9.0":
version: 28.9.0
resolution: "eslint-plugin-jest@npm:28.9.0"
dependencies:
"@typescript-eslint/utils": "npm:^5.10.0"
"@typescript-eslint/utils": "npm:^6.0.0 || ^7.0.0 || ^8.0.0"
peerDependencies:
"@typescript-eslint/eslint-plugin": ^5.0.0 || ^6.0.0
eslint: ^7.0.0 || ^8.0.0
"@typescript-eslint/eslint-plugin": ^6.0.0 || ^7.0.0 || ^8.0.0
eslint: ^7.0.0 || ^8.0.0 || ^9.0.0
jest: "*"
peerDependenciesMeta:
"@typescript-eslint/eslint-plugin":
optional: true
jest:
optional: true
checksum: 10c0/61f5f8ba5a40fcc26918a5e5d740b6ab0ffcb7aee96f4e2357dac44217394d7805ba155e6deb5a3575e6dc369505f29aa17a39507c2aaa8fed9a676277bf3dbc
checksum: 10c0/56b0d2fb18a32bf56b0eb8c7790c355513535a239451d9d00184829cbd0ba35b6c68eec64e850a6299453f9c37338b6797d3184594c0326c8fdcc029024065b8
languageName: node
linkType: hard

Expand Down Expand Up @@ -7012,8 +7060,7 @@ __metadata:
eslint-config-prettier: "npm:^9.0.0"
eslint-import-resolver-typescript: "npm:^3.6.1"
eslint-plugin-import: "npm:^2.29.1"
eslint-plugin-jest: "npm:^27.2.2"
eslint-plugin-jest-formatting: "npm:^3.1.0"
eslint-plugin-jest: "npm:^28.9.0"
eslint-plugin-prettier: "npm:^5.0.0"
eslint-plugin-react: "npm:^7.31.11"
eslint-plugin-react-hooks: "npm:^4.6.0"
Expand Down Expand Up @@ -7262,7 +7309,7 @@ __metadata:
languageName: node
linkType: hard

"fast-glob@npm:^3.2.5, fast-glob@npm:^3.2.9, fast-glob@npm:^3.3.1":
"fast-glob@npm:^3.2.5, fast-glob@npm:^3.2.9, fast-glob@npm:^3.3.1, fast-glob@npm:^3.3.2":
version: 3.3.2
resolution: "fast-glob@npm:3.3.2"
dependencies:
Expand Down Expand Up @@ -10978,7 +11025,7 @@ __metadata:
languageName: node
linkType: hard

"minimatch@npm:9.0.3, minimatch@npm:^9.0.0, minimatch@npm:^9.0.1, minimatch@npm:^9.0.3, minimatch@npm:~9.0.3":
"minimatch@npm:9.0.3":
version: 9.0.3
resolution: "minimatch@npm:9.0.3"
dependencies:
Expand All @@ -11005,6 +11052,15 @@ __metadata:
languageName: node
linkType: hard

"minimatch@npm:^9.0.0, minimatch@npm:^9.0.1, minimatch@npm:^9.0.3, minimatch@npm:^9.0.4, minimatch@npm:~9.0.3":
version: 9.0.5
resolution: "minimatch@npm:9.0.5"
dependencies:
brace-expansion: "npm:^2.0.1"
checksum: 10c0/de96cf5e35bdf0eab3e2c853522f98ffbe9a36c37797778d2665231ec1f20a9447a7e567cb640901f89e4daaa95ae5d70c65a9e8aa2bb0019b6facbc3c0575ed
languageName: node
linkType: hard

"minimist-options@npm:4.1.0":
version: 4.1.0
resolution: "minimist-options@npm:4.1.0"
Expand Down Expand Up @@ -13483,7 +13539,7 @@ __metadata:
languageName: node
linkType: hard

"semver@npm:^7.0.0, semver@npm:^7.1.1, semver@npm:^7.3.4, semver@npm:^7.3.5, semver@npm:^7.3.7, semver@npm:^7.3.8, semver@npm:^7.5.2, semver@npm:^7.5.3, semver@npm:^7.5.4":
"semver@npm:^7.0.0, semver@npm:^7.1.1, semver@npm:^7.3.4, semver@npm:^7.3.5, semver@npm:^7.3.7, semver@npm:^7.3.8, semver@npm:^7.5.2, semver@npm:^7.5.3, semver@npm:^7.5.4, semver@npm:^7.6.0":
version: 7.6.3
resolution: "semver@npm:7.6.3"
bin:
Expand Down Expand Up @@ -14489,12 +14545,12 @@ __metadata:
languageName: node
linkType: hard

"ts-api-utils@npm:^1.0.1":
version: 1.0.3
resolution: "ts-api-utils@npm:1.0.3"
"ts-api-utils@npm:^1.0.1, ts-api-utils@npm:^1.3.0":
version: 1.4.0
resolution: "ts-api-utils@npm:1.4.0"
peerDependencies:
typescript: ">=4.2.0"
checksum: 10c0/9408338819c3aca2a709f0bc54e3f874227901506cacb1163612a6c8a43df224174feb965a5eafdae16f66fc68fd7bfee8d3275d0fa73fbb8699e03ed26520c9
checksum: 10c0/1b2bfa50ea52771d564bb143bb69010d25cda03ed573095fbac9b86f717012426443af6647e00e3db70fca60360482a30c1be7cf73c3521c321f6bf5e3594ea0
languageName: node
linkType: hard

Expand Down
Loading