fix: resolve linter issues and add national pagination support #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following release branch creation for v2.2.0, updating develop branch to target the next minor version v2.3.0. Changes: - Update version annotations to 2.3.0 - Regenerate API documentation - Prepare for next development cycle This maintains the Git Flow pattern where develop always contains the next planned version.
chore: bump version to v2.3.0 for next development cycle
- Remove swagger file upload to server (HTML, JSON, YAML) - Remove swagger documentation generation from deployment workflow - Remove server-side documentation directory handling - Simplify deployment to only handle binary deployment - Keep swagger generation in repo for development/CI purposes only
- Create .htaccess configuration for Apache/LiteSpeed servers - Proxy /api/v1/*, /swagger/*, and /docs requests to Go application - Preserve static file serving for root domain and assets - Add CORS headers and security headers - Enable compression and caching for static assets - Fix Swagger UI accessibility at /swagger/index.html - Remove root redirect handler to avoid conflicts with static site
- Add test file version updates to release branch creation workflow - Update both release branch and develop branch version bump sections - Include covid_handler_test.go version assertions updates - Fix test version expectations to match current version (2.3.0) - Ensure all version-related files stay in sync during automated bumps
- Remove github.com/swaggo/http-swagger dependency - Serve API spec via /api/v1/swagger.json endpoint - Update .htaccess to serve static Swagger UI files - Reduce binary size from 19MB to 6.8MB (64% reduction) - Maintain same URLs: /swagger/ and /docs redirect
- Add API specification deployment step after binary deployment - Generate and upload swagger.json to server docs directory - Add Swagger JSON endpoint verification to health checks - Update deployment summary to reflect optimized binary size - Include Swagger endpoint verification in deployment status
refactor: migrate Swagger UI to static files
- Make nullable database fields properly nullable (*int64) in ProvinceCase model - Add null-safe transformation in ProvinceCaseResponse - Fix SQL scan errors for person_under_observation and related fields - Add page parameter support in ParsePaginationParams utility function Resolves SQL scan error: "converting NULL to int64 is unsupported"
- Consistent error messages for count and query operations - Match patterns from national case repository - Improve error context in paginated methods
- Convert direct integer values to pointer references - Use inline pointer creation for nullable database fields - Update test assertions to dereference pointers properly - Fix compilation errors in model tests
- Implement paginated methods in national case repository - Add pagination support to COVID service layer - Update handlers with pagination parameters and responses - Add comprehensive integration tests for paginated endpoints - Maintain backward compatibility with all=true parameter
- Add newline to LICENSE file - Add newline to Makefile - Add newline to generate-changelog.rb
📊 Code Coverage ReportTotal Coverage: 45.1% Coverage by Package
Detailed CoverageClick to expand detailed coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan